Request::createFromIlluminateRequest() - Code Metrics - Inspection of "refactor to improve readability" - spatie/laravel-slack-slash-command - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9ca3c4...0e5848 )

by Freek

created 2016-07-13 20:00 UTC

Request::createFromIlluminateRequest() A

↳ Parent: Request

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	16
nc	1
nop	1

<?php

namespace Spatie\SlashCommand;

use Illuminate\Http\Request as IlluminateRequest;

class Request
{
    /** @var string */
    public $token;

    /** @var string */
    public $teamId;

    /** @var string */
    public $teamDomain;

    /** @var string */
    public $channelName;

    /** @var string */
    public $userId;

    /** @var string */
    public $userName;

    /** @var string */
    public $command;

    /** @var string */
    public $text;

    /** @var string */
    public $responseUrl;

    public static function createFromIlluminateRequest(IlluminateRequest $illuminateRequest): Request
    {
        return collect([
            'token',
            'teamId',
            'teamDomain',
            'channelId',
            'channelName',
            'userId',
            'userName',
            'command',
            'text',
            'responseUrl',
        ])->reduce(function (Request $request, string $propertyName) use ($illuminateRequest) {
            $request->$propertyName = $illuminateRequest->get(snake_case($propertyName));
            return $request;
        }, new static());
    }

    public function get(string $propertyName)
    {
        return $this->$propertyName;
    }

    public function all(): array
    {
        return get_object_vars($this);
    }
}


1			<?php
2
3			namespace Spatie\SlashCommand;
4
5			use Illuminate\Http\Request as IlluminateRequest;
6
7			class Request
8			{
9			/** @var string */
10			public $token;
11
12			/** @var string */
13			public $teamId;
14
15			/** @var string */
16			public $teamDomain;
17
18			/** @var string */
19			public $channelName;
20
21			/** @var string */
22			public $userId;
23
24			/** @var string */
25			public $userName;
26
27			/** @var string */
28			public $command;
29
30			/** @var string */
31			public $text;
32
33			/** @var string */
34			public $responseUrl;
35
36			public static function createFromIlluminateRequest(IlluminateRequest $illuminateRequest): Request
37			{
38			return collect([
39			'token',
40			'teamId',
41			'teamDomain',
42			'channelId',
43			'channelName',
44			'userId',
45			'userName',
46			'command',
47			'text',
48			'responseUrl',
49			])->reduce(function (Request $request, string $propertyName) use ($illuminateRequest) {
50			$request->$propertyName = $illuminateRequest->get(snake_case($propertyName));
51			return $request;
52			}, new static());
53			}
54
55			public function get(string $propertyName)
56			{
57			return $this->$propertyName;
58			}
59
60			public function all(): array
61			{
62			return get_object_vars($this);
63			}
64			}
65

spatie / laravel-slack-slash-command

GitHub Access Token became invalid

Push — master ( 9ca3c4...0e5848 )

Request::createFromIlluminateRequest() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like