Controller::guardAgainstInvalidRequest() - Code Metrics - Inspection of "new signature verifying" - spatie/laravel-slack-slash-command - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#76)

unknown

created 2019-01-15 16:41 UTC

Controller::guardAgainstInvalidRequest() A

↳ Parent: Controller

Complexity

Conditions	4
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.7333
c	0
b	0
f	0
cc	4
nc	5
nop	0

<?php

namespace Spatie\SlashCommand;

use Exception;
use Illuminate\Config\Repository;
use Illuminate\Http\Request as IlluminateRequest;
use Spatie\SlashCommand\Exceptions\InvalidHandler;
use Spatie\SlashCommand\Handlers\SignatureHandler;
use Illuminate\Http\Response as IlluminateResponse;
use Illuminate\Routing\Controller as IlluminateController;
use Spatie\SlashCommand\Exceptions\RequestCouldNotBeHandled;
use Spatie\SlashCommand\Exceptions\SlackSlashCommandException;

class Controller extends IlluminateController
{
    /** @var \Spatie\SlashCommand\Request */
    protected $request;

    /** @var \Illuminate\Support\Collection */
    protected $config;

    public function __construct(IlluminateRequest $request, Repository $config)
    {
        $this->request = Request::createFromIlluminateRequest($request);


        $this->config = collect($config->get('laravel-slack-slash-command'));
    }

    public function getResponse(): IlluminateResponse
    {
        $handler = $this->determineHandler();

        try {
            if ($handler instanceof SignatureHandler) {
                $handler->validate();
            }
            $response = $handler->handle($this->request);
        } catch (SlackSlashCommandException $exception) {
            $response = $exception->getResponse($this->request);
        } catch (Exception $exception) {
            $response = $this->convertToResponse($exception);
        }

        return $response->getIlluminateResponse();
    }

    /**
     * @return \Spatie\SlashCommand\Handlers\BaseHandler
     *
     * @throws \Spatie\SlashCommand\Exceptions\RequestCouldNotBeHandled
     */
    protected function determineHandler()
    {
        $handler = collect($this->config->get('handlers'))
            ->map(function (string $handlerClassName) {
                if (! class_exists($handlerClassName)) {
                    throw InvalidHandler::handlerDoesNotExist($handlerClassName);
                }

                return new $handlerClassName($this->request);
            })
            ->filter(function (HandlesSlashCommand $handler) {
                return $handler->canHandle($this->request);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            })
            ->first();

        if (! $handler) {
            throw RequestCouldNotBeHandled::noHandlerFound($this->request);
        }

        return $handler;
    }

    protected function convertToResponse(Exception $exception) : Response
    {
        $message = config('app.debug') ? (string) $exception : 'Whoops, something went wrong...';

        $exception = new SlackSlashCommandException(
            $message,
            $exception->getCode(),
            $exception
        );

        $response = $exception->getResponse($this->request);

        return $response;
    }
}


1			<?php
2
3			namespace Spatie\SlashCommand;
4
5			use Exception;
6			use Illuminate\Config\Repository;
7			use Illuminate\Http\Request as IlluminateRequest;
8			use Spatie\SlashCommand\Exceptions\InvalidHandler;
9			use Spatie\SlashCommand\Handlers\SignatureHandler;
10			use Illuminate\Http\Response as IlluminateResponse;
11			use Illuminate\Routing\Controller as IlluminateController;
12			use Spatie\SlashCommand\Exceptions\RequestCouldNotBeHandled;
13			use Spatie\SlashCommand\Exceptions\SlackSlashCommandException;
14
15			class Controller extends IlluminateController
16			{
17			/** @var \Spatie\SlashCommand\Request */
18			protected $request;
19
20			/** @var \Illuminate\Support\Collection */
21			protected $config;
22
23			public function __construct(IlluminateRequest $request, Repository $config)
24			{
25			$this->request = Request::createFromIlluminateRequest($request);
			0 ignored issues – show Documentation Bug introduced 2018-02-12 08:54 UTC by Report Bug Copy Issue Report It seems like `\Spatie\SlashCommand\Req...minateRequest($request)` of type `object<self>` is incompatible with the declared type `object<Spatie\SlashCommand\Request>` of property `$request`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
26
27			$this->config = collect($config->get('laravel-slack-slash-command'));
28			}
29
30			public function getResponse(): IlluminateResponse
31			{
32			$handler = $this->determineHandler();
33
34			try {
35			if ($handler instanceof SignatureHandler) {
36			$handler->validate();
37			}
38			$response = $handler->handle($this->request);
39			} catch (SlackSlashCommandException $exception) {
40			$response = $exception->getResponse($this->request);
41			} catch (Exception $exception) {
42			$response = $this->convertToResponse($exception);
43			}
44
45			return $response->getIlluminateResponse();
46			}
47
48			/**
49			* @return \Spatie\SlashCommand\Handlers\BaseHandler
50			*
51			* @throws \Spatie\SlashCommand\Exceptions\RequestCouldNotBeHandled
52			*/
53			protected function determineHandler()
54			{
55			$handler = collect($this->config->get('handlers'))
56			->map(function (string $handlerClassName) {
57			if (! class_exists($handlerClassName)) {
58			throw InvalidHandler::handlerDoesNotExist($handlerClassName);
59			}
60
61			return new $handlerClassName($this->request);
62			})
63			->filter(function (HandlesSlashCommand $handler) {
64			return $handler->canHandle($this->request);
			0 ignored issues – show Bug introduced 2016-10-03 09:53 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Spatie\SlashCommand\HandlesSlashCommand` as the method `canHandle()` does only exist in the following implementations of said interface: `Spatie\SlashCommand\Handlers\BaseHandler`, `Spatie\SlashCommand\Handlers\CatchAll`, `Spatie\SlashCommand\Handlers\Help`, `Spatie\SlashCommand\Handlers\SignatureHandler`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
65			})
66			->first();
67
68			if (! $handler) {
69			throw RequestCouldNotBeHandled::noHandlerFound($this->request);
70			}
71
72			return $handler;
73			}
74
75			protected function convertToResponse(Exception $exception) : Response
76			{
77			$message = config('app.debug') ? (string) $exception : 'Whoops, something went wrong...';
78
79			$exception = new SlackSlashCommandException(
80			$message,
81			$exception->getCode(),
82			$exception
83			);
84
85			$response = $exception->getResponse($this->request);
86
87			return $response;
88			}
89			}
90

spatie / laravel-slack-slash-command

GitHub Access Token became invalid

Pull Request — master (#76)

Controller::guardAgainstInvalidRequest() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like