Spatie\SlashCommand\SlashCommandHandler\BaseHandler

Complexity

Total Complexity

3

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
	handleCurrentRequest()	0	1	?
	canHandleCurrentRequest()	0	1	?
A	getCommandText()	0	4	1
A	respond()	0	4	1

<?php

namespace Spatie\SlashCommand\SlashCommandHandler;

use Illuminate\Http\Request;
use Spatie\SlashCommand\SlashCommandResponse;

abstract class BaseHandler
{
    /** @var \Spatie\SlashCommand\SlashCommandRequest */
    protected $request;

    public function __construct(Request $request) {

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

        $this->request = $request;

It seems like $request of type object<Illuminate\Http\Request> is incompatible with the declared type object<Spatie\SlashCommand\SlashCommandRequest> of property $request.

    }
    
    abstract public function handleCurrentRequest(): SlashCommandResponse;

    abstract public function canHandleCurrentRequest(): bool;

    public function getCommandText()
    {
        return $this->request->get('text');
    }

    public function respond(string $text): SlashCommandResponse
    {
        return SlashCommandResponse::createForRequest($this->request)->setText($text);
    }
}