Issues in SitemapIndex.php (master) - Issues in master - spatie/laravel-sitemap - Measure and Improve Code Quality continuously with Scrutinizer

Issues (11)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/SitemapIndex.php (3 issues)

Labels

Bug 3

Severity

Major 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Spatie\Sitemap;

use Illuminate\Contracts\Support\Responsable;
use Illuminate\Support\Facades\Response;
use Illuminate\Support\Facades\Storage;
use Spatie\Sitemap\Tags\Sitemap;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Spatie\Sitemap\Tags\Tag;

class SitemapIndex implements Responsable
{
    /** @var array */
    protected $tags = [];

    /**
     * @return static
     */
    public static function create()
    {
        return new static();
    }

    /**
     * @param string|\Spatie\Sitemap\Tags\Tag $tag
     *
     * @return $this
     */
    public function add($tag)
    {
        if (is_string($tag)) {
            $tag = Sitemap::create($tag);
        }

        $this->tags[] = $tag;

        return $this;
    }

    /**
     * Get sitemap tag.
     *
     * @param string $url
     *
     * @return \Spatie\Sitemap\Tags\Sitemap|null
     */
    public function getSitemap(string $url)
    {
        return collect($this->tags)->first(function (Tag $tag) use ($url) {
            return $tag->getType() === 'sitemap' && $tag->url === $url;

        });
    }

    /**
     * Check if there is the provided sitemap in the index.
     *
     * @param string $url
     *
     * @return bool
     */
    public function hasSitemap(string $url): bool
    {
        return (bool) $this->getSitemap($url);
    }

    /**
     * Get the inflated template content.
     *
     * @return string
     */
    public function render(): string
    {
        $tags = $this->tags;

        return view('laravel-sitemap::sitemapIndex/index')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with(compact('tags'))
            ->render();
    }

    /**
     * @param string $path
     *
     * @return $this
     */
    public function writeToFile(string $path)
    {
        file_put_contents($path, $this->render());

        return $this;
    }

    public function writeToDisk(string $disk, string $path): self
    {
        Storage::disk($disk)->put($path, $this->render());

        return $this;
    }

    /**
     * Create an HTTP response that represents the object.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function toResponse($request)
    {
        return Response::make($this->render(), 200, [
            'Content-Type' => 'text/xml',
        ]);
    }
}


1			<?php
2
3			namespace Spatie\Sitemap;
4
5			use Illuminate\Contracts\Support\Responsable;
6			use Illuminate\Support\Facades\Response;
7			use Illuminate\Support\Facades\Storage;
8			use Spatie\Sitemap\Tags\Sitemap;
			0 ignored issues – show Bug introduced 2017-01-31 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Spatie\Sitemap\Sitemap`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
9			use Spatie\Sitemap\Tags\Tag;
10
11			class SitemapIndex implements Responsable
12			{
13			/** @var array */
14			protected $tags = [];
15
16			/**
17			* @return static
18			*/
19			public static function create()
20			{
21			return new static();
22			}
23
24			/**
25			* @param string\|\Spatie\Sitemap\Tags\Tag $tag
26			*
27			* @return $this
28			*/
29			public function add($tag)
30			{
31			if (is_string($tag)) {
32			$tag = Sitemap::create($tag);
33			}
34
35			$this->tags[] = $tag;
36
37			return $this;
38			}
39
40			/**
41			* Get sitemap tag.
42			*
43			* @param string $url
44			*
45			* @return \Spatie\Sitemap\Tags\Sitemap\|null
46			*/
47			public function getSitemap(string $url)
48			{
49			return collect($this->tags)->first(function (Tag $tag) use ($url) {
50			return $tag->getType() === 'sitemap' && $tag->url === $url;
			0 ignored issues – show Bug introduced 2017-01-31 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `url` does not seem to exist in `Spatie\Sitemap\Tags\Tag`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
51			});
52			}
53
54			/**
55			* Check if there is the provided sitemap in the index.
56			*
57			* @param string $url
58			*
59			* @return bool
60			*/
61			public function hasSitemap(string $url): bool
62			{
63			return (bool) $this->getSitemap($url);
64			}
65
66			/**
67			* Get the inflated template content.
68			*
69			* @return string
70			*/
71			public function render(): string
72			{
73			$tags = $this->tags;
74
75			return view('laravel-sitemap::sitemapIndex/index')
			0 ignored issues – show Bug introduced 2017-01-31 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
76			->with(compact('tags'))
77			->render();
78			}
79
80			/**
81			* @param string $path
82			*
83			* @return $this
84			*/
85			public function writeToFile(string $path)
86			{
87			file_put_contents($path, $this->render());
88
89			return $this;
90			}
91
92			public function writeToDisk(string $disk, string $path): self
93			{
94			Storage::disk($disk)->put($path, $this->render());
95
96			return $this;
97			}
98
99			/**
100			* Create an HTTP response that represents the object.
101			*
102			* @param \Illuminate\Http\Request $request
103			* @return \Symfony\Component\HttpFoundation\Response
104			*/
105			public function toResponse($request)
106			{
107			return Response::make($this->render(), 200, [
108			'Content-Type' => 'text/xml',
109			]);
110			}
111			}
112

spatie / laravel-sitemap

Issues (11)

Security Analysis no request data

src/SitemapIndex.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like