Sitemap::writeToDisk() - Code Metrics - Inspection of "add writeToDisk() logic (#283)" - spatie/laravel-sitemap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f303da...fa41a0 )

by Freek

created 2020-01-20 12:55 UTC

Sitemap::writeToDisk() A

↳ Parent: Sitemap

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

namespace Spatie\Sitemap;

use Illuminate\Contracts\Support\Responsable;
use Illuminate\Support\Facades\Response;
use Illuminate\Support\Facades\Storage;
use Spatie\Sitemap\Tags\Tag;
use Spatie\Sitemap\Tags\Url;

class Sitemap implements Responsable
{
    /** @var array */
    protected $tags = [];

    public static function create(): self
    {
        return new static();
    }

    /**
     * @param string|\Spatie\Sitemap\Tags\Tag $tag
     *
     * @return $this
     */
    public function add($tag): self
    {
        if (is_string($tag)) {
            $tag = Url::create($tag);
        }

        if (! in_array($tag, $this->tags)) {
            $this->tags[] = $tag;
        }

        return $this;
    }

    public function getTags(): array
    {
        return $this->tags;
    }

    public function getUrl(string $url): ?Url
    {
        return collect($this->tags)->first(function (Tag $tag) use ($url) {
            return $tag->getType() === 'url' && $tag->url === $url;

        });
    }

    public function hasUrl(string $url): bool
    {
        return (bool) $this->getUrl($url);
    }

    public function render(): string
    {
        sort($this->tags);

        $tags = collect($this->tags)->unique('url');

        return view('laravel-sitemap::sitemap')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with(compact('tags'))
            ->render();
    }

    public function writeToFile(string $path): self
    {
        file_put_contents($path, $this->render());

        return $this;
    }

    public function writeToDisk(string $disk, string $path): self
    {
        Storage::disk($disk)->put($path, $this->render());

        return $this;
    }

    /**
     * Create an HTTP response that represents the object.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function toResponse($request)
    {
        return Response::make($this->render(), 200, [
            'Content-Type' => 'text/xml',
        ]);
    }
}


1			<?php
2
3			namespace Spatie\Sitemap;
4
5			use Illuminate\Contracts\Support\Responsable;
6			use Illuminate\Support\Facades\Response;
7			use Illuminate\Support\Facades\Storage;
8			use Spatie\Sitemap\Tags\Tag;
9			use Spatie\Sitemap\Tags\Url;
10
11			class Sitemap implements Responsable
12			{
13			/** @var array */
14			protected $tags = [];
15
16			public static function create(): self
17			{
18			return new static();
19			}
20
21			/**
22			* @param string\|\Spatie\Sitemap\Tags\Tag $tag
23			*
24			* @return $this
25			*/
26			public function add($tag): self
27			{
28			if (is_string($tag)) {
29			$tag = Url::create($tag);
30			}
31
32			if (! in_array($tag, $this->tags)) {
33			$this->tags[] = $tag;
34			}
35
36			return $this;
37			}
38
39			public function getTags(): array
40			{
41			return $this->tags;
42			}
43
44			public function getUrl(string $url): ?Url
45			{
46			return collect($this->tags)->first(function (Tag $tag) use ($url) {
47			return $tag->getType() === 'url' && $tag->url === $url;
			0 ignored issues – show Bug introduced 2016-12-01 13:21 UTC by Report Bug Copy Issue Report The property `url` does not seem to exist in `Spatie\Sitemap\Tags\Tag`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
48			});
49			}
50
51			public function hasUrl(string $url): bool
52			{
53			return (bool) $this->getUrl($url);
54			}
55
56			public function render(): string
57			{
58			sort($this->tags);
59
60			$tags = collect($this->tags)->unique('url');
61
62			return view('laravel-sitemap::sitemap')
			0 ignored issues – show Bug introduced 2016-08-15 18:13 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
63			->with(compact('tags'))
64			->render();
65			}
66
67			public function writeToFile(string $path): self
68			{
69			file_put_contents($path, $this->render());
70
71			return $this;
72			}
73
74			public function writeToDisk(string $disk, string $path): self
75			{
76			Storage::disk($disk)->put($path, $this->render());
77
78			return $this;
79			}
80
81			/**
82			* Create an HTTP response that represents the object.
83			*
84			* @param \Illuminate\Http\Request $request
85			* @return \Symfony\Component\HttpFoundation\Response
86			*/
87			public function toResponse($request)
88			{
89			return Response::make($this->render(), 200, [
90			'Content-Type' => 'text/xml',
91			]);
92			}
93			}
94

spatie / laravel-sitemap

Push — master ( f303da...fa41a0 )

Sitemap::writeToDisk() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like