Spatie\Sitemap\Sitemap

Complexity

Total Complexity

11

Size/Duplication

Total Lines	89
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	4	1
A	add()	0	17	4
A	update()	0	6	1
A	getUrl()	0	6	2
A	hasUrl()	0	4	1
A	render()	0	10	1
A	writeToFile()	0	6	1

<?php

namespace Spatie\Sitemap;

use Spatie\Sitemap\Tags\Tag;
use Spatie\Sitemap\Tags\Url;

class Sitemap
{
    /** @var array */
    protected $tags = [];

    /**
     * @return static
     */
    public static function create()
    {
        return new static();
    }

    /**
     * @param string|\Spatie\Sitemap\Tags\Tag $tag
     *
     * @return $this
     */
    public function add($tag)
    {
        if (is_string($tag)) {
            $tag = Url::create($tag);
        }

        if (! $this->hasUrl($tag->url)) {
            $this->tags[] = $tag;
        } else {
            $oldTag = $this->getUrl($tag->url);

The property url does not seem to exist in Spatie\Sitemap\Tags\Tag.

            if ($tag->isNewer($oldTag)) {
                $this->update($oldTag, $tag);

It seems like $oldTag defined by $this->getUrl($tag->url) on line 35 can be null; however, Spatie\Sitemap\Sitemap::update() does not accept null, maybe add an additional type check?

$tag of type object<Spatie\Sitemap\Tags\Tag> is not a sub-type of object<Spatie\Sitemap\Tags\Url>. It seems like you assume a child class of the class Spatie\Sitemap\Tags\Tag to be always present.

            }
        }

        return $this;
    }

    /**
     * @param Url $oldTag
     * @param Url $newTag
     *
     * @return $this
     */
    public function update(Url $oldTag, Url $newTag)
    {
        array_splice($this->tags, array_search($oldTag, $this->tags), 1, [$newTag]);

        return $this;
    }

    /**
     * @param string $url
     *
     * @return \Spatie\Sitemap\Tags\Url|null
     */
    public function getUrl(string $url)
    {
        return collect($this->tags)->first(function (Tag $tag) use ($url) {
            return $tag->getType() === 'url' && $tag->url === $url;

The property url does not seem to exist in Spatie\Sitemap\Tags\Tag.

        });
    }

    public function hasUrl(string $url): bool
    {
        return (bool) $this->getUrl($url);
    }

    public function render(): string
    {
        sort($this->tags);

        $tags = $this->tags;

        return view('laravel-sitemap::sitemap')

The method with does only exist in Illuminate\View\View, but not in Illuminate\Contracts\View\Factory.

            ->with(compact('tags'))
            ->render();
    }

    /**
     * @param string $path
     *
     * @return $this
     */
    public function writeToFile(string $path)
    {
        file_put_contents($path, $this->render());

        return $this;
    }
}