Sitemap::getTags() - Code Metrics - Inspection of "adds ability to chunk the sitemap generator (#157)" - spatie/laravel-sitemap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d132d2...52a9d6 )

by Freek

created 2018-04-30 11:19 UTC

Sitemap::getTags() A

↳ Parent: Sitemap

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Spatie\Sitemap;

use Spatie\Sitemap\Tags\Tag;
use Spatie\Sitemap\Tags\Url;

class Sitemap
{
    /** @var array */
    protected $tags = [];

    /**
     * @return static
     */
    public static function create()
    {
        return new static();
    }

    /**
     * @param string|\Spatie\Sitemap\Tags\Tag $tag
     *
     * @return $this
     */
    public function add($tag)
    {
        if (is_string($tag)) {
            $tag = Url::create($tag);
        }

        if (! in_array($tag, $this->tags)) {
            $this->tags[] = $tag;
        }

        return $this;
    }

	/**
	 * Returns tags
	 *
	 * @return array
	 */
	public function getTags()
	{
		return $this->tags;
	}

    /**
     * @param string $url
     *
     * @return \Spatie\Sitemap\Tags\Url|null
     */
    public function getUrl(string $url)
    {
        return collect($this->tags)->first(function (Tag $tag) use ($url) {
            return $tag->getType() === 'url' && $tag->url === $url;

        });
    }

    public function hasUrl(string $url): bool
    {
        return (bool) $this->getUrl($url);
    }

    public function render(): string
    {
        sort($this->tags);

        $tags = $this->tags;

        return view('laravel-sitemap::sitemap')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with(compact('tags'))
            ->render();
    }

    /**
     * @param string $path
     *
     * @return $this
     */
    public function writeToFile(string $path)
    {
        file_put_contents($path, $this->render());

        return $this;
    }
}


1			<?php
2
3			namespace Spatie\Sitemap;
4
5			use Spatie\Sitemap\Tags\Tag;
6			use Spatie\Sitemap\Tags\Url;
7
8			class Sitemap
9			{
10			/** @var array */
11			protected $tags = [];
12
13			/**
14			* @return static
15			*/
16			public static function create()
17			{
18			return new static();
19			}
20
21			/**
22			* @param string\|\Spatie\Sitemap\Tags\Tag $tag
23			*
24			* @return $this
25			*/
26			public function add($tag)
27			{
28			if (is_string($tag)) {
29			$tag = Url::create($tag);
30			}
31
32			if (! in_array($tag, $this->tags)) {
33			$this->tags[] = $tag;
34			}
35
36			return $this;
37			}
38
39			/**
40			* Returns tags
41			*
42			* @return array
43			*/
44			public function getTags()
45			{
46			return $this->tags;
47			}
48
49			/**
50			* @param string $url
51			*
52			* @return \Spatie\Sitemap\Tags\Url\|null
53			*/
54			public function getUrl(string $url)
55			{
56			return collect($this->tags)->first(function (Tag $tag) use ($url) {
57			return $tag->getType() === 'url' && $tag->url === $url;
			0 ignored issues – show Bug introduced 2016-12-01 13:21 UTC by Report Bug Copy Issue Report The property `url` does not seem to exist in `Spatie\Sitemap\Tags\Tag`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
58			});
59			}
60
61			public function hasUrl(string $url): bool
62			{
63			return (bool) $this->getUrl($url);
64			}
65
66			public function render(): string
67			{
68			sort($this->tags);
69
70			$tags = $this->tags;
71
72			return view('laravel-sitemap::sitemap')
			0 ignored issues – show Bug introduced 2016-08-15 18:13 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
73			->with(compact('tags'))
74			->render();
75			}
76
77			/**
78			* @param string $path
79			*
80			* @return $this
81			*/
82			public function writeToFile(string $path)
83			{
84			file_put_contents($path, $this->render());
85
86			return $this;
87			}
88			}
89

spatie / laravel-sitemap

Push — master ( d132d2...52a9d6 )

Sitemap::getTags() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like