Spatie\ServerMonitor\Commands\ListHosts

Complexity

Total Complexity

7

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	handle()	0	26	3
A	renderTable()	0	16	1
A	formatCheckStatusCountForHost()	0	15	2
A	formatCheckMessagesForHost()	0	11	1

<?php

namespace Spatie\ServerMonitor\Commands;

use Spatie\ServerMonitor\Models\Enums\CheckStatus;
use Spatie\ServerMonitor\Models\Host;

class ListHosts extends BaseCommand
{
    protected $signature = 'monitor:list
                            {--host= : Filter hosts by name}
                            {--check= : Filter checks by type}';

    protected $description = 'List all hosts with their checks';

    public function handle()
    {
        $hostName = $this->option('host');
        $checkType = $this->option('check');

        $hostsQuery = Host::query();

        if ($hostName) {
            $hostsQuery->where('name', 'LIKE', "%{$hostName}%");
        }

        if ($checkType) {
            $hostsQuery

The method with does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Concerns\QueriesRelationships.

                ->whereHas('checks', function ($query) use ($checkType) {
                    $query->where('type', 'LIKE', "%{$checkType}%");
                })
                ->with(['checks' => function ($query) use ($checkType) {
                    $query->where('type', 'LIKE', "%{$checkType}%");
                }]);
        }

        $hosts = $hostsQuery->get();

        $this->renderTable($hosts);

    }

    protected function renderTable($hosts)
    {
        $rows = $hosts->map(function ($host) {
            $name = $host->name;

            $checks = $this->formatCheckStatusCountForHost($host);

            $messages = $this->formatCheckMessagesForHost($host);

            return compact('name', 'checks', 'messages');
        });

        $header = ['Host', 'Checks', 'Message'];

        $this->table($header, $rows);
    }

    protected function formatCheckStatusCountForHost (Host $host): string
    {
        $statuses = collect([CheckStatus::SUCCESS, CheckStatus::FAILED, CheckStatus::NOT_YET_CHECKED, CheckStatus::WARNING]);

        $checks = $statuses
            ->map(function ($status) use ($host) {
                $checksWithStatus = $host->checks->where('status', $status);

The property checks does not exist on object<Spatie\ServerMonitor\Models\Host>. Since you implemented __get, maybe consider adding a @property annotation.

                $statusCount = $checksWithStatus->count();
                $emoji = $checksWithStatus->first()->statusAsEmoji ?? '';

                return $statusCount ? "{$emoji} {$statusCount}  " : '';
            })
            ->implode('');
        return substr($checks, 0, -2);
    }

    protected function formatCheckMessagesForHost(Host $host): string
    {
        return $host->checks

The property checks does not exist on object<Spatie\ServerMonitor\Models\Host>. Since you implemented __get, maybe consider adding a @property annotation.

            ->filter(function ($check) {
                return !empty($check->message);
            })
            ->map(function ($check) {
                return "<fg=black;bg=cyan>{$check->type}</>: {$check->message}";
            })
            ->implode("\n");
    }
}