Host - Code Metrics - Inspection of "#36 - Add configurable table names" - spatie/laravel-server-monitor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#38)

unknown

created 2017-04-17 14:53 UTC

Host A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
wmc	11
lcom	0
cbo	3
dl	0
loc	64
rs	10
c	0
b	0
f	0

8 Methods

Rating	Name	Size	Complexity
A	checks()	4	1
A	getEnabledChecksAttribute()	4	1
A	isHealthy()	4	1
A	isUnhealthy()	4	1
A	hasWarning()	4	1
A	getStatusAttribute()	16	4
A	hasCheckType()	6	1
A	getTable()	4	1

<?php

namespace Spatie\ServerMonitor\Models;

use Illuminate\Support\Collection;
use Illuminate\Database\Eloquent\Model;
use Spatie\ServerMonitor\Models\Enums\HostHealth;
use Spatie\ServerMonitor\Models\Enums\CheckStatus;
use Illuminate\Database\Eloquent\Relations\HasMany;
use Spatie\ServerMonitor\Models\Presenters\HostPresenter;
use Spatie\ServerMonitor\Models\Concerns\HasCustomProperties;

class Host extends Model
{
    use HostPresenter, HasCustomProperties;

    public $casts = [
        'custom_properties' => 'array',
    ];

    public $guarded = [];

    public function checks(): HasMany
    {
        return $this->hasMany(Check::class);
    }

    public function getTable()
    {
        return config('server-monitor.hosts_table');
    }

    public function getEnabledChecksAttribute(): Collection
    {
        return $this->checks()->enabled()->get();
    }

    public function isHealthy(): bool
    {
        return $this->status === HostHealth::HEALTHY;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function isUnhealthy(): bool
    {
        return $this->status === HostHealth::UNHEALTHY;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function hasWarning(): bool
    {
        return $this->status === HostHealth::WARNING;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getStatusAttribute(): string
    {
        if ($this->enabled_checks->count() === 0) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return HostHealth::WARNING;
        }

        if ($this->enabled_checks->contains->hasStatus(CheckStatus::FAILED)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return HostHealth::UNHEALTHY;
        }

        if ($this->enabled_checks->every->hasStatus(CheckStatus::SUCCESS)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return HostHealth::HEALTHY;
        }

        return HostHealth::WARNING;
    }

    public function hasCheckType(string $type): bool
    {
        return $this->checks->contains(function (Check $check) use ($type) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return $check->type === $type;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        });
    }
}


1			<?php
2
3			namespace Spatie\ServerMonitor\Models;
4
5			use Illuminate\Support\Collection;
6			use Illuminate\Database\Eloquent\Model;
7			use Spatie\ServerMonitor\Models\Enums\HostHealth;
8			use Spatie\ServerMonitor\Models\Enums\CheckStatus;
9			use Illuminate\Database\Eloquent\Relations\HasMany;
10			use Spatie\ServerMonitor\Models\Presenters\HostPresenter;
11			use Spatie\ServerMonitor\Models\Concerns\HasCustomProperties;
12
13			class Host extends Model
14			{
15			use HostPresenter, HasCustomProperties;
16
17			public $casts = [
18			'custom_properties' => 'array',
19			];
20
21			public $guarded = [];
22
23			public function checks(): HasMany
24			{
25			return $this->hasMany(Check::class);
26			}
27
28			public function getTable()
29			{
30			return config('server-monitor.hosts_table');
31			}
32
33			public function getEnabledChecksAttribute(): Collection
34			{
35			return $this->checks()->enabled()->get();
36			}
37
38			public function isHealthy(): bool
39			{
40			return $this->status === HostHealth::HEALTHY;
			0 ignored issues – show Documentation introduced 2017-02-22 20:50 UTC by Report Bug Copy Issue Report The property `status` does not exist on `object<Spatie\ServerMonitor\Models\Host>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
41			}
42
43			public function isUnhealthy(): bool
44			{
45			return $this->status === HostHealth::UNHEALTHY;
			0 ignored issues – show Documentation introduced 2017-02-22 20:50 UTC by Report Bug Copy Issue Report The property `status` does not exist on `object<Spatie\ServerMonitor\Models\Host>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
46			}
47
48			public function hasWarning(): bool
49			{
50			return $this->status === HostHealth::WARNING;
			0 ignored issues – show Documentation introduced 2017-02-22 20:50 UTC by Report Bug Copy Issue Report The property `status` does not exist on `object<Spatie\ServerMonitor\Models\Host>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
51			}
52
53			public function getStatusAttribute(): string
54			{
55			if ($this->enabled_checks->count() === 0) {
			0 ignored issues – show Documentation introduced 2017-02-22 20:50 UTC by Report Bug Copy Issue Report The property `enabled_checks` does not exist on `object<Spatie\ServerMonitor\Models\Host>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
56			return HostHealth::WARNING;
57			}
58
59			if ($this->enabled_checks->contains->hasStatus(CheckStatus::FAILED)) {
			0 ignored issues – show Documentation introduced 2017-02-22 20:50 UTC by Report Bug Copy Issue Report The property `enabled_checks` does not exist on `object<Spatie\ServerMonitor\Models\Host>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
60			return HostHealth::UNHEALTHY;
61			}
62
63			if ($this->enabled_checks->every->hasStatus(CheckStatus::SUCCESS)) {
			0 ignored issues – show Documentation introduced 2017-02-22 20:50 UTC by Report Bug Copy Issue Report The property `enabled_checks` does not exist on `object<Spatie\ServerMonitor\Models\Host>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
64			return HostHealth::HEALTHY;
65			}
66
67			return HostHealth::WARNING;
68			}
69
70			public function hasCheckType(string $type): bool
71			{
72			return $this->checks->contains(function (Check $check) use ($type) {
			0 ignored issues – show Documentation introduced 2017-03-01 21:32 UTC by Report Bug Copy Issue Report The property `checks` does not exist on `object<Spatie\ServerMonitor\Models\Host>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
73			return $check->type === $type;
			0 ignored issues – show Documentation introduced 2017-03-01 21:32 UTC by Report Bug Copy Issue Report The property `type` does not exist on `object<Spatie\ServerMonitor\Models\Check>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
74			});
75			}
76			}
77

spatie / laravel-server-monitor

Pull Request — master (#38)

Host A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

Duplication Side-by-Side

Filter issues like