CheckDefinition::handleFinishedProcess() - Code Metrics - Inspection of "add support for timeout" - spatie/laravel-server-monitor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c43d00...774e15 )

by Freek

created 2017-02-25 18:05 UTC

CheckDefinition::handleFinishedProcess() A

↳ Parent: CheckDefinition

Complexity

Conditions	3
Paths	5

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	9
nc	5
nop	1

<?php

namespace Spatie\ServerMonitor\CheckDefinitions;

use Exception;
use Spatie\ServerMonitor\Models\Check;
use Spatie\ServerMonitor\Models\Enums\CheckStatus;
use Symfony\Component\Process\Process;

abstract class CheckDefinition
{
    /** @var \Spatie\ServerMonitor\Models\Check */
    protected $check;

    /**
     * @param \Spatie\ServerMonitor\Models\Check $check
     *
     * @return $this
     */
    public function setCheck(Check $check)
    {
        $this->check = $check;

        return $this;
    }

    public function getCommand(): string
    {
        return $this->command;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function handleFinishedProcess(Process $process)
    {
        $this->check->storeProcessOutput($process);

        try {
            if (! $process->isSuccessful()) {
                $this->handleFailedProcess($process);

                return;
            }

            $this->handleSuccessfulProcess($process);
        } catch (Exception $exception) {
            $this->check->failed('Exception occurred: '.$exception->getMessage());
        }
    }

    abstract public function handleSuccessfulProcess(Process $process);

    public function handleFailedProcess(Process $process)
    {
        $this->check->failed("failed to run: {$process->getErrorOutput()}");
    }

    public function throttleFailingNotificationsForMinutes(): int
    {
        return config('server-monitor.notifications.throttle_failing_notifications_for_minutes');
    }

    public function performNextRunInMinutes(): int
    {
        if ($this->check->hasStatus(CheckStatus::SUCCESS)) {
            return 10;
        }

        return 0;
    }

    public function timeoutInSeconds(): int
    {
        return 10;
    }
}


1			<?php
2
3			namespace Spatie\ServerMonitor\CheckDefinitions;
4
5			use Exception;
6			use Spatie\ServerMonitor\Models\Check;
7			use Spatie\ServerMonitor\Models\Enums\CheckStatus;
8			use Symfony\Component\Process\Process;
9
10			abstract class CheckDefinition
11			{
12			/** @var \Spatie\ServerMonitor\Models\Check */
13			protected $check;
14
15			/**
16			* @param \Spatie\ServerMonitor\Models\Check $check
17			*
18			* @return $this
19			*/
20			public function setCheck(Check $check)
21			{
22			$this->check = $check;
23
24			return $this;
25			}
26
27			public function getCommand(): string
28			{
29			return $this->command;
			0 ignored issues – show Bug introduced 2017-02-18 18:45 UTC by Report Bug Copy Issue Report The property `command` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
30			}
31
32			public function handleFinishedProcess(Process $process)
33			{
34			$this->check->storeProcessOutput($process);
35
36			try {
37			if (! $process->isSuccessful()) {
38			$this->handleFailedProcess($process);
39
40			return;
41			}
42
43			$this->handleSuccessfulProcess($process);
44			} catch (Exception $exception) {
45			$this->check->failed('Exception occurred: '.$exception->getMessage());
46			}
47			}
48
49			abstract public function handleSuccessfulProcess(Process $process);
50
51			public function handleFailedProcess(Process $process)
52			{
53			$this->check->failed("failed to run: {$process->getErrorOutput()}");
54			}
55
56			public function throttleFailingNotificationsForMinutes(): int
57			{
58			return config('server-monitor.notifications.throttle_failing_notifications_for_minutes');
59			}
60
61			public function performNextRunInMinutes(): int
62			{
63			if ($this->check->hasStatus(CheckStatus::SUCCESS)) {
64			return 10;
65			}
66
67			return 0;
68			}
69
70			public function timeoutInSeconds(): int
71			{
72			return 10;
73			}
74			}
75

spatie / laravel-server-monitor

Push — master ( c43d00...774e15 )

CheckDefinition::handleFinishedProcess() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like