HostPresenter::getHealthAsEmojiAttribute() - Code Metrics - Inspection of "commit" - spatie/laravel-server-monitor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 46aa7e...25bb06 )

by Freek

created 2017-02-22 23:51 UTC

HostPresenter::getHealthAsEmojiAttribute() A

↳ Parent: HostPresenter

Complexity

Conditions	4
Paths	4

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.2
c	0
b	0
f	0
cc	4
eloc	8
nc	4
nop	0

<?php

namespace Spatie\ServerMonitor\Models\Presenters;

use Spatie\ServerMonitor\Helpers\Emoji;
use Spatie\ServerMonitor\Models\Enums\CheckStatus;
use Spatie\ServerMonitor\Models\Enums\HostHealth;

trait HostPresenter
{
    public function getHealthAsEmojiAttribute(): string
    {
        if ($this->isHealthy()) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return Emoji::ok();
        }

        if ($this->isUnhealthy()) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return Emoji::notOk();
        }

        if ($this->hasWarning()) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return Emoji::warning();
        }

        throw new Exception("Could not determine health emoji for host `{$this->id}`");
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}


1			<?php
2
3			namespace Spatie\ServerMonitor\Models\Presenters;
4
5			use Spatie\ServerMonitor\Helpers\Emoji;
6			use Spatie\ServerMonitor\Models\Enums\CheckStatus;
7			use Spatie\ServerMonitor\Models\Enums\HostHealth;
8
9			trait HostPresenter
10			{
11			public function getHealthAsEmojiAttribute(): string
12			{
13			if ($this->isHealthy()) {
			0 ignored issues – show Bug introduced 2017-02-22 23:52 UTC by Report Bug Copy Issue Report It seems like `isHealthy()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
14			return Emoji::ok();
15			}
16
17			if ($this->isUnhealthy()) {
			0 ignored issues – show Bug introduced 2017-02-22 23:52 UTC by Report Bug Copy Issue Report It seems like `isUnhealthy()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
18			return Emoji::notOk();
19			}
20
21			if ($this->hasWarning()) {
			0 ignored issues – show Bug introduced 2017-02-22 23:52 UTC by Report Bug Copy Issue Report It seems like `hasWarning()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22			return Emoji::warning();
23			}
24
25			throw new Exception("Could not determine health emoji for host `{$this->id}`");
			0 ignored issues – show Bug introduced 2017-02-22 23:52 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26			}
27			}
28

spatie / laravel-server-monitor

Push — master ( 46aa7e...25bb06 )

HostPresenter::getHealthAsEmojiAttribute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like