HandlesCheckResult - Code Metrics - spatie/laravel-server-monitor - Measure and Improve Code Quality continuously with Scrutinizer

HandlesCheckResult A
last analyzed 2020-09-09 09:12 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	43
Duplicated Lines	88.37 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	3
c	0
b	0
f	0
lcom	1
cbo	3
dl	38
loc	43
rs	10

3 Methods

Rating	Name	Duplication	Size	Complexity
A	succeed()	12	12	1
A	warn()	13	13	1
A	fail()	13	13	1

How to fix Duplicated Code

<?php

namespace Spatie\ServerMonitor\Models\Concerns;

use Spatie\ServerMonitor\Events\CheckFailed;
use Spatie\ServerMonitor\Events\CheckSucceeded;
use Spatie\ServerMonitor\Events\CheckWarning;
use Spatie\ServerMonitor\Helpers\ConsoleOutput;
use Spatie\ServerMonitor\Models\Enums\CheckStatus;

trait HandlesCheckResult
{
    public function succeed(string $message = '')

    {
        $this->status = CheckStatus::SUCCESS;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->last_run_message = $message;
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        event(new CheckSucceeded($this));
        ConsoleOutput::info($this->host->name.": check `{$this->type}` succeeded");
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return $this;
    }

    public function warn(string $warningMessage = '')

    {
        $this->status = CheckStatus::WARNING;
        $this->last_run_message = $warningMessage;

        $this->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        event(new CheckWarning($this));

        ConsoleOutput::info($this->host->name.": check `{$this->type}` issued warning");

        return $this;
    }

    public function fail(string $failureReason = '')

    {
        $this->status = CheckStatus::FAILED;
        $this->last_run_message = $failureReason;

        $this->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        event(new CheckFailed($this));

        ConsoleOutput::error($this->host->name.": check `{$this->type}` failed");

        return $this;
    }
}


1		<?php
2
3		namespace Spatie\ServerMonitor\Models\Concerns;
4
5		use Spatie\ServerMonitor\Events\CheckFailed;
6		use Spatie\ServerMonitor\Events\CheckSucceeded;
7		use Spatie\ServerMonitor\Events\CheckWarning;
8		use Spatie\ServerMonitor\Helpers\ConsoleOutput;
9		use Spatie\ServerMonitor\Models\Enums\CheckStatus;
10
11		trait HandlesCheckResult
12		{
13	View Code Duplication	public function succeed(string $message = '')
		0 ignored issues – show Duplication introduced 2017-08-03 11:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
14		{
15		$this->status = CheckStatus::SUCCESS;
		0 ignored issues – show Bug introduced 2017-04-16 08:36 UTC by Report Bug Copy Issue Report The property `status` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
16		$this->last_run_message = $message;
		0 ignored issues – show Bug introduced 2017-02-28 23:29 UTC by Report Bug Copy Issue Report The property `last_run_message` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
17
18		$this->save();
		0 ignored issues – show Bug introduced 2017-02-24 22:32 UTC by Report Bug Copy Issue Report It seems like `save()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19
20		event(new CheckSucceeded($this));
21		ConsoleOutput::info($this->host->name.": check `{$this->type}` succeeded");
		0 ignored issues – show Bug introduced 2017-02-24 22:32 UTC by Report Bug Copy Issue Report The property `host` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2017-02-24 22:32 UTC by Report Bug Copy Issue Report The property `type` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
22
23		return $this;
24		}
25
26	View Code Duplication	public function warn(string $warningMessage = '')
		0 ignored issues – show Duplication introduced 2017-08-03 11:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		{
28		$this->status = CheckStatus::WARNING;
29		$this->last_run_message = $warningMessage;
30
31		$this->save();
		0 ignored issues – show Bug introduced 2017-02-24 22:32 UTC by Report Bug Copy Issue Report It seems like `save()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32
33		event(new CheckWarning($this));
34
35		ConsoleOutput::info($this->host->name.": check `{$this->type}` issued warning");
36
37		return $this;
38		}
39
40	View Code Duplication	public function fail(string $failureReason = '')
		0 ignored issues – show Duplication introduced 2017-08-03 11:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
41		{
42		$this->status = CheckStatus::FAILED;
43		$this->last_run_message = $failureReason;
44
45		$this->save();
		0 ignored issues – show Bug introduced 2017-02-24 22:32 UTC by Report Bug Copy Issue Report It seems like `save()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
46
47		event(new CheckFailed($this));
48
49		ConsoleOutput::error($this->host->name.": check `{$this->type}` failed");
50
51		return $this;
52		}
53		}
54

spatie / laravel-server-monitor

HandlesCheckResult A last analyzed 2020-09-09 09:12 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

HandlesCheckResult A
last analyzed 2020-09-09 09:12 UTC