SchemalessAttributesTrait::initializeSchemalessAttributesTrait() - Code Metrics - Inspection of "add trait with multi-column support" - spatie/laravel-schemaless-attributes - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#64)

unknown

created 2020-06-19 14:25 UTC

initializeSchemalessAttributesTrait() A

↳ Parent: SchemalessAttributesTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0
cc	2
nc	2
nop	0

<?php

namespace Spatie\SchemalessAttributes;


use Illuminate\Support\Collection;

/**
 * @property array $schemalessAttributes
 *
 * @mixin Collection
 */
trait SchemalessAttributesTrait
{
    /**
     * Register schemalessAttributes attributes as array(cast)
     */
    public function initializeSchemalessAttributesTrait()
    {
        $casts = [];

        foreach ($this->getSchemalessAttributes() as $attribute) {
            $casts[$attribute] = 'array';
        }

        $this->mergeCasts($casts);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @return array
     */
    public function getSchemalessAttributes()
    {
        return $this->schemalessAttributes ?? [];
    }

    /**
     * @param $key
     * @return mixed|SchemalessAttributes
     */
    public function __get($key)
    {
        if (in_array($key, $this->getSchemalessAttributes())) {
            return SchemalessAttributes::createForModel($this, $key);
        }

        return parent::__get($key);
    }
}


1			<?php
2
3			namespace Spatie\SchemalessAttributes;
4
5
6			use Illuminate\Support\Collection;
7
8			/**
9			* @property array $schemalessAttributes
10			*
11			* @mixin Collection
12			*/
13			trait SchemalessAttributesTrait
14			{
15			/**
16			* Register schemalessAttributes attributes as array(cast)
17			*/
18			public function initializeSchemalessAttributesTrait()
19			{
20			$casts = [];
21
22			foreach ($this->getSchemalessAttributes() as $attribute) {
23			$casts[$attribute] = 'array';
24			}
25
26			$this->mergeCasts($casts);
			0 ignored issues – show Bug introduced 2020-06-18 22:41 UTC by Report Bug Copy Issue Report It seems like `mergeCasts()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27			}
28
29			/**
30			* @return array
31			*/
32			public function getSchemalessAttributes()
33			{
34			return $this->schemalessAttributes ?? [];
35			}
36
37			/**
38			* @param $key
39			* @return mixed\|SchemalessAttributes
40			*/
41			public function __get($key)
42			{
43			if (in_array($key, $this->getSchemalessAttributes())) {
44			return SchemalessAttributes::createForModel($this, $key);
45			}
46
47			return parent::__get($key);
48			}
49			}
50

spatie / laravel-schemaless-attributes

Pull Request — master (#64)

initializeSchemalessAttributesTrait() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like