SchemalessAttributes::scopeWithSchemalessAttributes() - Code Metrics - Inspection of "remove trait" - spatie/laravel-schemaless-attributes - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( da2acd...5ca54c )

by Freek

created 2018-05-09 14:39 UTC

scopeWithSchemalessAttributes() B

↳ Parent: SchemalessAttributes

Complexity

Conditions	5
Paths	16

Size

Total Lines	24
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	24
rs	8.5125
c	0
b	0
f	0
cc	5
eloc	13
nc	16
nop	1

<?php

namespace Spatie\SchemalessAttributes;

use Countable;
use ArrayAccess;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Model;

class SchemalessAttributes implements ArrayAccess, Countable
{
    /** @var \Illuminate\Database\Eloquent\Model */
    protected $model;

    /** @var string */
    protected $sourceAttributeName;

    /** @var array */
    protected $schemalessAttributes = [];

    public static function createForModel(Model $model, string $sourceAttributeName): self
    {
        return new static($model, $sourceAttributeName);
    }

    public function __construct(Model $model, string $sourceAttributeName)
    {
        $this->model = $model;

        $this->sourceAttributeName = $sourceAttributeName;

        $this->schemalessAttributes = $this->getRawSchemalessAttributes();
    }

    public function __get(string $name)
    {
        return $this->get($name);
    }

    public function get(string $name)
    {
        return array_get($this->schemalessAttributes, $name);
    }

    public function __set(string $name, $value)
    {
        $this->set($name, $value);
    }

    public function set(string $name, $value)
    {
        array_set($this->schemalessAttributes, $name, $value);

        $this->model->{$this->sourceAttributeName} = $this->schemalessAttributes;
    }

    public function forget(string $name): self
    {
        $this->model->{$this->sourceAttributeName} = array_except($this->schemalessAttributes, $name);

        return $this;
    }

    public function all(): array
    {
        return $this->getRawSchemalessAttributes();
    }

    protected function getRawSchemalessAttributes(): array
    {
        return json_decode($this->model->getAttributes()[$this->sourceAttributeName] ?? '{}', true);
    }

    public function offsetExists($offset)
    {
        return array_has($this->schemalessAttributes, $offset);
    }

    public function offsetGet($offset)
    {
        return $this->$offset;
    }

    public function offsetSet($offset, $value)
    {
        $this->{$offset} = $value;
    }

    public function offsetUnset($offset)
    {
        $this->forget($offset);
    }

    public function count()
    {
        return count($this->schemalessAttributes);
    }

    public static function scopeWithSchemalessAttributes(string $attributeName): Builder
    {
        $arguments = debug_backtrace()[1]['args'];

        if (count($arguments) === 1) {
            [$builder] = $arguments;

            $schemalessAttributes = [];
        }

        if (count($arguments) === 2) {
            [$builder, $schemalessAttributes] = $arguments;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }

        if (count($arguments) >= 3) {
            [$builder, $name, $value] = $arguments;
function someFunction() {
    $x = 5;
    echo $x;
}
            $schemalessAttributes = [$name => $value];
function someFunction() {
    $x = 5;
    echo $x;
}
        }

        foreach ($schemalessAttributes as $name => $value) {
            $builder->where("{$attributeName}->{$name}", $value);
        }

        return $builder;
    }
}


1			<?php
2
3			namespace Spatie\SchemalessAttributes;
4
5			use Countable;
6			use ArrayAccess;
7			use Illuminate\Database\Eloquent\Builder;
8			use Illuminate\Database\Eloquent\Model;
9
10			class SchemalessAttributes implements ArrayAccess, Countable
11			{
12			/** @var \Illuminate\Database\Eloquent\Model */
13			protected $model;
14
15			/** @var string */
16			protected $sourceAttributeName;
17
18			/** @var array */
19			protected $schemalessAttributes = [];
20
21			public static function createForModel(Model $model, string $sourceAttributeName): self
22			{
23			return new static($model, $sourceAttributeName);
24			}
25
26			public function __construct(Model $model, string $sourceAttributeName)
27			{
28			$this->model = $model;
29
30			$this->sourceAttributeName = $sourceAttributeName;
31
32			$this->schemalessAttributes = $this->getRawSchemalessAttributes();
33			}
34
35			public function __get(string $name)
36			{
37			return $this->get($name);
38			}
39
40			public function get(string $name)
41			{
42			return array_get($this->schemalessAttributes, $name);
43			}
44
45			public function __set(string $name, $value)
46			{
47			$this->set($name, $value);
48			}
49
50			public function set(string $name, $value)
51			{
52			array_set($this->schemalessAttributes, $name, $value);
53
54			$this->model->{$this->sourceAttributeName} = $this->schemalessAttributes;
55			}
56
57			public function forget(string $name): self
58			{
59			$this->model->{$this->sourceAttributeName} = array_except($this->schemalessAttributes, $name);
60
61			return $this;
62			}
63
64			public function all(): array
65			{
66			return $this->getRawSchemalessAttributes();
67			}
68
69			protected function getRawSchemalessAttributes(): array
70			{
71			return json_decode($this->model->getAttributes()[$this->sourceAttributeName] ?? '{}', true);
72			}
73
74			public function offsetExists($offset)
75			{
76			return array_has($this->schemalessAttributes, $offset);
77			}
78
79			public function offsetGet($offset)
80			{
81			return $this->$offset;
82			}
83
84			public function offsetSet($offset, $value)
85			{
86			$this->{$offset} = $value;
87			}
88
89			public function offsetUnset($offset)
90			{
91			$this->forget($offset);
92			}
93
94			public function count()
95			{
96			return count($this->schemalessAttributes);
97			}
98
99			public static function scopeWithSchemalessAttributes(string $attributeName): Builder
100			{
101			$arguments = debug_backtrace()[1]['args'];
102
103			if (count($arguments) === 1) {
104			[$builder] = $arguments;
			0 ignored issues – show Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$builder` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
105			$schemalessAttributes = [];
106			}
107
108			if (count($arguments) === 2) {
109			[$builder, $schemalessAttributes] = $arguments;
			0 ignored issues – show Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$schemalessAttributes` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
110			}
111
112			if (count($arguments) >= 3) {
113			[$builder, $name, $value] = $arguments;
			0 ignored issues – show Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$name` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history... Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$value` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
114			$schemalessAttributes = [$name => $value];
			0 ignored issues – show Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$name` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history... Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$value` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
115			}
116
117			foreach ($schemalessAttributes as $name => $value) {
118			$builder->where("{$attributeName}->{$name}", $value);
119			}
120
121			return $builder;
122			}
123			}
124

spatie / laravel-schemaless-attributes

Push — master ( da2acd...5ca54c )

scopeWithSchemalessAttributes() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like