HasSchemalessAttributes::scopeWithSchemalessAttributes() - Code Metrics - Inspection of "remove add method" - spatie/laravel-schemaless-attributes - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( de628b...da2acd )

by Freek

created 2018-05-09 08:44 UTC

scopeWithSchemalessAttributes() B

↳ Parent: HasSchemalessAttributes

Complexity

Conditions	5
Paths	16

Size

Total Lines	24
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	24
rs	8.5125
c	0
b	0
f	0
cc	5
eloc	13
nc	16
nop	0

<?php

namespace Spatie\SchemalessAttributes;

use Illuminate\Database\Eloquent\Builder;

trait HasSchemalessAttributes
{
    public function getSchemalessAttributesAttribute(): SchemalessAttributes
    {
        return SchemalessAttributes::createForModel($this, 'schemaless_attributes');
    }

    public function scopeWithSchemalessAttribute(): Builder
    {
        $arguments = func_get_args();

        unset($arguments[0]);

        return $this->withSchemalessAttributes(...$arguments);

    }

    public function scopeWithSchemalessAttributes(): Builder
    {
        $arguments = func_get_args();

        if (count($arguments) === 1) {
            [$builder] = $arguments;

            $schemalessAttributes = [];
        }

        if (count($arguments) === 2) {
            [$builder, $schemalessAttributes] = $arguments;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }

        if (count($arguments) >= 3) {
            [$builder, $name, $value] = $arguments;
function someFunction() {
    $x = 5;
    echo $x;
}
            $schemalessAttributes = [$name => $value];
function someFunction() {
    $x = 5;
    echo $x;
}
        }

        foreach ($schemalessAttributes as $name => $value) {
            $builder->where("schemaless_attributes->{$name}", $value);
        }

        return $builder;
    }
}


1			<?php
2
3			namespace Spatie\SchemalessAttributes;
4
5			use Illuminate\Database\Eloquent\Builder;
6
7			trait HasSchemalessAttributes
8			{
9			public function getSchemalessAttributesAttribute(): SchemalessAttributes
10			{
11			return SchemalessAttributes::createForModel($this, 'schemaless_attributes');
12			}
13
14			public function scopeWithSchemalessAttribute(): Builder
15			{
16			$arguments = func_get_args();
17
18			unset($arguments[0]);
19
20			return $this->withSchemalessAttributes(...$arguments);
			0 ignored issues – show Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The method `withSchemalessAttributes()` does not exist on `Spatie\SchemalessAttribu...HasSchemalessAttributes`. Did you maybe mean `scopeWithSchemalessAttributes()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
21			}
22
23			public function scopeWithSchemalessAttributes(): Builder
24			{
25			$arguments = func_get_args();
26
27			if (count($arguments) === 1) {
28			[$builder] = $arguments;
			0 ignored issues – show Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$builder` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
29			$schemalessAttributes = [];
30			}
31
32			if (count($arguments) === 2) {
33			[$builder, $schemalessAttributes] = $arguments;
			0 ignored issues – show Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$schemalessAttributes` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
34			}
35
36			if (count($arguments) >= 3) {
37			[$builder, $name, $value] = $arguments;
			0 ignored issues – show Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$name` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history... Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$value` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
38			$schemalessAttributes = [$name => $value];
			0 ignored issues – show Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$name` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history... Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$value` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
39			}
40
41			foreach ($schemalessAttributes as $name => $value) {
42			$builder->where("schemaless_attributes->{$name}", $value);
43			}
44
45			return $builder;
46			}
47			}
48

spatie / laravel-schemaless-attributes

Push — master ( de628b...da2acd )

scopeWithSchemalessAttributes() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like