SchemalessAttributes::all() - Code Metrics - Inspection of "extend collection" - spatie/laravel-schemaless-attributes - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#48)

by Tom

created 2019-08-21 14:43 UTC

SchemalessAttributes::all() A

↳ Parent: SchemalessAttributes

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace Spatie\SchemalessAttributes;

use Illuminate\Support\Arr;
use Illuminate\Support\Collection;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Builder;

class SchemalessAttributes extends Collection
{
    /** @var \Illuminate\Database\Eloquent\Model */
    protected $model;

    /** @var string */
    protected $sourceAttributeName;

    public static function createForModel(Model $model, string $sourceAttributeName): self
    {
        return new static($model, $sourceAttributeName);
    }

    public function __construct(Model $model, string $sourceAttributeName)
    {
        $this->model = $model;

        $this->sourceAttributeName = $sourceAttributeName;

        parent::__construct($this->getRawSchemalessAttributes());
    }

    public function __get($name)
    {
        return $this->get($name);
    }

    public function __set(string $name, $value)
    {
        $this->put($name, $value);
    }

    public function set($key, $value = null)
    {
        if (is_iterable($key)) {
            return $this->merge($key);
        }

        return $this->put($key, $value);
    }

    public function get($key, $default = null)
    {
        return data_get($this->items, $key, $default);
    }

    public function put($key, $value)
    {
        return $this->override(parent::put($key, $value));
    }

    public function merge($items)
    {
        return $this->override(array_merge($this->items, $this->getArrayableItems($items)));
    }

    public function forget($keys)
    {
        return $this->override(parent::forget($keys));
    }

    public function offsetGet($key)
    {
        return $this->get($key);
    }

    public function offsetSet($key, $value)
    {
        return $this->override(data_set($this->items, $key, $value));
    }

    public function offsetUnset($offset)
    {
        $this->override(Arr::except($this->items, $offset));
    }

    public static function scopeWithSchemalessAttributes(string $attributeName): Builder
    {
        $arguments = debug_backtrace()[1]['args'];

        if (count($arguments) === 1) {
            [$builder] = $arguments;

            $schemalessAttributes = [];
        }

        if (count($arguments) === 2) {
            [$builder, $schemalessAttributes] = $arguments;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }

        if (count($arguments) >= 3) {
            [$builder, $name, $value] = $arguments;
function someFunction() {
    $x = 5;
    echo $x;
}
            $schemalessAttributes = [$name => $value];
function someFunction() {
    $x = 5;
    echo $x;
}
        }

        foreach ($schemalessAttributes as $name => $value) {
            $builder->where("{$attributeName}->{$name}", $value);
        }

        return $builder;
    }

    protected function getRawSchemalessAttributes(): array
    {
        return $this->model->fromJson($this->model->getAttributes()[$this->sourceAttributeName] ?? '{}');
    }

    protected function override(iterable $collection)
    {
        $this->items = $this->getArrayableItems($collection);
        $this->model->{$this->sourceAttributeName} = $this->items;

        return $this;
    }
}


1			<?php
2
3			namespace Spatie\SchemalessAttributes;
4
5			use Illuminate\Support\Arr;
6			use Illuminate\Support\Collection;
7			use Illuminate\Database\Eloquent\Model;
8			use Illuminate\Database\Eloquent\Builder;
9
10			class SchemalessAttributes extends Collection
11			{
12			/** @var \Illuminate\Database\Eloquent\Model */
13			protected $model;
14
15			/** @var string */
16			protected $sourceAttributeName;
17
18			public static function createForModel(Model $model, string $sourceAttributeName): self
19			{
20			return new static($model, $sourceAttributeName);
21			}
22
23			public function __construct(Model $model, string $sourceAttributeName)
24			{
25			$this->model = $model;
26
27			$this->sourceAttributeName = $sourceAttributeName;
28
29			parent::__construct($this->getRawSchemalessAttributes());
30			}
31
32			public function __get($name)
33			{
34			return $this->get($name);
35			}
36
37			public function __set(string $name, $value)
38			{
39			$this->put($name, $value);
40			}
41
42			public function set($key, $value = null)
43			{
44			if (is_iterable($key)) {
45			return $this->merge($key);
46			}
47
48			return $this->put($key, $value);
49			}
50
51			public function get($key, $default = null)
52			{
53			return data_get($this->items, $key, $default);
54			}
55
56			public function put($key, $value)
57			{
58			return $this->override(parent::put($key, $value));
59			}
60
61			public function merge($items)
62			{
63			return $this->override(array_merge($this->items, $this->getArrayableItems($items)));
64			}
65
66			public function forget($keys)
67			{
68			return $this->override(parent::forget($keys));
69			}
70
71			public function offsetGet($key)
72			{
73			return $this->get($key);
74			}
75
76			public function offsetSet($key, $value)
77			{
78			return $this->override(data_set($this->items, $key, $value));
79			}
80
81			public function offsetUnset($offset)
82			{
83			$this->override(Arr::except($this->items, $offset));
84			}
85
86			public static function scopeWithSchemalessAttributes(string $attributeName): Builder
87			{
88			$arguments = debug_backtrace()[1]['args'];
89
90			if (count($arguments) === 1) {
91			[$builder] = $arguments;
			0 ignored issues – show Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$builder` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
92			$schemalessAttributes = [];
93			}
94
95			if (count($arguments) === 2) {
96			[$builder, $schemalessAttributes] = $arguments;
			0 ignored issues – show Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$schemalessAttributes` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
97			}
98
99			if (count($arguments) >= 3) {
100			[$builder, $name, $value] = $arguments;
			0 ignored issues – show Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$name` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history... Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$value` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
101			$schemalessAttributes = [$name => $value];
			0 ignored issues – show Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$name` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history... Bug introduced 2018-05-08 18:55 UTC by Report Bug Copy Issue Report The variable `$value` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
102			}
103
104			foreach ($schemalessAttributes as $name => $value) {
105			$builder->where("{$attributeName}->{$name}", $value);
106			}
107
108			return $builder;
109			}
110
111			protected function getRawSchemalessAttributes(): array
112			{
113			return $this->model->fromJson($this->model->getAttributes()[$this->sourceAttributeName] ?? '{}');
114			}
115
116			protected function override(iterable $collection)
117			{
118			$this->items = $this->getArrayableItems($collection);
119			$this->model->{$this->sourceAttributeName} = $this->items;
120
121			return $this;
122			}
123			}
124

spatie / laravel-schemaless-attributes

Pull Request — master (#48)

SchemalessAttributes::all() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like