Spatie\LaravelEndpointResources\HasEndpoints

Complexity

Total Complexity

10

Size/Duplication

Total Lines	90
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	endpoints()	0	8	1
A	collectionEndpoints()	0	8	1
A	collection()	0	12	2
A	make()	0	12	2
A	meta()	0	4	1
A	initializeEndpointResource()	0	19	3

<?php

namespace Spatie\LaravelEndpointResources;

use Closure;
use Illuminate\Support\Arr;

/** @mixin \Illuminate\Http\Resources\Json\JsonResource */
trait HasEndpoints
{
    /**
     * @param string|Closure|null $controller
     * @param null $parameters
     *
     * @return \Spatie\LaravelEndpointResources\EndpointResource
     */
    public function endpoints($controller = null, $parameters = null): EndpointResource
    {
        return self::initializeEndpointResource(
            $endPointResource = new EndpointResource($this->resource, EndpointResourceType::ITEM),

The property resource does not exist. Did you maybe forget to declare it?

            $controller,
            $parameters
        );
    }

    /**
     * @param string|Closure|null $controller
     * @param null $parameters
     *
     * @return \Spatie\LaravelEndpointResources\EndpointResource
     */
    public static function collectionEndpoints($controller = null, $parameters = null): EndpointResource
    {
        return self::initializeEndpointResource(
            $endPointResource = new EndpointResource(null, EndpointResourceType::COLLECTION),
            $controller,
            $parameters
        );
    }

    public static function collection($resource)
    {
        $meta = self::meta();

        if (! count($meta)) {
            parent::collection($resource);
        }

        return parent::collection($resource)->additional([
            'meta' => $meta,
        ]);
    }

    public static function make(...$parameters)
    {
        $meta = self::meta();

        if (! count($meta)) {
            parent::make(...$parameters);
        }

        return parent::make(...$parameters)->additional([
            'meta' => $meta,
        ]);
    }

    public static function meta()
    {
        return [];
    }

    /**
     * @param \Spatie\LaravelEndpointResources\EndpointResource|null $endpointResource
     * @param string|Closure|null $controller
     * @param null $parameters
     *
     * @return \Spatie\LaravelEndpointResources\EndpointResource
     */
    private static function initializeEndpointResource(
        ?EndpointResource $endpointResource,
        $controller = null,
        $parameters = null
    ): EndpointResource {
        if ($controller instanceof Closure) {
            $endpointsCollection = new EndpointsCollection();

            $controller($endpointsCollection);

            return $endpointResource->addEndpointsCollection($endpointsCollection);

It seems like $endpointResource is not always an object, but can also be of type null. Maybe add an additional type check?

        }

        if ($controller !== null) {
            return $endpointResource->addController($controller, Arr::wrap($parameters));
        }

        return $endpointResource;
    }
}