HasEndpoints - Code Metrics - Inspection of "First refactor" - spatie/laravel-resource-links - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b01d16...d9d1e2 )

by Ruben

created 2019-09-18 14:46 UTC

HasEndpoints A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	1
dl	0
loc	30
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	endpoints()	0	10	3
A	collectionEndpoints()	0	4	1

<?php

namespace Spatie\ResourceLinks;

use Closure;

/** @mixin \Illuminate\Http\Resources\Json\JsonResource */
trait HasEndpoints
{
    /**
     * @param string|Closure|null|array $controller
     * @param null $parameters
     *
     * @return \Spatie\ResourceLinks\LinkResource
     */
    public function endpoints($controller = null, $parameters = null): LinkResource
    {
        $resource = LinkResource::create($this->resource, LinkResourceType::ITEM)->endpoint($controller, $parameters);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        if (property_exists($this, 'mergeCollectionEndpoints') && $this->mergeCollectionEndpoints === true) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $resource->mergeCollectionEndpoints();
        }

        return $resource;
    }

    /**
     * @param string|Closure|null|array $controller
     * @param null $parameters
     *
     * @return \Spatie\ResourceLinks\LinkResource
     */
    public static function collectionEndpoints($controller = null, $parameters = null): LinkResource
    {
        return LinkResource::create(null, LinkResourceType::COLLECTION)->endpoint($controller, $parameters);
    }
}


1			<?php
2
3			namespace Spatie\ResourceLinks;
4
5			use Closure;
6
7			/** @mixin \Illuminate\Http\Resources\Json\JsonResource */
8			trait HasEndpoints
9			{
10			/**
11			* @param string\|Closure\|null\|array $controller
12			* @param null $parameters
13			*
14			* @return \Spatie\ResourceLinks\LinkResource
15			*/
16			public function endpoints($controller = null, $parameters = null): LinkResource
17			{
18			$resource = LinkResource::create($this->resource, LinkResourceType::ITEM)->endpoint($controller, $parameters);
			0 ignored issues – show Bug introduced 2019-07-12 13:55 UTC by Report Bug Copy Issue Report The property `resource` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19
20			if (property_exists($this, 'mergeCollectionEndpoints') && $this->mergeCollectionEndpoints === true) {
			0 ignored issues – show Bug introduced 2019-08-22 12:26 UTC by Report Bug Copy Issue Report The property `mergeCollectionEndpoints` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
21			$resource->mergeCollectionEndpoints();
22			}
23
24			return $resource;
25			}
26
27			/**
28			* @param string\|Closure\|null\|array $controller
29			* @param null $parameters
30			*
31			* @return \Spatie\ResourceLinks\LinkResource
32			*/
33			public static function collectionEndpoints($controller = null, $parameters = null): LinkResource
34			{
35			return LinkResource::create(null, LinkResourceType::COLLECTION)->endpoint($controller, $parameters);
36			}
37			}
38

spatie / laravel-resource-links

Push — master ( b01d16...d9d1e2 )

HasEndpoints A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like