RequestHeader::getReferer() - Code Metrics - spatie/laravel-referer - Measure and Improve Code Quality continuously with Scrutinizer

RequestHeader::getReferer() A
last analyzed 2020-07-13 21:55 UTC

↳ Parent: RequestHeader

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
nc	4
nop	1
dl	0
loc	20
rs	9.6
c	0
b	0
f	0

<?php

namespace Spatie\Referer\Sources;

use Illuminate\Http\Request;
use Spatie\Referer\Helpers\Url;
use Spatie\Referer\Source;

class RequestHeader implements Source
{
    public function getReferer(Request $request): string
    {
        $referer = $request->header('referer', '');

        if (empty($referer)) {
            return '';
        }

        $refererHost = Url::host($referer);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        if (empty($refererHost)) {
            return '';
        }

        if ($refererHost === $request->getHost()) {
            return '';
        }

        return $refererHost;
    }
}


1			<?php
2
3			namespace Spatie\Referer\Sources;
4
5			use Illuminate\Http\Request;
6			use Spatie\Referer\Helpers\Url;
7			use Spatie\Referer\Source;
8
9			class RequestHeader implements Source
10			{
11			public function getReferer(Request $request): string
12			{
13			$referer = $request->header('referer', '');
14
15			if (empty($referer)) {
16			return '';
17			}
18
19			$refererHost = Url::host($referer);
			0 ignored issues – show Bug introduced 2017-02-08 08:55 UTC by Report Bug Copy Issue Report It seems like `$referer` defined by `$request->header('referer', '')` on line `13` can also be of type `array`; however, `Spatie\Referer\Helpers\Url::host()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
20
21			if (empty($refererHost)) {
22			return '';
23			}
24
25			if ($refererHost === $request->getHost()) {
26			return '';
27			}
28
29			return $refererHost;
30			}
31			}
32

spatie / laravel-referer

RequestHeader::getReferer() A last analyzed 2020-07-13 21:55 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

RequestHeader::getReferer() A
last analyzed 2020-07-13 21:55 UTC