InvalidIncludeQuery::__construct() - Code Metrics - Inspection of "Add specific exceptions for every invalid query" - spatie/laravel-query-builder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#18)

unknown

created 2018-01-30 11:21 UTC

InvalidIncludeQuery::__construct() A

↳ Parent: InvalidIncludeQuery

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	2

<?php

namespace Spatie\QueryBuilder\Exceptions;

use Illuminate\Http\Response;
use Illuminate\Support\Collection;

class InvalidIncludeQuery extends InvalidQuery
{
    /** @var \Illuminate\Support\Collection */
    private $unknownIncludes;

    /** @var \Illuminate\Support\Collection */
    private $allowedIncludes;

    public function __construct(Collection $unknownIncludes, Collection $allowedIncludes)
    {
        $this->unknownIncludes = $unknownIncludes;
        $this->allowedIncludes = $allowedIncludes;

        $unknownIncludes = $unknownIncludes->implode(', ');
        $allowedIncludes = $allowedIncludes->implode(', ');
        $message = "Given include(s) `{$unknownIncludes}` are not allowed. Allowed includes are `{$allowedIncludes}`.";

        parent::__construct(Response::HTTP_BAD_REQUEST, $message);
    }

    public static function includesNotAllowed(Collection $unknownIncludes, Collection $allowedIncludes)

    {
        return new static(...func_get_args());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function getUnknownIncludes(): Collection
    {
        return $this->unknownIncludes;
    }

    public function getAllowedIncludes(): Collection
    {
        return $this->allowedIncludes;
    }
}


1			<?php
2
3			namespace Spatie\QueryBuilder\Exceptions;
4
5			use Illuminate\Http\Response;
6			use Illuminate\Support\Collection;
7
8			class InvalidIncludeQuery extends InvalidQuery
9			{
10			/** @var \Illuminate\Support\Collection */
11			private $unknownIncludes;
12
13			/** @var \Illuminate\Support\Collection */
14			private $allowedIncludes;
15
16			public function __construct(Collection $unknownIncludes, Collection $allowedIncludes)
17			{
18			$this->unknownIncludes = $unknownIncludes;
19			$this->allowedIncludes = $allowedIncludes;
20
21			$unknownIncludes = $unknownIncludes->implode(', ');
22			$allowedIncludes = $allowedIncludes->implode(', ');
23			$message = "Given include(s) `{$unknownIncludes}` are not allowed. Allowed includes are `{$allowedIncludes}`.";
24
25			parent::__construct(Response::HTTP_BAD_REQUEST, $message);
26			}
27
28			public static function includesNotAllowed(Collection $unknownIncludes, Collection $allowedIncludes)
			0 ignored issues – show Unused Code introduced 2018-01-30 11:26 UTC by Report Bug Copy Issue Report The parameter `$unknownIncludes` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2018-01-30 11:26 UTC by Report Bug Copy Issue Report The parameter `$allowedIncludes` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
29			{
30			return new static(...func_get_args());
			0 ignored issues – show Bug introduced 2018-01-30 11:26 UTC by Report Bug Copy Issue Report The call to `InvalidIncludeQuery::__construct()` misses a required argument `$allowedIncludes`. This check looks for function calls that miss required arguments. Loading history... Documentation introduced 2018-01-30 11:26 UTC by Report Bug Copy Issue Report `func_get_args()` is of type `array`, but the function expects a `object<Illuminate\Support\Collection>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
31			}
32
33			public function getUnknownIncludes(): Collection
34			{
35			return $this->unknownIncludes;
36			}
37
38			public function getAllowedIncludes(): Collection
39			{
40			return $this->allowedIncludes;
41			}
42			}
43

spatie / laravel-query-builder

Pull Request — master (#18)

InvalidIncludeQuery::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like