Completed
Pull Request — master (#18)
by
unknown
04:30
created

InvalidFilterQuery::getAllowedFilters()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 4
rs 10
c 0
b 0
f 0
cc 1
eloc 2
nc 1
nop 0
1
<?php
2
3
namespace Spatie\QueryBuilder\Exceptions;
4
5
use Illuminate\Http\Response;
6
use Illuminate\Support\Collection;
7
8
class InvalidFilterQuery extends InvalidQuery
9
{
10
    /** @var \Illuminate\Support\Collection */
11
    private $unknownFilters;
12
13
    /** @var \Illuminate\Support\Collection */
14
    private $allowedFilters;
15
16
    public function __construct(Collection $unknownFilters, Collection $allowedFilters)
17
    {
18
        $this->unknownFilters = $unknownFilters;
19
        $this->allowedFilters = $allowedFilters;
20
21
        $unknownFilters = $this->unknownFilters->implode(', ');
22
        $allowedFilters = $this->allowedFilters->implode(', ');
23
        $message = "Given filter(s) `{$unknownFilters}` are not allowed. Allowed filters are `{$allowedFilters}`.";
24
25
        parent::__construct(Response::HTTP_BAD_REQUEST, $message);
26
    }
27
28
    public static function filtersNotAllowed(Collection $unknownFilters, Collection $allowedFilters)
0 ignored issues
show
Unused Code introduced by
The parameter $unknownFilters is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
Unused Code introduced by
The parameter $allowedFilters is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
29
    {
30
        return new static(...func_get_args());
0 ignored issues
show
Bug introduced by
The call to InvalidFilterQuery::__construct() misses a required argument $allowedFilters.

This check looks for function calls that miss required arguments.

Loading history...
Documentation introduced by
func_get_args() is of type array, but the function expects a object<Illuminate\Support\Collection>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
31
    }
32
33
    public function getUnknownFilters(): Collection
34
    {
35
        return $this->unknownFilters;
36
    }
37
38
    public function getAllowedFilters(): Collection
39
    {
40
        return $this->allowedFilters;
41
    }
42
}
43