Issues in FiltersExact.php - All Issues - Inspection of "Add method to disable throwing exceptions for inva..." - spatie/laravel-query-builder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 187043...48cde4 )

unknown

created 2020-01-22 14:33 UTC

src/Filters/FiltersExact.php (1 issue)

Showing only issues like (Show All)

suspicious assignments to closure imports.

Bug Minor

jl9404 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Spatie\QueryBuilder\Filters;

use Illuminate\Database\Eloquent\Builder;
use Illuminate\Support\Collection;
use Illuminate\Support\Str;

class FiltersExact implements Filter
{
    protected $relationConstraints = [];

    /** @var bool */
    protected $addRelationConstraint = true;

    public function __construct(bool $addRelationConstraint = true)
    {
        $this->addRelationConstraint = $addRelationConstraint;
    }

    public function __invoke(Builder $query, $value, string $property)
    {
        if ($this->addRelationConstraint) {
            if ($this->isRelationProperty($query, $property)) {
                $this->withRelationConstraint($query, $value, $property);

                return;
            }
        }

        if (is_array($value)) {
            $query->whereIn($property, $value);

            return;
        }

        $query->where($property, '=', $value);
    }

    protected function isRelationProperty(Builder $query, string $property): bool
    {
        if (! Str::contains($property, '.')) {
            return false;
        }

        if (in_array($property, $this->relationConstraints)) {
            return false;
        }

        if (Str::startsWith($property, $query->getModel()->getTable().'.')) {
            return false;
        }

        return true;
    }

    protected function withRelationConstraint(Builder $query, $value, string $property)
    {
        [$relation, $property] = collect(explode('.', $property))
            ->pipe(function (Collection $parts) {
                return [
                    $parts->except(count($parts) - 1)->map([Str::class, 'camel'])->implode('.'),
                    $parts->last(),
                ];
            });

        $query->whereHas($relation, function (Builder $query) use ($value, $relation, $property) {
            $this->relationConstraints[] = $property = $query->getModel()->getTable().'.'.$property;
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)

            $this->__invoke($query, $value, $property);
        });
    }
}


1			<?php
2
3			namespace Spatie\QueryBuilder\Filters;
4
5			use Illuminate\Database\Eloquent\Builder;
6			use Illuminate\Support\Collection;
7			use Illuminate\Support\Str;
8
9			class FiltersExact implements Filter
10			{
11			protected $relationConstraints = [];
12
13			/** @var bool */
14			protected $addRelationConstraint = true;
15
16			public function __construct(bool $addRelationConstraint = true)
17			{
18			$this->addRelationConstraint = $addRelationConstraint;
19			}
20
21			public function __invoke(Builder $query, $value, string $property)
22			{
23			if ($this->addRelationConstraint) {
24			if ($this->isRelationProperty($query, $property)) {
25			$this->withRelationConstraint($query, $value, $property);
26
27			return;
28			}
29			}
30
31			if (is_array($value)) {
32			$query->whereIn($property, $value);
33
34			return;
35			}
36
37			$query->where($property, '=', $value);
38			}
39
40			protected function isRelationProperty(Builder $query, string $property): bool
41			{
42			if (! Str::contains($property, '.')) {
43			return false;
44			}
45
46			if (in_array($property, $this->relationConstraints)) {
47			return false;
48			}
49
50			if (Str::startsWith($property, $query->getModel()->getTable().'.')) {
51			return false;
52			}
53
54			return true;
55			}
56
57			protected function withRelationConstraint(Builder $query, $value, string $property)
58			{
59			[$relation, $property] = collect(explode('.', $property))
60			->pipe(function (Collection $parts) {
61			return [
62			$parts->except(count($parts) - 1)->map([Str::class, 'camel'])->implode('.'),
63			$parts->last(),
64			];
65			});
66
67			$query->whereHas($relation, function (Builder $query) use ($value, $relation, $property) {
68			$this->relationConstraints[] = $property = $query->getModel()->getTable().'.'.$property;
			0 ignored issues – show Bug introduced 2018-10-26 21:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different name than the imported variable `$property`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
69
70			$this->__invoke($query, $value, $property);
71			});
72			}
73			}
74

spatie / laravel-query-builder

Push — master ( 187043...48cde4 )

src/Filters/FiltersExact.php (1 issue)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like