InvalidFieldQuery::__construct() - Code Metrics - Inspection of "Add method to disable throwing exceptions for inva..." - spatie/laravel-query-builder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 187043...48cde4 )

unknown

created 2020-01-22 14:33 UTC

InvalidFieldQuery::__construct() A

↳ Parent: InvalidFieldQuery

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	11
Ratio	100 %

Importance

Changes

Metric	Value
dl	11
loc	11
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

namespace Spatie\QueryBuilder\Exceptions;

use Illuminate\Http\Response;
use Illuminate\Support\Collection;

class InvalidFieldQuery extends InvalidQuery

{
    /** @var \Illuminate\Support\Collection */
    public $unknownFields;

    /** @var \Illuminate\Support\Collection */
    public $allowedFields;

    public function __construct(Collection $unknownFields, Collection $allowedFields)
    {
        $this->unknownFields = $unknownFields;
        $this->allowedFields = $allowedFields;

        $unknownFields = $unknownFields->implode(', ');
        $allowedFields = $allowedFields->implode(', ');
        $message = "Requested field(s) `{$unknownFields}` are not allowed. Allowed field(s) are `{$allowedFields}`.";

        parent::__construct(Response::HTTP_BAD_REQUEST, $message);
    }

    public static function fieldsNotAllowed(Collection $unknownFields, Collection $allowedFields)

    {
        return new static(...func_get_args());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1		<?php
2
3		namespace Spatie\QueryBuilder\Exceptions;
4
5		use Illuminate\Http\Response;
6		use Illuminate\Support\Collection;
7
8	View Code Duplication	class InvalidFieldQuery extends InvalidQuery
		0 ignored issues – show Duplication introduced 2018-10-01 16:55 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9		{
10		/** @var \Illuminate\Support\Collection */
11		public $unknownFields;
12
13		/** @var \Illuminate\Support\Collection */
14		public $allowedFields;
15
16		public function __construct(Collection $unknownFields, Collection $allowedFields)
17		{
18		$this->unknownFields = $unknownFields;
19		$this->allowedFields = $allowedFields;
20
21		$unknownFields = $unknownFields->implode(', ');
22		$allowedFields = $allowedFields->implode(', ');
23		$message = "Requested field(s) `{$unknownFields}` are not allowed. Allowed field(s) are `{$allowedFields}`.";
24
25		parent::__construct(Response::HTTP_BAD_REQUEST, $message);
26		}
27
28		public static function fieldsNotAllowed(Collection $unknownFields, Collection $allowedFields)
		0 ignored issues – show Unused Code introduced 2018-10-01 16:55 UTC by Report Bug Copy Issue Report The parameter `$unknownFields` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2018-10-01 16:55 UTC by Report Bug Copy Issue Report The parameter `$allowedFields` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
29		{
30		return new static(...func_get_args());
		0 ignored issues – show Bug introduced 2018-10-02 15:56 UTC by Report Bug Copy Issue Report The call to `InvalidFieldQuery::__construct()` misses a required argument `$allowedFields`. This check looks for function calls that miss required arguments. Loading history... Documentation introduced 2018-10-01 16:55 UTC by Report Bug Copy Issue Report `func_get_args()` is of type `array`, but the function expects a `object<Illuminate\Support\Collection>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
31		}
32		}
33

spatie / laravel-query-builder

Push — master ( 187043...48cde4 )

InvalidFieldQuery::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like