InvalidFilterQuery::__construct() - Code Metrics - spatie/laravel-query-builder - Measure and Improve Code Quality continuously with Scrutinizer

InvalidFilterQuery::__construct() A
last analyzed 2020-05-27 13:47 UTC

↳ Parent: InvalidFilterQuery

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

namespace Spatie\QueryBuilder\Exceptions;

use Illuminate\Http\Response;
use Illuminate\Support\Collection;

class InvalidFilterQuery extends InvalidQuery
{
    /** @var \Illuminate\Support\Collection */
    public $unknownFilters;

    /** @var \Illuminate\Support\Collection */
    public $allowedFilters;

    public function __construct(Collection $unknownFilters, Collection $allowedFilters)
    {
        $this->unknownFilters = $unknownFilters;
        $this->allowedFilters = $allowedFilters;

        $unknownFilters = $this->unknownFilters->implode(', ');
        $allowedFilters = $this->allowedFilters->implode(', ');
        $message = "Requested filter(s) `{$unknownFilters}` are not allowed. Allowed filter(s) are `{$allowedFilters}`.";

        parent::__construct(Response::HTTP_BAD_REQUEST, $message);
    }

    public static function filtersNotAllowed(Collection $unknownFilters, Collection $allowedFilters)

    {
        return new static(...func_get_args());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			namespace Spatie\QueryBuilder\Exceptions;
4
5			use Illuminate\Http\Response;
6			use Illuminate\Support\Collection;
7
8			class InvalidFilterQuery extends InvalidQuery
9			{
10			/** @var \Illuminate\Support\Collection */
11			public $unknownFilters;
12
13			/** @var \Illuminate\Support\Collection */
14			public $allowedFilters;
15
16			public function __construct(Collection $unknownFilters, Collection $allowedFilters)
17			{
18			$this->unknownFilters = $unknownFilters;
19			$this->allowedFilters = $allowedFilters;
20
21			$unknownFilters = $this->unknownFilters->implode(', ');
22			$allowedFilters = $this->allowedFilters->implode(', ');
23			$message = "Requested filter(s) `{$unknownFilters}` are not allowed. Allowed filter(s) are `{$allowedFilters}`.";
24
25			parent::__construct(Response::HTTP_BAD_REQUEST, $message);
26			}
27
28			public static function filtersNotAllowed(Collection $unknownFilters, Collection $allowedFilters)
			0 ignored issues – show Unused Code introduced 2018-01-30 11:26 UTC by Report Bug Copy Issue Report The parameter `$unknownFilters` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2018-01-30 11:26 UTC by Report Bug Copy Issue Report The parameter `$allowedFilters` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
29			{
30			return new static(...func_get_args());
			0 ignored issues – show Bug introduced 2018-01-30 11:26 UTC by Report Bug Copy Issue Report The call to `InvalidFilterQuery::__construct()` misses a required argument `$allowedFilters`. This check looks for function calls that miss required arguments. Loading history... Documentation introduced 2018-01-30 11:26 UTC by Report Bug Copy Issue Report `func_get_args()` is of type `array`, but the function expects a `object<Illuminate\Support\Collection>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
31			}
32			}
33

spatie / laravel-query-builder

InvalidFilterQuery::__construct() A last analyzed 2020-05-27 13:47 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

InvalidFilterQuery::__construct() A
last analyzed 2020-05-27 13:47 UTC