Spatie\PersonalDataExport\Zip

Complexity

Total Complexity

10

Size/Duplication

Total Lines	87
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	createForPersonalData()	0	18	1
A	__construct()	0	8	1
A	path()	0	4	1
A	size()	0	8	2
A	open()	0	6	1
A	add()	0	13	3
A	close()	0	6	1

<?php

namespace Spatie\PersonalDataExport;

use Illuminate\Support\Str;
use Spatie\TemporaryDirectory\TemporaryDirectory;
use ZipArchive;

class Zip
{
    /** @var \ZipArchive */
    protected $zipFile;

    /** @var int */
    protected $fileCount = 0;

    /** @var string */
    protected $pathToZip;

    public static function createForPersonalData(
        PersonalDataSelection $personalDataSelection,
        TemporaryDirectory $temporaryDirectory): self
    {
        $zipFilenameParts = [
            $personalDataSelection->user->getKey(),
            now()->timestamp,
            Str::random(64),
        ];

        $zipFilename = implode('_', $zipFilenameParts).'.zip';

        $pathToZip = $temporaryDirectory->path($zipFilename);

        return (new static($pathToZip))
            ->add($personalDataSelection->files(), $temporaryDirectory->path())
            ->close();
    }

    public function __construct(string $pathToZip)
    {
        $this->zipFile = new ZipArchive();

        $this->pathToZip = $pathToZip;

        $this->open();
    }

    public function path(): string
    {
        return $this->pathToZip;
    }

    public function size(): int
    {
        if ($this->fileCount === 0) {
            return 0;
        }

        return filesize($this->pathToZip);
    }

    public function open(): self
    {
        $this->zipFile->open($this->pathToZip, ZipArchive::CREATE);

        return $this;
    }

    /**
     * @param string|array $files
     * @param string $rootPath
     *
     * @return \Spatie\PersonalDataExport\Zip
     */
    public function add($files, $rootPath): self
    {
        foreach ($files as $file) {

The expression $files of type string|array is not guaranteed to be traversable. How about adding an additional type check?

            if (file_exists($file)) {
                $nameInZip = Str::after($file, $rootPath.'/');

                $this->zipFile->addFile($file, ltrim($nameInZip, DIRECTORY_SEPARATOR));
            }
            $this->fileCount++;
        }

        return $this;
    }

    public function close(): self
    {
        $this->zipFile->close();

        return $this;
    }
}