Spatie\PersonalDataExport\Jobs\CreatePersonalDataExportJob

Complexity

Total Complexity

8

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	15

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	1
A	handle()	0	16	1
A	selectPersonalData()	0	8	1
A	zipPersonalData()	0	13	1
A	getDisk()	0	4	1
A	mailZip()	0	6	1
A	ensureValidUser()	0	6	2

<?php

namespace Spatie\PersonalDataExport\Jobs;

use Illuminate\Bus\Queueable;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;
use Illuminate\Contracts\Filesystem\Filesystem;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Support\Facades\Mail;
use Illuminate\Support\Facades\Storage;
use Spatie\PersonalDataExport\Events\PersonalDataExportCreated;
use Spatie\PersonalDataExport\Events\PersonalDataSelected;
use Spatie\PersonalDataExport\Exceptions\InvalidUser;
use Spatie\PersonalDataExport\ExportsPersonalData;
use Spatie\PersonalDataExport\PersonalDataSelection;
use Spatie\PersonalDataExport\Zip;
use Spatie\TemporaryDirectory\TemporaryDirectory;

class CreatePersonalDataExportJob implements ShouldQueue
{
    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;

    /** @var \Spatie\PersonalDataExport\ExportsPersonalData */
    protected $user;

    public function __construct(ExportsPersonalData $user)
    {
        $this->ensureValidUser($user);

        $this->user = $user;

        $this->queue = config('personal-data-export.job.queue');
        
        $this->connection = config('personal-data-export.job.connection');
    }

    public function handle()
    {
        $temporaryDirectory = (new TemporaryDirectory())->create();

        $personalDataSelection = $this->selectPersonalData($temporaryDirectory);

        event(new PersonalDataSelected($personalDataSelection, $this->user));

        $zipFilename = $this->zipPersonalData($personalDataSelection, $this->getDisk(), $temporaryDirectory);

        $temporaryDirectory->delete();

        event(new PersonalDataExportCreated($zipFilename, $this->user));

        $this->mailZip($zipFilename);
    }

    protected function selectPersonalData(TemporaryDirectory $temporaryDirectory): PersonalDataSelection
    {
        $personalData = (new PersonalDataSelection($temporaryDirectory))->forUser($this->user);

        $this->user->selectPersonalData($personalData);

        return $personalData;
    }

    protected function zipPersonalData(
        PersonalDataSelection $personalData,
        Filesystem $filesystem,
        TemporaryDirectory $temporaryDirectory
    ): string {
        $zip = Zip::createForPersonalData($personalData, $temporaryDirectory);

        $zipFilename = pathinfo($zip->path(), PATHINFO_BASENAME);

        $filesystem->writeStream($zipFilename, fopen($zip->path(), 'r'));

        return $zipFilename;
    }

    public function getDisk(): Filesystem
    {
        return Storage::disk(config('personal-data-export.disk'));
    }

    protected function mailZip(string $zipFilename)
    {
        $mailableClass = config('personal-data-export.mailable');

        Mail::to($this->user)->send(new $mailableClass($zipFilename));
    }

    protected function ensureValidUser(ExportsPersonalData $user)
    {
        if (is_null($user->email ?? null)) {

Accessing email on the interface Spatie\PersonalDataExport\ExportsPersonalData suggest that you code against a concrete implementation. How about adding an instanceof check?

            throw InvalidUser::doesNotHaveAnEmailProperty($user);
        }
    }
}