PermissionServiceProvider::convertPipeToArray() - Code Metrics - Inspection of "Add command's; add_role & add_permission (#372)" - spatie/laravel-permission - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ebc159...dcba67 )

by Freek

created 2017-07-25 18:48 UTC

PermissionServiceProvider::convertPipeToArray() B

↳ Parent: PermissionServiceProvider

Complexity

Conditions	4
Paths	4

Size

Total Lines	24
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	12
nc	4
nop	1
dl	0
loc	24
rs	8.6845
c	0
b	0
f	0

<?php

namespace Spatie\Permission;

use Illuminate\Support\ServiceProvider;
use Illuminate\View\Compilers\BladeCompiler;
use Spatie\Permission\Contracts\Role as RoleContract;
use Spatie\Permission\Contracts\Permission as PermissionContract;

class PermissionServiceProvider extends ServiceProvider
{
    public function boot(PermissionRegistrar $permissionLoader)
    {
        $this->publishes([
            __DIR__.'/../config/permission.php' => $this->app->configPath().'/permission.php',
        ], 'config');

        if (! class_exists('CreatePermissionTables')) {
            $timestamp = date('Y_m_d_His', time());

            $this->publishes([
                __DIR__.'/../database/migrations/create_permission_tables.php.stub' => $this->app->databasePath()."/migrations/{$timestamp}_create_permission_tables.php",

            ], 'migrations');
        }

        if ($this->app->runningInConsole()) {
            $this->commands([
                Commands\CreateRole::class,
                Commands\CreatePermission::class,
            ]);
        }

        $this->registerModelBindings();

        $permissionLoader->registerPermissions();
    }

    public function register()
    {
        $this->mergeConfigFrom(
            __DIR__.'/../config/permission.php',
            'permission'
        );

        $this->registerBladeExtensions();
    }

    protected function registerModelBindings()
    {
        $config = $this->app->config['permission.models'];
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $this->app->bind(PermissionContract::class, $config['permission']);
        $this->app->bind(RoleContract::class, $config['role']);
    }

    protected function registerBladeExtensions()
    {
        $this->app->afterResolving('blade.compiler', function (BladeCompiler $bladeCompiler) {
            $bladeCompiler->directive('role', function ($arguments) {

                list($role, $guard) = explode(',', $arguments.',');

                return "<?php if(auth({$guard})->check() && auth({$guard})->user()->hasRole({$role})): ?>";
            });
            $bladeCompiler->directive('endrole', function () {
                return '<?php endif; ?>';
            });

            $bladeCompiler->directive('hasrole', function ($arguments) {

                list($role, $guard) = explode(',', $arguments.',');

                return "<?php if(auth({$guard})->check() && auth({$guard})->user()->hasRole({$role})): ?>";
            });
            $bladeCompiler->directive('endhasrole', function () {
                return '<?php endif; ?>';
            });

            $bladeCompiler->directive('hasanyrole', function ($arguments) {

                list($roles, $guard) = explode(',', $arguments.',');
                $roles = $this->convertPipeToArray($roles);

                return "<?php if(auth({$guard})->check() && auth({$guard})->user()->hasAnyRole({$roles})): ?>";
            });
            $bladeCompiler->directive('endhasanyrole', function () {
                return '<?php endif; ?>';
            });

            $bladeCompiler->directive('hasallroles', function ($arguments) {

                list($roles, $guard) = explode(',', $arguments.',');
                $roles = $this->convertPipeToArray($roles);

                return "<?php if(auth({$guard})->check() && auth({$guard})->user()->hasAllRoles({$roles})): ?>";
            });
            $bladeCompiler->directive('endhasallroles', function () {
                return '<?php endif; ?>';
            });
        });
    }

    public function convertPipeToArray(string $pipeString)
    {
        $pipeString = trim($pipeString);

        if (strlen($pipeString) <= 2) {
            return $pipeString;
        }

        $quoteCharacter = substr($pipeString, 0, 1);

        if (! in_array($quoteCharacter, ["'", '"'])) {
            return $pipeString;
        }

        $endCharacter = substr($quoteCharacter, -1, 1);

        if ($quoteCharacter !== $endCharacter) {
            return $pipeString;
        }

        $roleString = '['.implode($quoteCharacter.','.$quoteCharacter, explode('|', $pipeString)).']';

        return $roleString;
    }
}


1		<?php
2
3		namespace Spatie\Permission;
4
5		use Illuminate\Support\ServiceProvider;
6		use Illuminate\View\Compilers\BladeCompiler;
7		use Spatie\Permission\Contracts\Role as RoleContract;
8		use Spatie\Permission\Contracts\Permission as PermissionContract;
9
10		class PermissionServiceProvider extends ServiceProvider
11		{
12		public function boot(PermissionRegistrar $permissionLoader)
13		{
14		$this->publishes([
15		__DIR__.'/../config/permission.php' => $this->app->configPath().'/permission.php',
16		], 'config');
17
18		if (! class_exists('CreatePermissionTables')) {
19		$timestamp = date('Y_m_d_His', time());
20
21		$this->publishes([
22		__DIR__.'/../database/migrations/create_permission_tables.php.stub' => $this->app->databasePath()."/migrations/{$timestamp}_create_permission_tables.php",
		0 ignored issues – show Bug introduced 2015-12-21 23:32 UTC by Report Bug Copy Issue Report The method `databasePath()` does not exist on `Illuminate\Contracts\Foundation\Application`. Did you maybe mean `basePath()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
23		], 'migrations');
24		}
25
26		if ($this->app->runningInConsole()) {
27		$this->commands([
28		Commands\CreateRole::class,
29		Commands\CreatePermission::class,
30		]);
31		}
32
33		$this->registerModelBindings();
34
35		$permissionLoader->registerPermissions();
36		}
37
38		public function register()
39		{
40		$this->mergeConfigFrom(
41		__DIR__.'/../config/permission.php',
42		'permission'
43		);
44
45		$this->registerBladeExtensions();
46		}
47
48		protected function registerModelBindings()
49		{
50		$config = $this->app->config['permission.models'];
		0 ignored issues – show Bug introduced 2017-06-11 00:59 UTC by Report Bug Copy Issue Report Accessing `config` on the interface `Illuminate\Contracts\Foundation\Application` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
51
52		$this->app->bind(PermissionContract::class, $config['permission']);
53		$this->app->bind(RoleContract::class, $config['role']);
54		}
55
56		protected function registerBladeExtensions()
57		{
58		$this->app->afterResolving('blade.compiler', function (BladeCompiler $bladeCompiler) {
59	View Code Duplication	$bladeCompiler->directive('role', function ($arguments) {
		0 ignored issues – show Duplication introduced 2017-04-10 14:32 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
60		list($role, $guard) = explode(',', $arguments.',');
61
62		return "<?php if(auth({$guard})->check() && auth({$guard})->user()->hasRole({$role})): ?>";
63		});
64		$bladeCompiler->directive('endrole', function () {
65		return '<?php endif; ?>';
66		});
67
68	View Code Duplication	$bladeCompiler->directive('hasrole', function ($arguments) {
		0 ignored issues – show Duplication introduced 2017-04-10 14:32 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
69		list($role, $guard) = explode(',', $arguments.',');
70
71		return "<?php if(auth({$guard})->check() && auth({$guard})->user()->hasRole({$role})): ?>";
72		});
73		$bladeCompiler->directive('endhasrole', function () {
74		return '<?php endif; ?>';
75		});
76
77	View Code Duplication	$bladeCompiler->directive('hasanyrole', function ($arguments) {
		0 ignored issues – show Duplication introduced 2017-04-10 14:32 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		list($roles, $guard) = explode(',', $arguments.',');
79		$roles = $this->convertPipeToArray($roles);
80
81		return "<?php if(auth({$guard})->check() && auth({$guard})->user()->hasAnyRole({$roles})): ?>";
82		});
83		$bladeCompiler->directive('endhasanyrole', function () {
84		return '<?php endif; ?>';
85		});
86
87	View Code Duplication	$bladeCompiler->directive('hasallroles', function ($arguments) {
		0 ignored issues – show Duplication introduced 2017-04-10 14:32 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
88		list($roles, $guard) = explode(',', $arguments.',');
89		$roles = $this->convertPipeToArray($roles);
90
91		return "<?php if(auth({$guard})->check() && auth({$guard})->user()->hasAllRoles({$roles})): ?>";
92		});
93		$bladeCompiler->directive('endhasallroles', function () {
94		return '<?php endif; ?>';
95		});
96		});
97		}
98
99		public function convertPipeToArray(string $pipeString)
100		{
101		$pipeString = trim($pipeString);
102
103		if (strlen($pipeString) <= 2) {
104		return $pipeString;
105		}
106
107		$quoteCharacter = substr($pipeString, 0, 1);
108
109		if (! in_array($quoteCharacter, ["'", '"'])) {
110		return $pipeString;
111		}
112
113		$endCharacter = substr($quoteCharacter, -1, 1);
114
115		if ($quoteCharacter !== $endCharacter) {
116		return $pipeString;
117		}
118
119		$roleString = '['.implode($quoteCharacter.','.$quoteCharacter, explode('\|', $pipeString)).']';
120
121		return $roleString;
122		}
123		}
124

spatie / laravel-permission

Push — master ( ebc159...dcba67 )

PermissionServiceProvider::convertPipeToArray() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like