PermissionMiddleware::handle() - Code Metrics - Inspection of "Add guard for middleware" - spatie/laravel-permission - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1312)

unknown

created 2019-12-28 16:19 UTC

PermissionMiddleware::handle() B

↳ Parent: PermissionMiddleware

Complexity

Conditions	8
Paths	20

Size

Total Lines

Duplication

Lines	24
Ratio	100 %

Importance

Changes

Metric	Value
cc	8
nc	20
nop	3
dl	24
loc	24
rs	8.4444
c	0
b	0
f	0

<?php

namespace Spatie\Permission\Middlewares;

use Closure;
use Spatie\Permission\Exceptions\UnauthorizedException;

class PermissionMiddleware

{
    public function handle($request, Closure $next, $permission)
    {
        if (is_string($permission)) {     // sample : 'create-admin|update-admin@admin' , here admin is guard name and create-admin , update-admin are permission. | Notice: guard is optional.
            $parsed = explode('@', $permission);
            $guard = isset($parsed[1])
                ? $parsed[1]
                : null;
            $permissions = explode('|', $parsed[0]);
        } elseif (is_array($permission)) {
            $guard = isset($permission['guard']) ? $permission['guard'] : null;
            $permissions = $permission['permission'];
        }
        if (auth($guard)->guest()) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            throw UnauthorizedException::notLoggedIn();
        }

        foreach ($permissions as $permission) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            if (auth($guard)->user()->can($permission)) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                return $next($request);
            }
        }

        throw UnauthorizedException::forPermissions($permissions);
    }
}


Pull Request — master (#1312)

PermissionMiddleware::handle() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace Spatie\Permission\Middlewares;
4
5		use Closure;
6		use Spatie\Permission\Exceptions\UnauthorizedException;
7
8	View Code Duplication	class PermissionMiddleware
		0 ignored issues – show Duplication introduced 2017-10-20 15:01 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9		{
10		public function handle($request, Closure $next, $permission)
11		{
12		if (is_string($permission)) { // sample : 'create-admin\|update-admin@admin' , here admin is guard name and create-admin , update-admin are permission. \| Notice: guard is optional.
13		$parsed = explode('@', $permission);
14		$guard = isset($parsed[1])
15		? $parsed[1]
16		: null;
17		$permissions = explode('\|', $parsed[0]);
18		} elseif (is_array($permission)) {
19		$guard = isset($permission['guard']) ? $permission['guard'] : null;
20		$permissions = $permission['permission'];
21		}
22		if (auth($guard)->guest()) {
		0 ignored issues – show Bug introduced 2019-12-28 16:20 UTC by Report Bug Copy Issue Report The variable `$guard` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Bug introduced 2019-12-28 16:20 UTC by Report Bug Copy Issue Report The method `guest` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
23		throw UnauthorizedException::notLoggedIn();
24		}
25
26		foreach ($permissions as $permission) {
		0 ignored issues – show Bug introduced 2019-12-28 16:20 UTC by Report Bug Copy Issue Report The variable `$permissions` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
27		if (auth($guard)->user()->can($permission)) {
		0 ignored issues – show Bug introduced 2019-12-28 16:20 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
28		return $next($request);
29		}
30		}
31
32		throw UnauthorizedException::forPermissions($permissions);
33		}
34		}
35

spatie / laravel-permission

Pull Request — master (#1312)

PermissionMiddleware::handle() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like