Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like HasPermissions often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use HasPermissions, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 14 | trait HasPermissions |
||
| 15 | { |
||
| 16 | private $permissionClass; |
||
| 17 | |||
| 18 | public static function bootHasPermissions() |
||
| 28 | |||
| 29 | public function getPermissionClass() |
||
| 37 | |||
| 38 | /** |
||
| 39 | * A model may have multiple direct permissions. |
||
| 40 | */ |
||
| 41 | public function permissions(): MorphToMany |
||
| 51 | |||
| 52 | /** |
||
| 53 | * Scope the model query to certain permissions only. |
||
| 54 | * |
||
| 55 | * @param \Illuminate\Database\Eloquent\Builder $query |
||
| 56 | * @param string|array|\Spatie\Permission\Contracts\Permission|\Illuminate\Support\Collection $permissions |
||
| 57 | * |
||
| 58 | * @return \Illuminate\Database\Eloquent\Builder |
||
| 59 | */ |
||
| 60 | public function scopePermission(Builder $query, $permissions): Builder |
||
| 87 | |||
| 88 | /** |
||
| 89 | * @param string|array|\Spatie\Permission\Contracts\Permission|\Illuminate\Support\Collection $permissions |
||
| 90 | * |
||
| 91 | * @return array |
||
| 92 | */ |
||
| 93 | protected function convertToPermissionModels($permissions): array |
||
| 109 | |||
| 110 | /** |
||
| 111 | * Determine if the model may perform the given permission. |
||
| 112 | * |
||
| 113 | * @param string|int|\Spatie\Permission\Contracts\Permission $permission |
||
| 114 | * @param string|null $guardName |
||
| 115 | * |
||
| 116 | * @return bool |
||
| 117 | */ |
||
| 118 | public function hasPermissionTo($permission, $guardName = null): bool |
||
| 142 | |||
| 143 | /** |
||
| 144 | * An alias to hasPermissionTo(), but avoids throwing an exception. |
||
| 145 | * |
||
| 146 | * @param string|int|\Spatie\Permission\Contracts\Permission $permission |
||
| 147 | * @param string|null $guardName |
||
| 148 | * |
||
| 149 | * @return bool |
||
| 150 | */ |
||
| 151 | public function checkPermissionTo($permission, $guardName = null): bool |
||
| 159 | |||
| 160 | /** |
||
| 161 | * Determine if the model has any of the given permissions. |
||
| 162 | * |
||
| 163 | * @param array ...$permissions |
||
| 164 | * |
||
| 165 | * @return bool |
||
| 166 | */ |
||
| 167 | View Code Duplication | public function hasAnyPermission(...$permissions): bool |
|
| 181 | |||
| 182 | /** |
||
| 183 | * Determine if the model has all of the given permissions. |
||
| 184 | * |
||
| 185 | * @param array ...$permissions |
||
| 186 | * |
||
| 187 | * @return bool |
||
| 188 | */ |
||
| 189 | View Code Duplication | public function hasAllPermissions(...$permissions): bool |
|
| 203 | |||
| 204 | /** |
||
| 205 | * Determine if the model has, via roles, the given permission. |
||
| 206 | * |
||
| 207 | * @param \Spatie\Permission\Contracts\Permission $permission |
||
| 208 | * |
||
| 209 | * @return bool |
||
| 210 | */ |
||
| 211 | protected function hasPermissionViaRole(Permission $permission): bool |
||
| 215 | |||
| 216 | /** |
||
| 217 | * Determine if the model has the given permission. |
||
| 218 | * |
||
| 219 | * @param string|int|\Spatie\Permission\Contracts\Permission $permission |
||
| 220 | * |
||
| 221 | * @return bool |
||
| 222 | */ |
||
| 223 | public function hasDirectPermission($permission): bool |
||
| 247 | |||
| 248 | /** |
||
| 249 | * Return all the permissions the model has via roles. |
||
| 250 | */ |
||
| 251 | public function getPermissionsViaRoles(): Collection |
||
| 258 | |||
| 259 | /** |
||
| 260 | * Return all the permissions the model has, both directly and via roles. |
||
| 261 | */ |
||
| 262 | public function getAllPermissions(): Collection |
||
| 272 | |||
| 273 | /** |
||
| 274 | * Grant the given permission(s) to a role. |
||
| 275 | * |
||
| 276 | * @param string|array|\Spatie\Permission\Contracts\Permission|\Illuminate\Support\Collection $permissions |
||
| 277 | * |
||
| 278 | * @return $this |
||
| 279 | */ |
||
| 280 | View Code Duplication | public function givePermissionTo(...$permissions) |
|
| 315 | |||
| 316 | /** |
||
| 317 | * Remove all current permissions and set the given ones. |
||
| 318 | * |
||
| 319 | * @param string|array|\Spatie\Permission\Contracts\Permission|\Illuminate\Support\Collection $permissions |
||
| 320 | * |
||
| 321 | * @return $this |
||
| 322 | */ |
||
| 323 | public function syncPermissions(...$permissions) |
||
| 329 | |||
| 330 | /** |
||
| 331 | * Revoke the given permission. |
||
| 332 | * |
||
| 333 | * @param \Spatie\Permission\Contracts\Permission|\Spatie\Permission\Contracts\Permission[]|string|string[] $permission |
||
| 334 | * |
||
| 335 | * @return $this |
||
| 336 | */ |
||
| 337 | public function revokePermissionTo($permission) |
||
| 347 | |||
| 348 | /** |
||
| 349 | * @param string|array|\Spatie\Permission\Contracts\Permission|\Illuminate\Support\Collection $permissions |
||
| 350 | * |
||
| 351 | * @return \Spatie\Permission\Contracts\Permission|\Spatie\Permission\Contracts\Permission[]|\Illuminate\Support\Collection |
||
| 352 | */ |
||
| 353 | protected function getStoredPermission($permissions) |
||
| 374 | |||
| 375 | /** |
||
| 376 | * @param \Spatie\Permission\Contracts\Permission|\Spatie\Permission\Contracts\Role $roleOrPermission |
||
| 377 | * |
||
| 378 | * @throws \Spatie\Permission\Exceptions\GuardDoesNotMatch |
||
| 379 | */ |
||
| 380 | protected function ensureModelSharesGuard($roleOrPermission) |
||
| 386 | |||
| 387 | protected function getGuardNames(): Collection |
||
| 391 | |||
| 392 | protected function getDefaultGuardName(): string |
||
| 396 | |||
| 397 | /** |
||
| 398 | * Forget the cached permissions. |
||
| 399 | */ |
||
| 400 | public function forgetCachedPermissions() |
||
| 404 | } |
||
| 405 |
This check looks for methods that are used by a trait but not required by it.
To illustrate, let’s look at the following code example
The trait
Idableprovides a methodequalsIdthat in turn relies on the methodgetId(). If this method does not exist on a class mixing in this trait, the method will fail.Adding the
getId()as an abstract method to the trait will make sure it is available.