Guard::getNames() - Code Metrics - Inspection of "Merge pull request #622 from Te7a-Houdini/support-..." - spatie/laravel-permission - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b4a74b...2688c4 )

by Chris

created 2018-01-25 15:08 UTC

Guard::getNames() B

↳ Parent: Guard

Complexity

Conditions	5
Paths	12

Size

Total Lines	25
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	14
nc	12
nop	1
dl	0
loc	25
rs	8.439
c	0
b	0
f	0

<?php

namespace Spatie\Permission;

use Illuminate\Support\Collection;

class Guard
{
    /**
     * return collection of (guard_name) property if exist on class or object
     * otherwise will return collection of guards names that exists in config/auth.php.
     * @param $model
     * @return Collection
     */
    public static function getNames($model) : Collection
    {
        if (is_object($model)) {
            $guardName = $model->guard_name ?? null;
        }

        if (! isset($guardName)) {
            $class = is_object($model) ? get_class($model) : $model;

            $guardName = (new \ReflectionClass($class))->getDefaultProperties()['guard_name'] ?? null;
        }

        if ($guardName) {
            return collect($guardName);
        }

        return collect(config('auth.guards'))
            ->map(function ($guard) {
                return config("auth.providers.{$guard['provider']}.model");
            })
            ->filter(function ($model) use ($class) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                return $class === $model;
            })
            ->keys();
    }

    public static function getDefaultName($class): string
    {
        $default = config('auth.defaults.guard');

        return static::getNames($class)->first() ?: $default;
    }
}


1			<?php
2
3			namespace Spatie\Permission;
4
5			use Illuminate\Support\Collection;
6
7			class Guard
8			{
9			/**
10			* return collection of (guard_name) property if exist on class or object
11			* otherwise will return collection of guards names that exists in config/auth.php.
12			* @param $model
13			* @return Collection
14			*/
15			public static function getNames($model) : Collection
16			{
17			if (is_object($model)) {
18			$guardName = $model->guard_name ?? null;
19			}
20
21			if (! isset($guardName)) {
22			$class = is_object($model) ? get_class($model) : $model;
23
24			$guardName = (new \ReflectionClass($class))->getDefaultProperties()['guard_name'] ?? null;
25			}
26
27			if ($guardName) {
28			return collect($guardName);
29			}
30
31			return collect(config('auth.guards'))
32			->map(function ($guard) {
33			return config("auth.providers.{$guard['provider']}.model");
34			})
35			->filter(function ($model) use ($class) {
			0 ignored issues – show Bug introduced 2018-01-11 00:57 UTC by Report Bug Copy Issue Report The variable `$class` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
36			return $class === $model;
37			})
38			->keys();
39			}
40
41			public static function getDefaultName($class): string
42			{
43			$default = config('auth.defaults.guard');
44
45			return static::getNames($class)->first() ?: $default;
46			}
47			}
48

spatie / laravel-permission

Push — master ( b4a74b...2688c4 )

Guard::getNames() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like