HasPermissions::usingMultipleArguments() - Code Metrics - Inspection of "refactor" - spatie/laravel-permission - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ed6b20...20e9a9 )

by Freek

created 2016-07-23 21:21 UTC

HasPermissions::usingMultipleArguments() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

namespace Spatie\Permission\Traits;

use Spatie\Permission\Contracts\Permission;

trait HasPermissions
{
    /**
     * Grant the given permission(s) to a role.
     *
     * @param string|array|Permission|\Illuminate\Support\Collection $permissions
     *
     * @return HasPermissions

     */
    public function givePermissionTo(...$permissions)
    {
        collect($permissions)
            ->flatten()
            ->map(function ($permission) {
                return $this->getStoredPermission($permission);
            })
            ->each(function (Permission $permission) {
                return $this->permissions()->save($permission);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            });

        $this->forgetCachedPermissions();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this;
    }

    /**
     * Revoke the given permission.
     *
     * @param $permission
     *
     * @return HasPermissions

     */
    public function revokePermissionTo($permission)
    {
        $this->permissions()->detach($this->getStoredPermission($permission));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $this->forgetCachedPermissions();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this;
    }

    /**
     * @param string|array|Permission|\Illuminate\Support\Collection $permissions
     *
     * @return Permission
     */
    protected function getStoredPermission($permissions)
    {
        if (is_string($permissions)) {
            return app(Permission::class)->findByName($permissions);
        }

        if (is_array($permissions)) {
            return app(Permission::class)->whereIn('name', $permissions)->get();
        }

        return $permissions;
    }
}


1			<?php
2
3			namespace Spatie\Permission\Traits;
4
5			use Spatie\Permission\Contracts\Permission;
6
7			trait HasPermissions
8			{
9			/**
10			* Grant the given permission(s) to a role.
11			*
12			* @param string\|array\|Permission\|\Illuminate\Support\Collection $permissions
13			*
14			* @return HasPermissions
			0 ignored issues – show Comprehensibility Bug introduced 2015-12-21 23:32 UTC by Report Bug Copy Issue Report The return type `HasPermissions` is a trait, and thus cannot be used for type-hinting in PHP. Maybe consider adding an interface and use that for type-hinting? In PHP traits cannot be used for type-hinting as they do not define a well-defined structure. This is because any class that uses a trait can rename that trait’s methods. If you would like to return an object that has a guaranteed set of methods, you could create a companion interface that lists these methods explicitly. Loading history...
15			*/
16			public function givePermissionTo(...$permissions)
17			{
18			collect($permissions)
19			->flatten()
20			->map(function ($permission) {
21			return $this->getStoredPermission($permission);
22			})
23			->each(function (Permission $permission) {
24			return $this->permissions()->save($permission);
			0 ignored issues – show Bug introduced 2016-07-23 21:22 UTC by Report Bug Copy Issue Report It seems like `permissions()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25			});
26
27			$this->forgetCachedPermissions();
			0 ignored issues – show Bug introduced 2016-07-23 21:22 UTC by Report Bug Copy Issue Report It seems like `forgetCachedPermissions()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28
29			return $this;
30			}
31
32			/**
33			* Revoke the given permission.
34			*
35			* @param $permission
36			*
37			* @return HasPermissions
			0 ignored issues – show Comprehensibility Bug introduced 2015-12-21 23:32 UTC by Report Bug Copy Issue Report The return type `HasPermissions` is a trait, and thus cannot be used for type-hinting in PHP. Maybe consider adding an interface and use that for type-hinting? In PHP traits cannot be used for type-hinting as they do not define a well-defined structure. This is because any class that uses a trait can rename that trait’s methods. If you would like to return an object that has a guaranteed set of methods, you could create a companion interface that lists these methods explicitly. Loading history...
38			*/
39			public function revokePermissionTo($permission)
40			{
41			$this->permissions()->detach($this->getStoredPermission($permission));
			0 ignored issues – show Bug introduced 2015-12-21 23:32 UTC by Report Bug Copy Issue Report It seems like `permissions()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
42
43			$this->forgetCachedPermissions();
			0 ignored issues – show Bug introduced 2015-12-21 23:32 UTC by Report Bug Copy Issue Report It seems like `forgetCachedPermissions()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
44
45			return $this;
46			}
47
48			/**
49			* @param string\|array\|Permission\|\Illuminate\Support\Collection $permissions
50			*
51			* @return Permission
52			*/
53			protected function getStoredPermission($permissions)
54			{
55			if (is_string($permissions)) {
56			return app(Permission::class)->findByName($permissions);
57			}
58
59			if (is_array($permissions)) {
60			return app(Permission::class)->whereIn('name', $permissions)->get();
61			}
62
63			return $permissions;
64			}
65			}
66

spatie / laravel-permission

Push — master ( ed6b20...20e9a9 )

HasPermissions::usingMultipleArguments() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like