PermissionServiceProvider::booted() - Code Metrics - Inspection of "Move Permissions Registration to booted method" - spatie/laravel-permission - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#143)

by Ian

created 2016-12-12 22:46 UTC

PermissionServiceProvider::booted() A

↳ Parent: PermissionServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

namespace Spatie\Permission;

use Illuminate\Support\ServiceProvider;
use Illuminate\View\Compilers\BladeCompiler;
use Spatie\Permission\Contracts\Permission as PermissionContract;
use Spatie\Permission\Contracts\Role as RoleContract;

class PermissionServiceProvider extends ServiceProvider
{
    /**
     * Bootstrap the application services.
     *
     * @param PermissionRegistrar $permissionLoader
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function boot()
    {
        $this->publishes([
            __DIR__.'/../resources/config/laravel-permission.php' => $this->app->configPath().'/'.'laravel-permission.php',
        ], 'config');

        if (!class_exists('CreatePermissionTables')) {
            // Publish the migration
            $timestamp = date('Y_m_d_His', time());
            $this->publishes([
                __DIR__.'/../resources/migrations/create_permission_tables.php.stub' => $this->app->databasePath().'/migrations/'.$timestamp.'_create_permission_tables.php',

            ], 'migrations');
        }
    }
    
    /**
     * Finish configuring the application.
     *
     * @return void
     */
    public function booted(PermissionRegistrar $permissionLoader)
    {
        $permissionLoader->registerPermissions();
    }

    /**
     * Register the application services.
     */
    public function register()
    {
        $this->mergeConfigFrom(__DIR__.'/../resources/config/laravel-permission.php', 'laravel-permission');

        $this->registerModelBindings();

        $this->registerBladeExtensions();
    }

    /**
     * Bind the Permission and Role model into the IoC.
     */
    protected function registerModelBindings()
    {
        $config = $this->app->config['laravel-permission.models'];
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $this->app->bind(PermissionContract::class, $config['permission']);
        $this->app->bind(RoleContract::class, $config['role']);
    }

    /**
     * Register the blade extensions.
     */
    protected function registerBladeExtensions()
    {
        $this->app->afterResolving('blade.compiler', function (BladeCompiler $bladeCompiler) {
            $bladeCompiler->directive('role', function ($role) {
                return "<?php if(auth()->check() && auth()->user()->hasRole({$role})): ?>";
            });
            $bladeCompiler->directive('endrole', function () {
                return '<?php endif; ?>';
            });

            $bladeCompiler->directive('hasrole', function ($role) {
                return "<?php if(auth()->check() && auth()->user()->hasRole({$role})): ?>";
            });
            $bladeCompiler->directive('endhasrole', function () {
                return '<?php endif; ?>';
            });

            $bladeCompiler->directive('hasanyrole', function ($roles) {
                return "<?php if(auth()->check() && auth()->user()->hasAnyRole({$roles})): ?>";
            });
            $bladeCompiler->directive('endhasanyrole', function () {
                return '<?php endif; ?>';
            });

            $bladeCompiler->directive('hasallroles', function ($roles) {
                return "<?php if(auth()->check() && auth()->user()->hasAllRoles({$roles})): ?>";
            });
            $bladeCompiler->directive('endhasallroles', function () {
                return '<?php endif; ?>';
            });
        });
    }
}


1			<?php
2
3			namespace Spatie\Permission;
4
5			use Illuminate\Support\ServiceProvider;
6			use Illuminate\View\Compilers\BladeCompiler;
7			use Spatie\Permission\Contracts\Permission as PermissionContract;
8			use Spatie\Permission\Contracts\Role as RoleContract;
9
10			class PermissionServiceProvider extends ServiceProvider
11			{
12			/**
13			* Bootstrap the application services.
14			*
15			* @param PermissionRegistrar $permissionLoader
			0 ignored issues – show Bug introduced 2016-12-12 22:52 UTC by Report Bug Copy Issue Report There is no parameter named `$permissionLoader`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
16			*/
17			public function boot()
18			{
19			$this->publishes([
20			__DIR__.'/../resources/config/laravel-permission.php' => $this->app->configPath().'/'.'laravel-permission.php',
21			], 'config');
22
23			if (!class_exists('CreatePermissionTables')) {
24			// Publish the migration
25			$timestamp = date('Y_m_d_His', time());
26			$this->publishes([
27			__DIR__.'/../resources/migrations/create_permission_tables.php.stub' => $this->app->databasePath().'/migrations/'.$timestamp.'_create_permission_tables.php',
			0 ignored issues – show Bug introduced 2015-12-21 23:32 UTC by Report Bug Copy Issue Report The method `databasePath()` does not exist on `Illuminate\Contracts\Foundation\Application`. Did you maybe mean `basePath()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
28			], 'migrations');
29			}
30			}
31
32			/**
33			* Finish configuring the application.
34			*
35			* @return void
36			*/
37			public function booted(PermissionRegistrar $permissionLoader)
38			{
39			$permissionLoader->registerPermissions();
40			}
41
42			/**
43			* Register the application services.
44			*/
45			public function register()
46			{
47			$this->mergeConfigFrom(__DIR__.'/../resources/config/laravel-permission.php', 'laravel-permission');
48
49			$this->registerModelBindings();
50
51			$this->registerBladeExtensions();
52			}
53
54			/**
55			* Bind the Permission and Role model into the IoC.
56			*/
57			protected function registerModelBindings()
58			{
59			$config = $this->app->config['laravel-permission.models'];
			0 ignored issues – show Bug introduced 2015-12-21 23:32 UTC by Report Bug Copy Issue Report Accessing `config` on the interface `Illuminate\Contracts\Foundation\Application` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
60
61			$this->app->bind(PermissionContract::class, $config['permission']);
62			$this->app->bind(RoleContract::class, $config['role']);
63			}
64
65			/**
66			* Register the blade extensions.
67			*/
68			protected function registerBladeExtensions()
69			{
70			$this->app->afterResolving('blade.compiler', function (BladeCompiler $bladeCompiler) {
71			$bladeCompiler->directive('role', function ($role) {
72			return "<?php if(auth()->check() && auth()->user()->hasRole({$role})): ?>";
73			});
74			$bladeCompiler->directive('endrole', function () {
75			return '<?php endif; ?>';
76			});
77
78			$bladeCompiler->directive('hasrole', function ($role) {
79			return "<?php if(auth()->check() && auth()->user()->hasRole({$role})): ?>";
80			});
81			$bladeCompiler->directive('endhasrole', function () {
82			return '<?php endif; ?>';
83			});
84
85			$bladeCompiler->directive('hasanyrole', function ($roles) {
86			return "<?php if(auth()->check() && auth()->user()->hasAnyRole({$roles})): ?>";
87			});
88			$bladeCompiler->directive('endhasanyrole', function () {
89			return '<?php endif; ?>';
90			});
91
92			$bladeCompiler->directive('hasallroles', function ($roles) {
93			return "<?php if(auth()->check() && auth()->user()->hasAllRoles({$roles})): ?>";
94			});
95			$bladeCompiler->directive('endhasallroles', function () {
96			return '<?php endif; ?>';
97			});
98			});
99			}
100			}
101

spatie / laravel-permission

Pull Request — master (#143)

PermissionServiceProvider::booted() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like