Spatie\ModelStatus\HasStatuses

Complexity

Total Complexity

7

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	statuses()	0	4	1
A	status()	0	4	1
A	setStatus()	0	12	2
A	isValidStatus()	0	4	1
A	latestStatus()	0	8	2

<?php

namespace Spatie\ModelStatus;

use Spatie\ModelStatus\Models\Status;
use Illuminate\Database\Eloquent\Relations\MorphMany;
use Spatie\ModelStatus\Exceptions\InvalidStatus;

trait HasStatuses
{
    public function statuses(): MorphMany
    {
        return $this->morphMany(Status::class, 'model');

It seems like morphMany() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function status(): ?Status
    {
        return $this->latestStatus();
    }

    public function setStatus(string $name, string $reason = ''): self
    {
        if (! $this->isValidStatus($name, $reason)) {
            throw InvalidStatus::create($name, $reason);

The call to InvalidStatus::create() has too many arguments starting with $reason.

        }

        $attributes = compact('name', 'reason');

        $this->statuses()->create($attributes);

        return $this;
    }

    public function isValidStatus(string $name, string $reason = ''): bool

The parameter $name is not used and could be removed.

The parameter $reason is not used and could be removed.

    {
        return true;
    }

    public function latestStatus(string ...$name): ?Status
    {
        if (empty($name)) {
            return $this->statuses()->latest()->orderByDesc('id')->first();
        }

        return $this->statuses()->whereIn('name', $name)->latest()->orderByDesc('id')->first();
    }
}