Spatie\ModelStatus\HasStatuses

Complexity

Total Complexity

9

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	statuses()	0	4	1
A	status()	0	4	1
A	setStatus()	0	12	2
A	isValidStatus()	0	4	1
A	latestStatus()	0	10	3
A	clearStatuses()	0	4	1

<?php

namespace Spatie\ModelStatus;

use Spatie\ModelStatus\Exceptions\InvalidStatus;
use Illuminate\Database\Eloquent\Relations\MorphMany;

trait HasStatuses
{
    public function statuses(): MorphMany
    {
        return $this->morphMany(ModelStatusServiceProvider::getStatusModel(), 'model');

It seems like morphMany() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function status(): ?Status
    {
        return $this->latestStatus();
    }

    public function setStatus(string $name, string $reason = ''): self
    {
        if (! $this->isValidStatus($name, $reason)) {
            throw InvalidStatus::create($name, $reason);

The call to InvalidStatus::create() has too many arguments starting with $reason.

        }

        $attributes = compact('name', 'reason');

        $this->statuses()->create($attributes);

        return $this;
    }

    public function isValidStatus(string $name, string $reason = ''): bool

The parameter $name is not used and could be removed.

The parameter $reason is not used and could be removed.

    {
        return true;
    }

    /**
     * @param string|array $names
     * @return null|Status
     */
    public function latestStatus(...$names): ?Status
    {
        $names = is_array($names) ? array_flatten($names) : func_get_args();

        if (count($names) < 1) {
            return $this->statuses()->latest()->orderByDesc('id')->first();
        }

        return $this->statuses()->whereIn('name', $names)->latest()->orderByDesc('id')->first();
    }

    public function clearStatuses(): ?bool
    {
        return $this->statuses()->delete();
    }
}