spatie / laravel-model-states

src/Events/StateChanged.php

<?php

namespace Spatie\ModelStates\Events;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Queue\SerializesModels;
use Spatie\ModelStates\State;
use Spatie\ModelStates\Transition;

class StateChanged
{
    use SerializesModels;

The trait Illuminate\Queue\SerializesModels requires some properties which are not provided by Spatie\ModelStates\Events\StateChanged: $id, $relations, $class, $connection, $keyBy

    /** @var \Spatie\ModelStates\State|null */
    public $initialState;

    /**
     * @var null
     * @deprecated
     * @see https://github.com/spatie/laravel-model-states/issues/49
     */
    public $finalState;

    /** @var \Spatie\ModelStates\Transition */
    public $transition;

    /** @var \Illuminate\Database\Eloquent\Model */
    public $model;

    public function __construct(
        ?State $initialState,
        ?State $finalState,
        Transition $transition,
        Model $model
    ) {
        $this->initialState = $initialState;
        $this->finalState = $finalState;

The property Spatie\ModelStates\Events\StateChanged::$finalState has been deprecated.

It seems like $finalState can also be of type Spatie\ModelStates\State. However, the property $finalState is declared as type null. Maybe add an additional type check?

        $this->transition = $transition;
        $this->model = $model;
    }
}