RenderPreloadLinks::getHrefAttribute() - Code Metrics - Inspection of "Add option to specify asset url for preload links" - spatie/laravel-mix-preload - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#7)

unknown

created 2020-07-10 11:15 UTC

RenderPreloadLinks::getHrefAttribute() A

↳ Parent: RenderPreloadLinks

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace Spatie\MixPreload;

use Illuminate\Support\Collection;
use Illuminate\Support\HtmlString;
use Illuminate\Support\Str;

class RenderPreloadLinks
{
    /** @var array */
    protected $manifest;

    /** @var string|null */
    protected $assetUrl;

    public static function create(string $manifestPath = null, string $assetUrl = null): RenderPreloadLinks
    {
        if (!$manifestPath) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $manifestPath = public_path('mix-manifest.json');
        }

        $manifest = json_decode(
            file_get_contents($manifestPath),
            true
        );

        return new self($manifest, $assetUrl);
    }

    public function __construct(array $manifest, string $assetUrl = null)
    {
        $this->manifest = $manifest;
        $this->assetUrl = $assetUrl;
    }

    public function __invoke(): HtmlString
    {
        return $this->getManifestEntries()
            ->mapSpread(function (string $path, string $name) {
                $rel = $this->getRelAttribute($name);

                if (!$rel) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                    return null;
                }

                $as = $this->getAsAttribute($path);

                if (!$as) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                    return null;
                }

                $path = $this->getHrefAttribute($path);

                return "<link rel=\"{$rel}\" href=\"{$path}\" as=\"{$as}\">";
            })
            ->filter()
            ->pipe(function (Collection $links) {
                return new HtmlString($links->implode("\n"));
            });
    }

    protected function getManifestEntries(): Collection
    {
        return collect($this->manifest)
            ->map(function (string $path, string $name) {
                return [$path, $name];
            })
            ->values();
    }

    protected function getRelAttribute(string $name): ?string
    {
        if (Str::contains($name, 'preload')) {
            return 'preload';
        }

        if (Str::contains($name, 'prefetch')) {
            return 'prefetch';
        }

        return null;
    }

    protected function getAsAttribute(string $path): ?string
    {
        if (Str::contains($path, '.js')) {
            return 'script';
        }

        if (Str::contains($path, '.css')) {
            return 'style';
        }
        
        if (Str::contains($path, ['.woff', '.woff2', '.ttf', '.eot', '.svg', '.ttc'])) {
            return 'font';
        }

        return null;
    }

    protected function getHrefAttribute(string $path): ?string
    {
        if ($this->assetUrl !== null) {
            return $this->assetUrl . $path;
        }

        return $path;
    }
}


1			<?php
2
3			namespace Spatie\MixPreload;
4
5			use Illuminate\Support\Collection;
6			use Illuminate\Support\HtmlString;
7			use Illuminate\Support\Str;
8
9			class RenderPreloadLinks
10			{
11			/** @var array */
12			protected $manifest;
13
14			/** @var string\|null */
15			protected $assetUrl;
16
17			public static function create(string $manifestPath = null, string $assetUrl = null): RenderPreloadLinks
18			{
19			if (!$manifestPath) {
			0 ignored issues – show Bug Best Practice introduced 2019-10-21 12:11 UTC by Report Bug Copy Issue Report The expression `$manifestPath` of type `null\|string` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
20			$manifestPath = public_path('mix-manifest.json');
21			}
22
23			$manifest = json_decode(
24			file_get_contents($manifestPath),
25			true
26			);
27
28			return new self($manifest, $assetUrl);
29			}
30
31			public function __construct(array $manifest, string $assetUrl = null)
32			{
33			$this->manifest = $manifest;
34			$this->assetUrl = $assetUrl;
35			}
36
37			public function __invoke(): HtmlString
38			{
39			return $this->getManifestEntries()
40			->mapSpread(function (string $path, string $name) {
41			$rel = $this->getRelAttribute($name);
42
43			if (!$rel) {
			0 ignored issues – show Bug Best Practice introduced 2019-10-21 12:11 UTC by Report Bug Copy Issue Report The expression `$rel` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
44			return null;
45			}
46
47			$as = $this->getAsAttribute($path);
48
49			if (!$as) {
			0 ignored issues – show Bug Best Practice introduced 2019-10-21 12:11 UTC by Report Bug Copy Issue Report The expression `$as` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
50			return null;
51			}
52
53			$path = $this->getHrefAttribute($path);
54
55			return "<link rel=\"{$rel}\" href=\"{$path}\" as=\"{$as}\">";
56			})
57			->filter()
58			->pipe(function (Collection $links) {
59			return new HtmlString($links->implode("\n"));
60			});
61			}
62
63			protected function getManifestEntries(): Collection
64			{
65			return collect($this->manifest)
66			->map(function (string $path, string $name) {
67			return [$path, $name];
68			})
69			->values();
70			}
71
72			protected function getRelAttribute(string $name): ?string
73			{
74			if (Str::contains($name, 'preload')) {
75			return 'preload';
76			}
77
78			if (Str::contains($name, 'prefetch')) {
79			return 'prefetch';
80			}
81
82			return null;
83			}
84
85			protected function getAsAttribute(string $path): ?string
86			{
87			if (Str::contains($path, '.js')) {
88			return 'script';
89			}
90
91			if (Str::contains($path, '.css')) {
92			return 'style';
93			}
94
95			if (Str::contains($path, ['.woff', '.woff2', '.ttf', '.eot', '.svg', '.ttc'])) {
96			return 'font';
97			}
98
99			return null;
100			}
101
102			protected function getHrefAttribute(string $path): ?string
103			{
104			if ($this->assetUrl !== null) {
105			return $this->assetUrl . $path;
106			}
107
108			return $path;
109			}
110			}
111

spatie / laravel-mix-preload

GitHub Access Token became invalid

Pull Request — master (#7)

RenderPreloadLinks::getHrefAttribute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like