Spatie\Menu\Laravel\Link

Complexity

Total Complexity

3

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	toUrl()	0	4	1
A	toAction()	0	4	1
A	toRoute()	0	4	1

<?php

namespace Spatie\Menu\Laravel;

use Illuminate\Support\Traits\Macroable;
use Spatie\Menu\Link as BaseLink;

class Link extends BaseLink
{
    use Macroable;

    /**
     * @param string $path
     * @param string $text
     * @param array $parameters
     * @param bool|null $secure
     *
     * @return static
     */
    public static function toUrl(string $path, string $text, array $parameters = [], $secure = null)
    {
        return static::to(url($path, $parameters, $secure), $text);

It seems like url($path, $parameters, $secure) targeting url() can also be of type object<Illuminate\Contracts\Routing\UrlGenerator>; however, Spatie\Menu\Link::to() does only seem to accept string, maybe add an additional type check?

    }

    /**
     * @param string $action
     * @param string $text
     * @param array $parameters
     * @param bool $absolute
     *
     * @return static
     */
    public static function toAction(string $action, string $text, array $parameters = [], bool $absolute = true)
    {
        return static::to(action($action, $parameters, $absolute), $text);
    }

    /**
     * @param string $name
     * @param string $text
     * @param array $parameters
     * @param bool $absolute
     * @param \Illuminate\Routing\Route|null $route
     *
     * @return static
     */
    public static function toRoute(string $name, string $text, array $parameters = [], $absolute = true, $route = null)
    {
        return static::to(route($name, $parameters, $absolute, $route), $text);

The call to route() has too many arguments starting with $route.

    }
}