Link::action() - Code Metrics - Inspection of "Updated menu; Convenience methods; Docs" - spatie/laravel-menu - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7f32b3...b1a367 )

by Sebastian

created 2016-03-18 09:45 UTC

Link::action() A

↳ Parent: Link

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	4

<?php

namespace Spatie\Menu\Laravel;

use Illuminate\Support\Traits\Macroable;
use Spatie\Menu\Link as BaseLink;

class Link extends BaseLink
{
    use Macroable;

    /**
     * @param string $path
     * @param string $text
     * @param array $parameters
     * @param bool|null $secure
     *
     * @return $this
     */
    public static function url(string $path, string $text, $parameters = [], $secure = null)
    {
        return static::to(url($path, $parameters, $secure), $text);

    }

    /**
     * @param string $action
     * @param string $text
     * @param array $parameters
     * @param bool $absolute
     *
     * @return $this
     */
    public static function action(string $action, string $text, $parameters = [], $absolute = true)
    {
        return static::to(action($action, $parameters, $absolute), $text);
    }

    /**
     * @param string $name
     * @param string $text
     * @param array $parameters
     * @param bool $absolute
     * @param \Illuminate\Routing\Route|null $route
     *
     * @return $this
     */
    public static function route(string $name, string $text, $parameters = [], $absolute = true, $route = null)
    {
        return static::to(route($name, $parameters, $absolute, $route), $text);
    }
}


1			<?php
2
3			namespace Spatie\Menu\Laravel;
4
5			use Illuminate\Support\Traits\Macroable;
6			use Spatie\Menu\Link as BaseLink;
7
8			class Link extends BaseLink
9			{
10			use Macroable;
11
12			/**
13			* @param string $path
14			* @param string $text
15			* @param array $parameters
16			* @param bool\|null $secure
17			*
18			* @return $this
19			*/
20			public static function url(string $path, string $text, $parameters = [], $secure = null)
21			{
22			return static::to(url($path, $parameters, $secure), $text);
			0 ignored issues – show Bug introduced 2016-03-18 09:48 UTC by Report Bug Copy Issue Report It seems like `url($path, $parameters, $secure)` targeting `url()` can also be of type `object<Illuminate\Contracts\Routing\UrlGenerator>`; however, `Spatie\Menu\Link::to()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
23			}
24
25			/**
26			* @param string $action
27			* @param string $text
28			* @param array $parameters
29			* @param bool $absolute
30			*
31			* @return $this
32			*/
33			public static function action(string $action, string $text, $parameters = [], $absolute = true)
34			{
35			return static::to(action($action, $parameters, $absolute), $text);
36			}
37
38			/**
39			* @param string $name
40			* @param string $text
41			* @param array $parameters
42			* @param bool $absolute
43			* @param \Illuminate\Routing\Route\|null $route
44			*
45			* @return $this
46			*/
47			public static function route(string $name, string $text, $parameters = [], $absolute = true, $route = null)
48			{
49			return static::to(route($name, $parameters, $absolute, $route), $text);
50			}
51			}
52

spatie / laravel-menu

Push — master ( 7f32b3...b1a367 )

Link::action() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like