MailableFactory::getArguments() - Code Metrics - spatie/laravel-mailable-test - Measure and Improve Code Quality continuously with Scrutinizer

MailableFactory::getArguments() A
last analyzed 2020-06-26 08:16 UTC

↳ Parent: MailableFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	2
dl	0
loc	16
rs	9.7333
c	0
b	0
f	0

<?php

namespace Spatie\MailableTest;

use Illuminate\Mail\Mailable;
use ReflectionClass;
use ReflectionParameter;

class MailableFactory
{
    /** @var \Spatie\MailableTest\FakerArgumentValueProvider */
    protected $argumentValueProvider;

    public function __construct(ArgumentValueProvider $argumentValueProvider)
    {
        $this->argumentValueProvider = $argumentValueProvider;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
    }

    public function getInstance(string $mailableClass, string $toEmail, $defaultValues): Mailable
    {
        $argumentValues = $this->getArguments($mailableClass, $defaultValues);

        $mailable = new $mailableClass(...$argumentValues);

        $mailable = $this->setRecipient($mailable, $toEmail);

        return $mailable;
    }

    public function getArguments(string $mailableClass, array $defaultValues)
    {
        $parameters = (new ReflectionClass($mailableClass))
            ->getConstructor()
            ->getParameters();

        return collect($parameters)
            ->map(function (ReflectionParameter $reflectionParameter) use ($mailableClass, $defaultValues) {
                return $this->argumentValueProvider->getValue(
                    $mailableClass,
                    $reflectionParameter->getName(),
                    $reflectionParameter->getType()->getName(),
                    $defaultValues[$reflectionParameter->getName()] ?? null
                );
            });
    }

    protected function setRecipient(Mailable $mailable, string $email): Mailable
    {
        $mailable->to($email);
        $mailable->cc([]);
        $mailable->bcc([]);

        return $mailable;
    }
}


1			<?php
2
3			namespace Spatie\MailableTest;
4
5			use Illuminate\Mail\Mailable;
6			use ReflectionClass;
7			use ReflectionParameter;
8
9			class MailableFactory
10			{
11			/** @var \Spatie\MailableTest\FakerArgumentValueProvider */
12			protected $argumentValueProvider;
13
14			public function __construct(ArgumentValueProvider $argumentValueProvider)
15			{
16			$this->argumentValueProvider = $argumentValueProvider;
			0 ignored issues – show Documentation Bug introduced 2017-01-30 13:08 UTC by Report Bug Copy Issue Report `$argumentValueProvider` is of type `object<Spatie\MailableTest\ArgumentValueProvider>`, but the property `$argumentValueProvider` was declared to be of type `object<Spatie\MailableTe...rArgumentValueProvider>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
17			}
18
19			public function getInstance(string $mailableClass, string $toEmail, $defaultValues): Mailable
20			{
21			$argumentValues = $this->getArguments($mailableClass, $defaultValues);
22
23			$mailable = new $mailableClass(...$argumentValues);
24
25			$mailable = $this->setRecipient($mailable, $toEmail);
26
27			return $mailable;
28			}
29
30			public function getArguments(string $mailableClass, array $defaultValues)
31			{
32			$parameters = (new ReflectionClass($mailableClass))
33			->getConstructor()
34			->getParameters();
35
36			return collect($parameters)
37			->map(function (ReflectionParameter $reflectionParameter) use ($mailableClass, $defaultValues) {
38			return $this->argumentValueProvider->getValue(
39			$mailableClass,
40			$reflectionParameter->getName(),
41			$reflectionParameter->getType()->getName(),
42			$defaultValues[$reflectionParameter->getName()] ?? null
43			);
44			});
45			}
46
47			protected function setRecipient(Mailable $mailable, string $email): Mailable
48			{
49			$mailable->to($email);
50			$mailable->cc([]);
51			$mailable->bcc([]);
52
53			return $mailable;
54			}
55			}
56

spatie / laravel-mailable-test

MailableFactory::getArguments() A last analyzed 2020-06-26 08:16 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

MailableFactory::getArguments() A
last analyzed 2020-06-26 08:16 UTC