Select::createOption() - Code Metrics - Inspection of "adding optional strict value checks for Select val..." - spatie/laravel-html - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#99)

unknown

created 2018-05-21 20:32 UTC

Select::createOption() A

↳ Parent: Select

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	10
nc	3
nop	3
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0

<?php

namespace Spatie\Html\Elements;

use Illuminate\Support\Str;
use Spatie\Html\Selectable;
use Spatie\Html\BaseElement;
use Illuminate\Support\Collection;

class Select extends BaseElement
{
    /** @var string */
    protected $tag = 'select';

    /** @var array */
    protected $options = [];

    /** @var string|iterable */
    protected $value = '';

    /**
     * @param bool $strict
     * @return static
     */
    public function multiple($strict = false)
    {
        $element = clone $this;

        $element = $element->attribute('multiple');

        $name = $element->getAttribute('name');

        if ($name && ! Str::endsWith($name, '[]')) {
            $element = $element->name($name.'[]');
        }

        $element->applyValueToOptions($strict);

        return $element;
    }

    /**
     * @param string|null $name
     *
     * @return static
     */
    public function name($name)
    {
        return $this->attribute('name', $name);
    }

    /**
     * @param iterable $options
     * @param bool $strict
     * @return static
     */
    public function options($options, $strict = false)
    {
        return $this->addChildren($options, function ($text, $value) use ($strict) {
            if (is_array($text)) {
                return $this->optgroup($value, $text, $strict);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }

            return $this->createOption($text, $value, $strict);
        });
    }

    /**
     * @param string $label
     * @param iterable $options
     * @param bool $strict
     *
     * @return static
     */
    public function optgroup($label, $options, $strict = false)
    {
        return Optgroup::create()
            ->label($label)
            ->addChildren($options, function ($text, $value) use ($strict) {
                return $this->createOption($text, $value, $strict);
            });

        return $this->addChild($optgroup);
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    /**
     * @param string|null $text
     *
     * @return static
     */
    public function placeholder($text)
    {
        return $this->prependChild(
            $this->createOption($text, null)
                ->selectedIf(! $this->hasSelection())
        );
    }

    /**
     * @return static
     */
    public function required()
    {
        return $this->attribute('required');
    }

    /**
     * @param string|iterable $value
     * @param bool $strict
     *
     * @return static
     */
    public function value($value = null, $strict = false)
    {
        $element = clone $this;

        $element->value = $value;

        $element->applyValueToOptions($strict);

        return $element;
    }

    protected function hasSelection()
    {
        return $this->children->contains->hasAttribute('selected');
    }

    protected function createOption($text, $value = null, $strict = false)
    {
        $selected = false;
        if (null !== $value) {
            $selected = $strict ?
                $value === $this->value :
                $value == $this->value;
        }

        return Option::create()
            ->value($value)
            ->text($text)
            ->selectedIf($selected);
    }

    protected function applyValueToOptions($strict = false)
    {
        $value = Collection::make($this->value);

        if (! $this->hasAttribute('multiple')) {
            $value = $value->take(1);
        }

        $this->children = $this->applyValueToElements($value, $this->children, $strict);
    }

    protected function applyValueToElements($value, Collection $children, $strict = false)
    {
        return $children->map(function ($child) use ($strict, $value) {
            if ($child instanceof Optgroup) {
                return $child->setChildren($this->applyValueToElements($value, $child->children, $strict));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }

            if ($child instanceof Selectable) {
                $attribute = $child->getAttribute('value');
                $contains = $strict ?
                    $value->containsStrict($attribute) :
                    $value->contains($attribute);

                return $child->selectedIf($contains);
            }

            return $child;
        });
    }
}


1			<?php
2
3			namespace Spatie\Html\Elements;
4
5			use Illuminate\Support\Str;
6			use Spatie\Html\Selectable;
7			use Spatie\Html\BaseElement;
8			use Illuminate\Support\Collection;
9
10			class Select extends BaseElement
11			{
12			/** @var string */
13			protected $tag = 'select';
14
15			/** @var array */
16			protected $options = [];
17
18			/** @var string\|iterable */
19			protected $value = '';
20
21			/**
22			* @param bool $strict
23			* @return static
24			*/
25			public function multiple($strict = false)
26			{
27			$element = clone $this;
28
29			$element = $element->attribute('multiple');
30
31			$name = $element->getAttribute('name');
32
33			if ($name && ! Str::endsWith($name, '[]')) {
34			$element = $element->name($name.'[]');
35			}
36
37			$element->applyValueToOptions($strict);
38
39			return $element;
40			}
41
42			/**
43			* @param string\|null $name
44			*
45			* @return static
46			*/
47			public function name($name)
48			{
49			return $this->attribute('name', $name);
50			}
51
52			/**
53			* @param iterable $options
54			* @param bool $strict
55			* @return static
56			*/
57			public function options($options, $strict = false)
58			{
59			return $this->addChildren($options, function ($text, $value) use ($strict) {
60			if (is_array($text)) {
61			return $this->optgroup($value, $text, $strict);
			0 ignored issues – show Documentation introduced 2018-05-21 20:42 UTC by Report Bug Copy Issue Report `$text` is of type `array`, but the function expects a `object<Spatie\Html\Elements\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
62			}
63
64			return $this->createOption($text, $value, $strict);
65			});
66			}
67
68			/**
69			* @param string $label
70			* @param iterable $options
71			* @param bool $strict
72			*
73			* @return static
74			*/
75			public function optgroup($label, $options, $strict = false)
76			{
77			return Optgroup::create()
78			->label($label)
79			->addChildren($options, function ($text, $value) use ($strict) {
80			return $this->createOption($text, $value, $strict);
81			});
82
83			return $this->addChild($optgroup);
			0 ignored issues – show Unused Code introduced 2017-08-29 07:57 UTC by Report Bug Copy Issue Report `return $this->addChild($optgroup);` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
84			}
85
86			/**
87			* @param string\|null $text
88			*
89			* @return static
90			*/
91			public function placeholder($text)
92			{
93			return $this->prependChild(
94			$this->createOption($text, null)
95			->selectedIf(! $this->hasSelection())
96			);
97			}
98
99			/**
100			* @return static
101			*/
102			public function required()
103			{
104			return $this->attribute('required');
105			}
106
107			/**
108			* @param string\|iterable $value
109			* @param bool $strict
110			*
111			* @return static
112			*/
113			public function value($value = null, $strict = false)
114			{
115			$element = clone $this;
116
117			$element->value = $value;
118
119			$element->applyValueToOptions($strict);
120
121			return $element;
122			}
123
124			protected function hasSelection()
125			{
126			return $this->children->contains->hasAttribute('selected');
127			}
128
129			protected function createOption($text, $value = null, $strict = false)
130			{
131			$selected = false;
132			if (null !== $value) {
133			$selected = $strict ?
134			$value === $this->value :
135			$value == $this->value;
136			}
137
138			return Option::create()
139			->value($value)
140			->text($text)
141			->selectedIf($selected);
142			}
143
144			protected function applyValueToOptions($strict = false)
145			{
146			$value = Collection::make($this->value);
147
148			if (! $this->hasAttribute('multiple')) {
149			$value = $value->take(1);
150			}
151
152			$this->children = $this->applyValueToElements($value, $this->children, $strict);
153			}
154
155			protected function applyValueToElements($value, Collection $children, $strict = false)
156			{
157			return $children->map(function ($child) use ($strict, $value) {
158			if ($child instanceof Optgroup) {
159			return $child->setChildren($this->applyValueToElements($value, $child->children, $strict));
			0 ignored issues – show Bug introduced 2017-10-11 10:45 UTC by Report Bug Copy Issue Report The property `children` cannot be accessed from this context as it is declared `protected` in class `Spatie\Html\BaseElement`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history... Documentation introduced 2018-05-21 20:42 UTC by Report Bug Copy Issue Report `$this->applyValueToEleme...ild->children, $strict)` is of type `object<Illuminate\Support\Collection>`, but the function expects a `array<integer,object<Spatie\Html\HtmlElement>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
160			}
161
162			if ($child instanceof Selectable) {
163			$attribute = $child->getAttribute('value');
164			$contains = $strict ?
165			$value->containsStrict($attribute) :
166			$value->contains($attribute);
167
168			return $child->selectedIf($contains);
169			}
170
171			return $child;
172			});
173			}
174			}
175

spatie / laravel-html

Pull Request — master (#99)

Select::createOption() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like