Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Html often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Html, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
28 | class Html |
||
29 | { |
||
30 | use Macroable; |
||
31 | |||
32 | const HTML_DATE_FORMAT = 'Y-m-d'; |
||
33 | const HTML_TIME_FORMAT = 'H:i:s'; |
||
34 | |||
35 | /** @var \Illuminate\Http\Request */ |
||
36 | protected $request; |
||
37 | |||
38 | /** @var \ArrayAccess|array */ |
||
39 | protected $model; |
||
40 | |||
41 | public function __construct(Request $request) |
||
45 | |||
46 | /** |
||
47 | * @param string|null $href |
||
48 | * @param string|null $text |
||
49 | * |
||
50 | * @return \Spatie\Html\Elements\A |
||
51 | */ |
||
52 | public function a($href = null, $contents = null) |
||
58 | |||
59 | /** |
||
60 | * @param string|null $href |
||
61 | * @param string|null $text |
||
62 | * |
||
63 | * @return \Spatie\Html\Elements\I |
||
64 | */ |
||
65 | public function i($contents = null) |
||
70 | |||
71 | /** |
||
72 | * @param string|null $type |
||
73 | * @param string|null $text |
||
74 | * |
||
75 | * @return \Spatie\Html\Elements\Button |
||
76 | */ |
||
77 | public function button($contents = null, $type = null, $name = null) |
||
84 | |||
85 | /** |
||
86 | * @param \Illuminate\Support\Collection|iterable|string $classes |
||
87 | * |
||
88 | * @return \Illuminate\Contracts\Support\Htmlable |
||
89 | */ |
||
90 | public function class($classes): Htmlable |
||
103 | |||
104 | /** |
||
105 | * @param string|null $name |
||
106 | * @param bool $checked |
||
107 | * @param string|null $value |
||
108 | * |
||
109 | * @return \Spatie\Html\Elements\Input |
||
110 | */ |
||
111 | public function checkbox($name = null, $checked = null, $value = '1') |
||
117 | |||
118 | /** |
||
119 | * @param \Spatie\Html\HtmlElement|string|null $contents |
||
120 | * |
||
121 | * @return \Spatie\Html\Elements\Div |
||
122 | */ |
||
123 | public function div($contents = null) |
||
127 | |||
128 | /** |
||
129 | * @param string|null $name |
||
130 | * @param string|null $value |
||
131 | * |
||
132 | * @return \Spatie\Html\Elements\Input |
||
133 | */ |
||
134 | public function email($name = null, $value = null) |
||
138 | |||
139 | /** |
||
140 | * @param string|null $name |
||
141 | * @param string|null $value |
||
142 | * @param bool $format |
||
143 | * |
||
144 | * @return \Spatie\Html\Elements\Input |
||
145 | */ |
||
146 | View Code Duplication | public function date($name = '', $value = null, $format = true) |
|
156 | |||
157 | /** |
||
158 | * @param string|null $name |
||
159 | * @param string|null $value |
||
160 | * @param string|null $min |
||
161 | * @param string|null $max |
||
162 | * @param string|null $step |
||
163 | * |
||
164 | * @return \Spatie\Html\Elements\Input |
||
165 | */ |
||
166 | public function range($name = '', $value = '', $min = null, $max = null, $step = null) |
||
173 | |||
174 | /** |
||
175 | * @param string|null $name |
||
176 | * @param string|null $value |
||
177 | * @param bool $format |
||
178 | * |
||
179 | * @return \Spatie\Html\Elements\Input |
||
180 | */ |
||
181 | View Code Duplication | public function time($name = '', $value = null, $format = true) |
|
191 | |||
192 | /** |
||
193 | * @param string $tag |
||
194 | * |
||
195 | * @return \Spatie\Html\Elements\Element |
||
196 | */ |
||
197 | public function element($tag) |
||
201 | |||
202 | /** |
||
203 | * @param string|null $type |
||
204 | * @param string|null $name |
||
205 | * @param string|null $value |
||
206 | * |
||
207 | * @return \Spatie\Html\Elements\Input |
||
208 | */ |
||
209 | public function input($type = null, $name = null, $value = null) |
||
219 | |||
220 | /** |
||
221 | * @param \Spatie\Html\HtmlElement|string|null $legend |
||
222 | * |
||
223 | * @return \Spatie\Html\Elements\Fieldset |
||
224 | */ |
||
225 | public function fieldset($legend = null) |
||
231 | |||
232 | /** |
||
233 | * @param string $method |
||
234 | * @param string|null $action |
||
235 | * |
||
236 | * @return \Spatie\Html\Elements\Form |
||
237 | */ |
||
238 | public function form($method = 'POST', $action = null) |
||
258 | |||
259 | /** |
||
260 | * @param string|null $name |
||
261 | * @param string|null $value |
||
262 | * |
||
263 | * @return \Spatie\Html\Elements\Input |
||
264 | */ |
||
265 | public function hidden($name = null, $value = null) |
||
269 | |||
270 | /** |
||
271 | * @param string|null $src |
||
272 | * @param string|null $alt |
||
273 | * |
||
274 | * @return \Spatie\Html\Elements\Img |
||
275 | */ |
||
276 | public function img($src = null, $alt = null) |
||
282 | |||
283 | /** |
||
284 | * @param \Spatie\Html\HtmlElement|iterable|string|null $contents |
||
285 | * @param string|null $for |
||
286 | * |
||
287 | * @return \Spatie\Html\Elements\Label |
||
288 | */ |
||
289 | public function label($contents = null, $for = null) |
||
295 | |||
296 | /** |
||
297 | * @param \Spatie\Html\HtmlElement|string|null $contents |
||
298 | * |
||
299 | * @return \Spatie\Html\Elements\Legend |
||
300 | */ |
||
301 | public function legend($contents = null) |
||
305 | |||
306 | /** |
||
307 | * @param string $email |
||
308 | * @param string|null $text |
||
309 | * |
||
310 | * @return \Spatie\Html\Elements\A |
||
311 | */ |
||
312 | public function mailto($email, $text = null) |
||
316 | |||
317 | /** |
||
318 | * @param string|null $name |
||
319 | * @param iterable $options |
||
320 | * @param string|iterable|null $value |
||
321 | * |
||
322 | * @return \Spatie\Html\Elements\Select |
||
323 | */ |
||
324 | View Code Duplication | public function multiselect($name = null, $options = [], $value = null) |
|
333 | |||
334 | /** |
||
335 | * @param string|null $text |
||
336 | * @param string|null $value |
||
337 | * @param bool $selected |
||
338 | * |
||
339 | * @return \Spatie\Html\Elements\Option |
||
340 | */ |
||
341 | public function option($text = null, $value = null, $selected = false) |
||
348 | |||
349 | /** |
||
350 | * @param string|null $value |
||
351 | * |
||
352 | * @return \Spatie\Html\Elements\Input |
||
353 | */ |
||
354 | public function password($name = null) |
||
358 | |||
359 | /** |
||
360 | * @param string|null $name |
||
361 | * @param bool $checked |
||
362 | * @param string|null $value |
||
363 | * |
||
364 | * @return \Spatie\Html\Elements\Input |
||
365 | */ |
||
366 | public function radio($name = null, $checked = null, $value = null) |
||
373 | |||
374 | /** |
||
375 | * @param string|null $name |
||
376 | * @param iterable $options |
||
377 | * @param string|iterable|null $value |
||
378 | * |
||
379 | * @return \Spatie\Html\Elements\Select |
||
380 | */ |
||
381 | View Code Duplication | public function select($name = null, $options = [], $value = null) |
|
389 | |||
390 | /** |
||
391 | * @param \Spatie\Html\HtmlElement|string|null $contents |
||
392 | * |
||
393 | * @return \Spatie\Html\Elements\Span |
||
394 | */ |
||
395 | public function span($contents = null) |
||
399 | |||
400 | /** |
||
401 | * @param string|null $text |
||
402 | * |
||
403 | * @return \Spatie\Html\Elements\Button |
||
404 | */ |
||
405 | public function submit($text = null) |
||
409 | |||
410 | /** |
||
411 | * @param string|null $text |
||
412 | * |
||
413 | * @return \Spatie\Html\Elements\Button |
||
414 | */ |
||
415 | public function reset($text = null) |
||
419 | |||
420 | /** |
||
421 | * @param string $number |
||
422 | * @param string|null $text |
||
423 | * |
||
424 | * @return \Spatie\Html\Elements\A |
||
425 | */ |
||
426 | public function tel($number, $text = null) |
||
430 | |||
431 | /** |
||
432 | * @param string|null $name |
||
433 | * @param string|null $value |
||
434 | * |
||
435 | * @return \Spatie\Html\Elements\Input |
||
436 | */ |
||
437 | public function text($name = null, $value = null) |
||
441 | |||
442 | /** |
||
443 | * @param string|null $name |
||
444 | * |
||
445 | * @return \Spatie\Html\Elements\File |
||
446 | */ |
||
447 | public function file($name = null) |
||
453 | |||
454 | /** |
||
455 | * @param string|null $name |
||
456 | * @param string|null $value |
||
457 | * |
||
458 | * @return \Spatie\Html\Elements\Textarea |
||
459 | */ |
||
460 | public function textarea($name = null, $value = null) |
||
467 | |||
468 | /** |
||
469 | * @return \Spatie\Html\Elements\Input |
||
470 | */ |
||
471 | public function token() |
||
478 | |||
479 | /** |
||
480 | * @param \ArrayAccess|array $model |
||
481 | * |
||
482 | * @return $this |
||
483 | */ |
||
484 | public function model($model) |
||
490 | |||
491 | /** |
||
492 | * @param \ArrayAccess|array $model |
||
493 | * @param string|null $method |
||
494 | * @param string|null $action |
||
495 | * |
||
496 | * @return \Spatie\Html\Elements\Form |
||
497 | */ |
||
498 | public function modelForm($model, $method = 'POST', $action = null): Form |
||
504 | |||
505 | /** |
||
506 | * @return $this |
||
507 | */ |
||
508 | public function endModel() |
||
514 | |||
515 | /** |
||
516 | * @return \Illuminate\Contracts\Support\Htmlable |
||
517 | */ |
||
518 | public function closeModelForm(): Htmlable |
||
524 | |||
525 | /** |
||
526 | * @param string $name |
||
527 | * @param mixed $value |
||
528 | * |
||
529 | * @return mixed |
||
530 | */ |
||
531 | protected function old($name, $value = null) |
||
549 | |||
550 | /** |
||
551 | * Retrieve the value from the current session or assigned model. This is |
||
552 | * a public alias for `old`. |
||
553 | * |
||
554 | * @param string $name |
||
555 | * @param mixed $value |
||
556 | * |
||
557 | * @return mixed |
||
558 | */ |
||
559 | public function value($name, $default = null) |
||
563 | |||
564 | /** |
||
565 | * @param string $name |
||
566 | * |
||
567 | * @return string |
||
568 | */ |
||
569 | protected function fieldName($name) |
||
573 | |||
574 | protected function ensureModelIsAvailable() |
||
580 | |||
581 | /** |
||
582 | * @param string $value |
||
583 | * @param string $format DateTime formatting string supported by date_format() |
||
584 | * @return string |
||
585 | */ |
||
586 | protected function formatDateTime($value, $format) |
||
600 | } |
||
601 |