Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Html often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Html, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
29 | class Html |
||
30 | { |
||
31 | use Macroable; |
||
32 | |||
33 | const HTML_DATE_FORMAT = 'Y-m-d'; |
||
34 | const HTML_TIME_FORMAT = 'H:i:s'; |
||
35 | |||
36 | /** @var \Illuminate\Http\Request */ |
||
37 | protected $request; |
||
38 | |||
39 | /** @var \ArrayAccess|array */ |
||
40 | protected $model; |
||
41 | |||
42 | public function __construct(Request $request) |
||
46 | |||
47 | /** |
||
48 | * @param string|null $href |
||
49 | * @param string|null $text |
||
50 | * |
||
51 | * @return \Spatie\Html\Elements\A |
||
52 | */ |
||
53 | public function a($href = null, $contents = null) |
||
59 | |||
60 | /** |
||
61 | * @param string|null $href |
||
62 | * @param string|null $text |
||
63 | * |
||
64 | * @return \Spatie\Html\Elements\I |
||
65 | */ |
||
66 | public function i($contents = null) |
||
71 | |||
72 | /** |
||
73 | * @param string|null $type |
||
74 | * @param string|null $text |
||
75 | * |
||
76 | * @return \Spatie\Html\Elements\Button |
||
77 | */ |
||
78 | public function button($contents = null, $type = null, $name = null) |
||
85 | |||
86 | /** |
||
87 | * @param \Illuminate\Support\Collection|iterable|string $classes |
||
88 | * |
||
89 | * @return \Illuminate\Contracts\Support\Htmlable |
||
90 | */ |
||
91 | public function class($classes): Htmlable |
||
104 | |||
105 | /** |
||
106 | * @param string|null $name |
||
107 | * @param bool $checked |
||
108 | * @param string|null $value |
||
109 | * |
||
110 | * @return \Spatie\Html\Elements\Input |
||
111 | */ |
||
112 | public function checkbox($name = null, $checked = null, $value = '1') |
||
118 | |||
119 | /** |
||
120 | * @param \Spatie\Html\HtmlElement|string|null $contents |
||
121 | * |
||
122 | * @return \Spatie\Html\Elements\Div |
||
123 | */ |
||
124 | public function div($contents = null) |
||
128 | |||
129 | /** |
||
130 | * @param string|null $name |
||
131 | * @param string|null $value |
||
132 | * |
||
133 | * @return \Spatie\Html\Elements\Input |
||
134 | */ |
||
135 | public function email($name = null, $value = null) |
||
139 | |||
140 | /** |
||
141 | * @param string|null $name |
||
142 | * @param string|null $value |
||
143 | * @param bool $format |
||
144 | * |
||
145 | * @return \Spatie\Html\Elements\Input |
||
146 | */ |
||
147 | View Code Duplication | public function date($name = '', $value = null, $format = true) |
|
157 | |||
158 | /** |
||
159 | * @param string|null $name |
||
160 | * @param string|null $value |
||
161 | * @param bool $format |
||
162 | * |
||
163 | * @return \Spatie\Html\Elements\Input |
||
164 | */ |
||
165 | View Code Duplication | public function datetime($name = '', $value = null, $format = true) |
|
176 | |||
177 | /** |
||
178 | * @param string|null $name |
||
179 | * @param string|null $value |
||
180 | * @param string|null $min |
||
181 | * @param string|null $max |
||
182 | * @param string|null $step |
||
183 | * |
||
184 | * @return \Spatie\Html\Elements\Input |
||
185 | */ |
||
186 | public function range($name = '', $value = '', $min = null, $max = null, $step = null) |
||
193 | |||
194 | /** |
||
195 | * @param string|null $name |
||
196 | * @param string|null $value |
||
197 | * @param bool $format |
||
198 | * |
||
199 | * @return \Spatie\Html\Elements\Input |
||
200 | */ |
||
201 | View Code Duplication | public function time($name = '', $value = null, $format = true) |
|
211 | |||
212 | /** |
||
213 | * @param string $tag |
||
214 | * |
||
215 | * @return \Spatie\Html\Elements\Element |
||
216 | */ |
||
217 | public function element($tag) |
||
221 | |||
222 | /** |
||
223 | * @param string|null $type |
||
224 | * @param string|null $name |
||
225 | * @param string|null $value |
||
226 | * |
||
227 | * @return \Spatie\Html\Elements\Input |
||
228 | */ |
||
229 | public function input($type = null, $name = null, $value = null) |
||
239 | |||
240 | /** |
||
241 | * @param \Spatie\Html\HtmlElement|string|null $legend |
||
242 | * |
||
243 | * @return \Spatie\Html\Elements\Fieldset |
||
244 | */ |
||
245 | public function fieldset($legend = null) |
||
250 | |||
251 | /** |
||
252 | * @param string $method |
||
253 | * @param string|null $action |
||
254 | * |
||
255 | * @return \Spatie\Html\Elements\Form |
||
256 | */ |
||
257 | public function form($method = 'POST', $action = null) |
||
277 | |||
278 | /** |
||
279 | * @param string|null $name |
||
280 | * @param string|null $value |
||
281 | * |
||
282 | * @return \Spatie\Html\Elements\Input |
||
283 | */ |
||
284 | public function hidden($name = null, $value = null) |
||
288 | |||
289 | /** |
||
290 | * @param string|null $src |
||
291 | * @param string|null $alt |
||
292 | * |
||
293 | * @return \Spatie\Html\Elements\Img |
||
294 | */ |
||
295 | public function img($src = null, $alt = null) |
||
301 | |||
302 | /** |
||
303 | * @param \Spatie\Html\HtmlElement|iterable|string|null $contents |
||
304 | * @param string|null $for |
||
305 | * |
||
306 | * @return \Spatie\Html\Elements\Label |
||
307 | */ |
||
308 | public function label($contents = null, $for = null) |
||
314 | |||
315 | /** |
||
316 | * @param \Spatie\Html\HtmlElement|string|null $contents |
||
317 | * |
||
318 | * @return \Spatie\Html\Elements\Legend |
||
319 | */ |
||
320 | public function legend($contents = null) |
||
324 | |||
325 | /** |
||
326 | * @param string $email |
||
327 | * @param string|null $text |
||
328 | * |
||
329 | * @return \Spatie\Html\Elements\A |
||
330 | */ |
||
331 | public function mailto($email, $text = null) |
||
335 | |||
336 | /** |
||
337 | * @param string|null $name |
||
338 | * @param iterable $options |
||
339 | * @param string|iterable|null $value |
||
340 | * |
||
341 | * @return \Spatie\Html\Elements\Select |
||
342 | */ |
||
343 | View Code Duplication | public function multiselect($name = null, $options = [], $value = null) |
|
352 | |||
353 | /** |
||
354 | * @param string|null $name |
||
355 | * @param string|null $value |
||
356 | * @param string|null $min |
||
357 | * @param string|null $max |
||
358 | * @param string|null $step |
||
359 | * |
||
360 | * @return \Spatie\Html\Elements\Input |
||
361 | */ |
||
362 | public function number($name = null, $value = null, $min = null, $max = null, $step = null) |
||
369 | |||
370 | /** |
||
371 | * @param string|null $text |
||
372 | * @param string|null $value |
||
373 | * @param bool $selected |
||
374 | * |
||
375 | * @return \Spatie\Html\Elements\Option |
||
376 | */ |
||
377 | public function option($text = null, $value = null, $selected = false) |
||
384 | |||
385 | /** |
||
386 | * @param string|null $value |
||
387 | * |
||
388 | * @return \Spatie\Html\Elements\Input |
||
389 | */ |
||
390 | public function password($name = null) |
||
394 | |||
395 | /** |
||
396 | * @param string|null $name |
||
397 | * @param bool $checked |
||
398 | * @param string|null $value |
||
399 | * |
||
400 | * @return \Spatie\Html\Elements\Input |
||
401 | */ |
||
402 | public function radio($name = null, $checked = null, $value = null) |
||
409 | |||
410 | /** |
||
411 | * @param string|null $name |
||
412 | * @param iterable $options |
||
413 | * @param string|iterable|null $value |
||
414 | * |
||
415 | * @return \Spatie\Html\Elements\Select |
||
416 | */ |
||
417 | View Code Duplication | public function select($name = null, $options = [], $value = null) |
|
425 | |||
426 | /** |
||
427 | * @param \Spatie\Html\HtmlElement|string|null $contents |
||
428 | * |
||
429 | * @return \Spatie\Html\Elements\Span |
||
430 | */ |
||
431 | public function span($contents = null) |
||
435 | |||
436 | /** |
||
437 | * @param string|null $text |
||
438 | * |
||
439 | * @return \Spatie\Html\Elements\Button |
||
440 | */ |
||
441 | public function submit($text = null) |
||
445 | |||
446 | /** |
||
447 | * @param string|null $text |
||
448 | * |
||
449 | * @return \Spatie\Html\Elements\Button |
||
450 | */ |
||
451 | public function reset($text = null) |
||
455 | |||
456 | /** |
||
457 | * @param string $number |
||
458 | * @param string|null $text |
||
459 | * |
||
460 | * @return \Spatie\Html\Elements\A |
||
461 | */ |
||
462 | public function tel($number, $text = null) |
||
466 | |||
467 | /** |
||
468 | * @param string|null $name |
||
469 | * @param string|null $value |
||
470 | * |
||
471 | * @return \Spatie\Html\Elements\Input |
||
472 | */ |
||
473 | public function text($name = null, $value = null) |
||
477 | |||
478 | /** |
||
479 | * @param string|null $name |
||
480 | * |
||
481 | * @return \Spatie\Html\Elements\File |
||
482 | */ |
||
483 | public function file($name = null) |
||
489 | |||
490 | /** |
||
491 | * @param string|null $name |
||
492 | * @param string|null $value |
||
493 | * |
||
494 | * @return \Spatie\Html\Elements\Textarea |
||
495 | */ |
||
496 | public function textarea($name = null, $value = null) |
||
503 | |||
504 | /** |
||
505 | * @return \Spatie\Html\Elements\Input |
||
506 | */ |
||
507 | public function token() |
||
514 | |||
515 | /** |
||
516 | * @param \ArrayAccess|array $model |
||
517 | * |
||
518 | * @return $this |
||
519 | */ |
||
520 | public function model($model) |
||
526 | |||
527 | /** |
||
528 | * @param \ArrayAccess|array $model |
||
529 | * @param string|null $method |
||
530 | * @param string|null $action |
||
531 | * |
||
532 | * @return \Spatie\Html\Elements\Form |
||
533 | */ |
||
534 | public function modelForm($model, $method = 'POST', $action = null): Form |
||
540 | |||
541 | /** |
||
542 | * @return $this |
||
543 | */ |
||
544 | public function endModel() |
||
550 | |||
551 | /** |
||
552 | * @return \Illuminate\Contracts\Support\Htmlable |
||
553 | */ |
||
554 | public function closeModelForm(): Htmlable |
||
560 | |||
561 | /** |
||
562 | * @param string $name |
||
563 | * @param mixed $value |
||
564 | * |
||
565 | * @return mixed |
||
566 | */ |
||
567 | protected function old($name, $value = null) |
||
585 | |||
586 | /** |
||
587 | * Retrieve the value from the current session or assigned model. This is |
||
588 | * a public alias for `old`. |
||
589 | * |
||
590 | * @param string $name |
||
591 | * @param mixed $value |
||
592 | * |
||
593 | * @return mixed |
||
594 | */ |
||
595 | public function value($name, $default = null) |
||
599 | |||
600 | /** |
||
601 | * @param string $name |
||
602 | * |
||
603 | * @return string |
||
604 | */ |
||
605 | protected function fieldName($name) |
||
609 | |||
610 | protected function ensureModelIsAvailable() |
||
616 | |||
617 | /** |
||
618 | * @param string $value |
||
619 | * @param string $format DateTime formatting string supported by date_format() |
||
620 | * @return string |
||
621 | */ |
||
622 | protected function formatDateTime($value, $format) |
||
636 | } |
||
637 |