ProtectAgainstSpam::handle() - Code Metrics - Inspection of "Merge pull request #63 from timmoh/master" - spatie/laravel-honeypot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1defc9...4b1f21 )

unknown

created 2020-09-08 16:18 UTC

ProtectAgainstSpam::handle() C

↳ Parent: ProtectAgainstSpam

Complexity

Conditions	12
Paths	20

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	49
rs	6.9666
c	0
b	0
f	0
cc	12
nc	20
nop	2

How to fix Complexity

<?php

namespace Spatie\Honeypot;

use Closure;
use Exception;
use Illuminate\Http\Request;
use Illuminate\Support\Str;
use Spatie\Honeypot\SpamResponder\SpamResponder;
use Symfony\Component\HttpFoundation\Response;

class ProtectAgainstSpam
{

    /** @var \Spatie\Honeypot\SpamResponder\SpamResponder */
    protected $spamResponder;

    public function __construct(SpamResponder $spamResponder)
    {
        $this->spamResponder = $spamResponder;
    }

    public function handle(Request $request, Closure $next): Response
    {
        if (! config('honeypot.enabled')) {
            return $next($request);
        }

        if (! $request->isMethod('POST')) {
            return $next($request);
        }

        $nameFieldName = config('honeypot.name_field_name');

        if (config('honeypot.randomize_name_field_name')) {
            $nameFieldName = $this->getRandomizedNameFieldName($nameFieldName, $request->all());
        }

        if (! $this->shouldCheckHoneypot($request, $nameFieldName)) {
            return $next($request);
        }

        if (! $request->has($nameFieldName)) {
            return $this->respondToSpam($request, $next);
        }

        $honeypotValue = $request->get($nameFieldName);

        if (! empty($honeypotValue)) {
            return $this->respondToSpam($request, $next);
        }

        if (config('honeypot.valid_from_timestamp')) {
            $validFrom = $request->get(config('honeypot.valid_from_field_name'));

            if (! $validFrom) {
                return $this->respondToSpam($request, $next);
            }

            try {
                $time = new EncryptedTime($validFrom);
            } catch (Exception $decryptException) {
                $time = null;
            }

            if (! $time || $time->isFuture()) {
                return $this->respondToSpam($request, $next);
            }
        }
        return $next($request);
    }

    private function getRandomizedNameFieldName($nameFieldName, $requestFields): ?string
    {
        return collect($requestFields)->filter(function ($value, $key) use ($nameFieldName) {
            return Str::startsWith($key, $nameFieldName);
        })->keys()->first();
    }

    protected function respondToSpam(Request $request, Closure $next): Response
    {
        event(new SpamDetected($request));

        return $this->spamResponder->respond($request, $next);
    }

    private function shouldCheckHoneypot(Request $request, ?string $nameFieldName): bool
    {
        if (config('honeypot.honeypot_fields_required_for_all_forms') == true) {
            return true;
        }

        return $request->has($nameFieldName) || $request->has(config('honeypot.valid_from_field_name'));
    }
}


1			<?php
2
3			namespace Spatie\Honeypot;
4
5			use Closure;
6			use Exception;
7			use Illuminate\Http\Request;
8			use Illuminate\Support\Str;
9			use Spatie\Honeypot\SpamResponder\SpamResponder;
10			use Symfony\Component\HttpFoundation\Response;
11
12			class ProtectAgainstSpam
13			{
14
15			/** @var \Spatie\Honeypot\SpamResponder\SpamResponder */
16			protected $spamResponder;
17
18			public function __construct(SpamResponder $spamResponder)
19			{
20			$this->spamResponder = $spamResponder;
21			}
22
23			public function handle(Request $request, Closure $next): Response
24			{
25			if (! config('honeypot.enabled')) {
26			return $next($request);
27			}
28
29			if (! $request->isMethod('POST')) {
30			return $next($request);
31			}
32
33			$nameFieldName = config('honeypot.name_field_name');
34
35			if (config('honeypot.randomize_name_field_name')) {
36			$nameFieldName = $this->getRandomizedNameFieldName($nameFieldName, $request->all());
37			}
38
39			if (! $this->shouldCheckHoneypot($request, $nameFieldName)) {
40			return $next($request);
41			}
42
43			if (! $request->has($nameFieldName)) {
44			return $this->respondToSpam($request, $next);
45			}
46
47			$honeypotValue = $request->get($nameFieldName);
48
49			if (! empty($honeypotValue)) {
50			return $this->respondToSpam($request, $next);
51			}
52
53			if (config('honeypot.valid_from_timestamp')) {
54			$validFrom = $request->get(config('honeypot.valid_from_field_name'));
55
56			if (! $validFrom) {
57			return $this->respondToSpam($request, $next);
58			}
59
60			try {
61			$time = new EncryptedTime($validFrom);
62			} catch (Exception $decryptException) {
63			$time = null;
64			}
65
66			if (! $time \|\| $time->isFuture()) {
67			return $this->respondToSpam($request, $next);
68			}
69			}
70			return $next($request);
71			}
72
73			private function getRandomizedNameFieldName($nameFieldName, $requestFields): ?string
74			{
75			return collect($requestFields)->filter(function ($value, $key) use ($nameFieldName) {
76			return Str::startsWith($key, $nameFieldName);
77			})->keys()->first();
78			}
79
80			protected function respondToSpam(Request $request, Closure $next): Response
81			{
82			event(new SpamDetected($request));
83
84			return $this->spamResponder->respond($request, $next);
85			}
86
87			private function shouldCheckHoneypot(Request $request, ?string $nameFieldName): bool
88			{
89			if (config('honeypot.honeypot_fields_required_for_all_forms') == true) {
90			return true;
91			}
92
93			return $request->has($nameFieldName) \|\| $request->has(config('honeypot.valid_from_field_name'));
94			}
95			}
96

spatie / laravel-honeypot

Push — master ( 1defc9...4b1f21 )

ProtectAgainstSpam::handle() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like