ProtectAgainstSpam::handle() - Code Metrics - Inspection of "add option to skip timestamp check" - spatie/laravel-honeypot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#63)

unknown

created 2020-08-17 10:42 UTC

ProtectAgainstSpam::handle() C

↳ Parent: ProtectAgainstSpam

Complexity

Conditions	12
Paths	20

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	48
rs	6.9666
c	0
b	0
f	0
cc	12
nc	20
nop	2

How to fix Complexity

<?php

namespace Spatie\Honeypot;

use Closure;
use Exception;
use Illuminate\Http\Request;
use Illuminate\Support\Str;
use Spatie\Honeypot\SpamResponder\SpamResponder;
use Symfony\Component\HttpFoundation\Response;

class ProtectAgainstSpam {

    /** @var \Spatie\Honeypot\SpamResponder\SpamResponder */
    protected $spamResponder;

    public function __construct(SpamResponder $spamResponder) {
        $this->spamResponder = $spamResponder;
    }

    public function handle(Request $request, Closure $next): Response {
        if (!config('honeypot.enabled')) {
            return $next($request);
        }

        if (!$request->isMethod('POST')) {
            return $next($request);
        }

        $nameFieldName = config('honeypot.name_field_name');

        if (config('honeypot.randomize_name_field_name')) {
            $nameFieldName = $this->getRandomizedNameFieldName($nameFieldName, $request->all());
        }

        if (!$this->shouldCheckHoneypot($request, $nameFieldName)) {
            return $next($request);
        }

        if (!$request->has($nameFieldName)) {
            return $this->respondToSpam($request, $next);
        }

        $honeypotValue = $request->get($nameFieldName);

        if (!empty($honeypotValue)) {
            return $this->respondToSpam($request, $next);
        }

        $validFrom = $request->get(config('honeypot.valid_from_field_name'));

        if (!$validFrom) {
            return $this->respondToSpam($request, $next);
        }

        if (config('honeypot.valid_from_timestamp')) {
            try {
                $time = new EncryptedTime($validFrom);
            } catch (Exception $decryptException) {
                $time = null;
            }

            if (!$time || $time->isFuture()) {
                return $this->respondToSpam($request, $next);
            }
        }
        return $next($request);
    }

    private function getRandomizedNameFieldName($nameFieldName, $requestFields): ?string {
        return collect($requestFields)->filter(function ($value, $key) use ($nameFieldName) {
            return Str::startsWith($key, $nameFieldName);
        })->keys()->first();
    }

    protected function respondToSpam(Request $request, Closure $next): Response {
        event(new SpamDetected($request));

        return $this->spamResponder->respond($request, $next);
    }

    private function shouldCheckHoneypot(Request $request, ?string $nameFieldName): bool {
        if (config('honeypot.honeypot_fields_required_for_all_forms') == true) {
            return true;
        }

        return $request->has($nameFieldName) || $request->has(config('honeypot.valid_from_field_name'));
    }
}


1			<?php
2
3			namespace Spatie\Honeypot;
4
5			use Closure;
6			use Exception;
7			use Illuminate\Http\Request;
8			use Illuminate\Support\Str;
9			use Spatie\Honeypot\SpamResponder\SpamResponder;
10			use Symfony\Component\HttpFoundation\Response;
11
12			class ProtectAgainstSpam {
13
14			/** @var \Spatie\Honeypot\SpamResponder\SpamResponder */
15			protected $spamResponder;
16
17			public function __construct(SpamResponder $spamResponder) {
18			$this->spamResponder = $spamResponder;
19			}
20
21			public function handle(Request $request, Closure $next): Response {
22			if (!config('honeypot.enabled')) {
23			return $next($request);
24			}
25
26			if (!$request->isMethod('POST')) {
27			return $next($request);
28			}
29
30			$nameFieldName = config('honeypot.name_field_name');
31
32			if (config('honeypot.randomize_name_field_name')) {
33			$nameFieldName = $this->getRandomizedNameFieldName($nameFieldName, $request->all());
34			}
35
36			if (!$this->shouldCheckHoneypot($request, $nameFieldName)) {
37			return $next($request);
38			}
39
40			if (!$request->has($nameFieldName)) {
41			return $this->respondToSpam($request, $next);
42			}
43
44			$honeypotValue = $request->get($nameFieldName);
45
46			if (!empty($honeypotValue)) {
47			return $this->respondToSpam($request, $next);
48			}
49
50			$validFrom = $request->get(config('honeypot.valid_from_field_name'));
51
52			if (!$validFrom) {
53			return $this->respondToSpam($request, $next);
54			}
55
56			if (config('honeypot.valid_from_timestamp')) {
57			try {
58			$time = new EncryptedTime($validFrom);
59			} catch (Exception $decryptException) {
60			$time = null;
61			}
62
63			if (!$time \|\| $time->isFuture()) {
64			return $this->respondToSpam($request, $next);
65			}
66			}
67			return $next($request);
68			}
69
70			private function getRandomizedNameFieldName($nameFieldName, $requestFields): ?string {
71			return collect($requestFields)->filter(function ($value, $key) use ($nameFieldName) {
72			return Str::startsWith($key, $nameFieldName);
73			})->keys()->first();
74			}
75
76			protected function respondToSpam(Request $request, Closure $next): Response {
77			event(new SpamDetected($request));
78
79			return $this->spamResponder->respond($request, $next);
80			}
81
82			private function shouldCheckHoneypot(Request $request, ?string $nameFieldName): bool {
83			if (config('honeypot.honeypot_fields_required_for_all_forms') == true) {
84			return true;
85			}
86
87			return $request->has($nameFieldName) \|\| $request->has(config('honeypot.valid_from_field_name'));
88			}
89			}
90

spatie / laravel-honeypot

Pull Request — master (#63)

ProtectAgainstSpam::handle() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like