GoogleCalendarServiceProvider::guardAgainstInvalidConfiguration() - Code Metrics - Inspection of "Allow passing array of credentials." - spatie/laravel-google-calendar - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#139)

by Mathieu

created 2020-02-21 16:25 UTC

GoogleCalendarServiceProvider::guardAgainstInvalidConfiguration() A

↳ Parent: Project

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0
cc	3
nc	3
nop	1

<?php

namespace Spatie\GoogleCalendar;

use Illuminate\Support\ServiceProvider;
use Spatie\GoogleCalendar\Exceptions\InvalidConfiguration;

class GoogleCalendarServiceProvider extends ServiceProvider
{
    public function boot()
    {
        $this->publishes([
            __DIR__.'/../config/google-calendar.php' => config_path('google-calendar.php'),
        ], 'config');
    }

    public function register()
    {
        $this->mergeConfigFrom(__DIR__.'/../config/google-calendar.php', 'google-calendar');

        $this->app->bind(GoogleCalendar::class, function () {
            $config = config('google-calendar');

            $this->guardAgainstInvalidConfiguration($config);

            return GoogleCalendarFactory::createForCalendarId($config['calendar_id']);
        });

        $this->app->alias(GoogleCalendar::class, 'laravel-google-calendar');
    }

    protected function guardAgainstInvalidConfiguration(array $config = null)
    {
        if (empty($config['calendar_id'])) {
            throw InvalidConfiguration::calendarIdNotSpecified();
        }

        $credentials = $config['service_account_credentials_json'];

        if  (!is_array($credentials) && !is_string($credentials)) {
            throw InvalidConfiguration::credentialsTypeWrong($credentials)
        }


        if (is_string($credentials) && ! file_exists($credentials)) {
            throw InvalidConfiguration::credentialsJsonDoesNotExist($credentials);
        }

    }
}


1			<?php
2
3			namespace Spatie\GoogleCalendar;
4
5			use Illuminate\Support\ServiceProvider;
6			use Spatie\GoogleCalendar\Exceptions\InvalidConfiguration;
7
8			class GoogleCalendarServiceProvider extends ServiceProvider
9			{
10			public function boot()
11			{
12			$this->publishes([
13			__DIR__.'/../config/google-calendar.php' => config_path('google-calendar.php'),
14			], 'config');
15			}
16
17			public function register()
18			{
19			$this->mergeConfigFrom(__DIR__.'/../config/google-calendar.php', 'google-calendar');
20
21			$this->app->bind(GoogleCalendar::class, function () {
22			$config = config('google-calendar');
23
24			$this->guardAgainstInvalidConfiguration($config);
25
26			return GoogleCalendarFactory::createForCalendarId($config['calendar_id']);
27			});
28
29			$this->app->alias(GoogleCalendar::class, 'laravel-google-calendar');
30			}
31
32			protected function guardAgainstInvalidConfiguration(array $config = null)
33			{
34			if (empty($config['calendar_id'])) {
35			throw InvalidConfiguration::calendarIdNotSpecified();
36			}
37
38			$credentials = $config['service_account_credentials_json'];
39
40			if (!is_array($credentials) && !is_string($credentials)) {
41			throw InvalidConfiguration::credentialsTypeWrong($credentials)
42			}
			0 ignored issues – show Bug introduced 2020-02-21 16:26 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected '}' Loading history...
43
44			if (is_string($credentials) && ! file_exists($credentials)) {
45			throw InvalidConfiguration::credentialsJsonDoesNotExist($credentials);
46			}
47
48			}
49			}
50

spatie / laravel-google-calendar

Pull Request — master (#139)

GoogleCalendarServiceProvider::guardAgainstInvalidConfiguration() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like