Feed::getFeedContent() - Code Metrics - Inspection of "refactor" - spatie/laravel-feed - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b9228c...be7367 )

by Freek

created 2016-03-02 23:07 UTC

Feed::getFeedContent() A

↳ Parent: Feed

Complexity

Conditions	2
Paths	2

Size

Total Lines	19
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	19
rs	9.4285
cc	2
eloc	11
nc	2
nop	1

<?php

namespace Spatie\Feed;

use Illuminate\Http\Response as HttpResponse;
use Illuminate\Support\Collection;
use Spatie\Feed\Exceptions\InvalidConfiguration;

class Feed
{
    public function getViewResponse(array $feedConfiguration) : HttpResponse
    {
        $feedContent = $this->getFeedContent($feedConfiguration);

        return response($feedContent, 200, ['Content-Type' => 'application/atom+xml; chartset=UTF-8']);
    }

    public function getFeedContent(array $feedConfiguration) : string
    {
        if (!str_contains($feedConfiguration['items'], '@')) {
            throw InvalidConfiguration::delimiterNotPresent($feedConfiguration['items']);
        }

        list($class, $method) = explode('@', $feedConfiguration['items']);

        $items = app($class)->$method();

        $meta = [
            'link' => $feedConfiguration['url'],
            'description' => $feedConfiguration['description'],
            'title' => $feedConfiguration['title'],
            'updated' => $this->getLastUpdatedDate($items, 'Y-m-d H:i:s'),
        ];

        return view('laravel-feed::feed', compact('meta', 'items'))->render();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    protected function getLastUpdatedDate(Collection $items, string $format) : string
    {
        $lastItem = $items
            ->sortBy(function (FeedItem $feedItem) {
                return  $feedItem->getFeedItemUpdated()->format('YmdHis');
            })
            ->last();

        return $lastItem->getFeedItemUpdated()->format($format);
    }
}


1			<?php
2
3			namespace Spatie\Feed;
4
5			use Illuminate\Http\Response as HttpResponse;
6			use Illuminate\Support\Collection;
7			use Spatie\Feed\Exceptions\InvalidConfiguration;
8
9			class Feed
10			{
11			public function getViewResponse(array $feedConfiguration) : HttpResponse
12			{
13			$feedContent = $this->getFeedContent($feedConfiguration);
14
15			return response($feedContent, 200, ['Content-Type' => 'application/atom+xml; chartset=UTF-8']);
16			}
17
18			public function getFeedContent(array $feedConfiguration) : string
19			{
20			if (!str_contains($feedConfiguration['items'], '@')) {
21			throw InvalidConfiguration::delimiterNotPresent($feedConfiguration['items']);
22			}
23
24			list($class, $method) = explode('@', $feedConfiguration['items']);
25
26			$items = app($class)->$method();
27
28			$meta = [
29			'link' => $feedConfiguration['url'],
30			'description' => $feedConfiguration['description'],
31			'title' => $feedConfiguration['title'],
32			'updated' => $this->getLastUpdatedDate($items, 'Y-m-d H:i:s'),
33			];
34
35			return view('laravel-feed::feed', compact('meta', 'items'))->render();
			0 ignored issues – show Bug introduced 2016-03-02 23:09 UTC by Report Bug Copy Issue Report The method `render` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
36			}
37
38			protected function getLastUpdatedDate(Collection $items, string $format) : string
39			{
40			$lastItem = $items
41			->sortBy(function (FeedItem $feedItem) {
42			return $feedItem->getFeedItemUpdated()->format('YmdHis');
43			})
44			->last();
45
46			return $lastItem->getFeedItemUpdated()->format($format);
47			}
48			}
49

spatie / laravel-feed

Push — master ( b9228c...be7367 )

Feed::getFeedContent() A

Complexity

Size

Duplication

Available Fixes

Duplication Side-by-Side

Filter issues like