LoadSnapshotCommand - Code Metrics - Inspection of "commit" - spatie/laravel-event-projector - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 763608...383f10 )

by Freek

created 2018-05-30 09:57 UTC

LoadSnapshotCommand A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	31
Duplicated Lines	45.16 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	1
dl	14
loc	31
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	handle()	14	14	2

How to fix Duplicated Code

<?php

namespace Spatie\EventProjector\Console\Snapshots;

use Illuminate\Console\Command;
use Spatie\EventProjector\Snapshots\SnapshotRepository;

class LoadSnapshotCommand extends Command
{
    protected $signature = 'event-projector:load-snapshot';

    protected $description = 'Load snapshots';

    /** @var \Spatie\EventProjector\Console\Snapshots\SnapshotRepository */
    protected $snapshotRepository;

    public function __construct(SnapshotRepository $snapshotRepository)
    {
        parent::__construct();

        $this->snapshotRepository = $snapshotRepository;

    }

    public function handle()

    {
        $snapshots = $this->snapshotRepository->get();

        $snapshot = $this->chooseSnapshot('Which snapshot number would like to load?', $snapshots);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        if (! $snapshot) {
            return;
        }

        $snapshot->load();

        $this->info('Snapshot loaded!');
    }
}


1		<?php
2
3		namespace Spatie\EventProjector\Console\Snapshots;
4
5		use Illuminate\Console\Command;
6		use Spatie\EventProjector\Snapshots\SnapshotRepository;
7
8		class LoadSnapshotCommand extends Command
9		{
10		protected $signature = 'event-projector:load-snapshot';
11
12		protected $description = 'Load snapshots';
13
14		/** @var \Spatie\EventProjector\Console\Snapshots\SnapshotRepository */
15		protected $snapshotRepository;
16
17		public function __construct(SnapshotRepository $snapshotRepository)
18		{
19		parent::__construct();
20
21		$this->snapshotRepository = $snapshotRepository;
		0 ignored issues – show Documentation Bug introduced 2018-05-30 10:00 UTC by Report Bug Copy Issue Report It seems like `$snapshotRepository` of type `object<Spatie\EventProje...ots\SnapshotRepository>` is incompatible with the declared type `object<Spatie\EventProje...ots\SnapshotRepository>` of property `$snapshotRepository`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
22		}
23
24	View Code Duplication	public function handle()
		0 ignored issues – show Duplication introduced 2018-05-30 10:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25		{
26		$snapshots = $this->snapshotRepository->get();
27
28		$snapshot = $this->chooseSnapshot('Which snapshot number would like to load?', $snapshots);
		0 ignored issues – show Documentation Bug introduced 2018-05-30 10:00 UTC by Report Bug Copy Issue Report The method `chooseSnapshot` does not exist on `object<Spatie\EventProje...ts\LoadSnapshotCommand>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
29
30		if (! $snapshot) {
31		return;
32		}
33
34		$snapshot->load();
35
36		$this->info('Snapshot loaded!');
37		}
38		}
39

spatie / laravel-event-projector

Push — master ( 763608...383f10 )

LoadSnapshotCommand A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like