ChooseSnapshot::chooseSnapshot() - Code Metrics - Inspection of "add reset command" - spatie/laravel-event-projector - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 91b636...82125a )

by Freek

created 2018-06-01 16:14 UTC

ChooseSnapshot::chooseSnapshot() A

↳ Parent: ChooseSnapshot

Complexity

Conditions	3
Paths	3

Size

Total Lines	20
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	20
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	10
nc	3
nop	2

<?php

namespace Spatie\EventProjector\Console\Snapshots\Concerns;

use Illuminate\Support\Collection;
use Spatie\EventProjector\Snapshots\Snapshot;

trait ChooseSnapshot
{
    public function chooseSnapshot(string $question, Collection $snapshots): ?Snapshot
    {
        if ($snapshots->isEmpty()) {
            $this->warn("There currently are no snapshots. You can take a snapshot by running `php artisan event-projector:create-snapshot`.");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

            return null;
        }

        $this->displaySnapshots($snapshots);

        $snapshotNumber = $this->ask($question);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        if (! $snapshot = $snapshots->get($snapshotNumber - 1)) {
            $this->error("There is no snapshot for that number.");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

            return null;
        }

        return $snapshot;
    }

    public function displaySnapshots(Collection $snapshots)
    {
        $titles = ['Number', 'Projector', 'Last processed event id', 'Created at', 'Name'];

        $rows = $snapshots->map(function (Snapshot $snapshot, int $index) {
            return [
                $index + 1,
                $snapshot->projectorName(),
                $snapshot->lastProcessedEventId(),
                $snapshot->createdAt(),
                $snapshot->name(),
            ];
        });

        $this->table($titles, $rows);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}

1			<?php
2
3			namespace Spatie\EventProjector\Console\Snapshots\Concerns;
4
5			use Illuminate\Support\Collection;
6			use Spatie\EventProjector\Snapshots\Snapshot;
7
8			trait ChooseSnapshot
9			{
10			public function chooseSnapshot(string $question, Collection $snapshots): ?Snapshot
11			{
12			if ($snapshots->isEmpty()) {
13			$this->warn("There currently are no snapshots. You can take a snapshot by running `php artisan event-projector:create-snapshot`.");
			0 ignored issues – show Bug introduced 2018-05-30 10:00 UTC by Report Bug Copy Issue Report It seems like `warn()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
14
15			return null;
16			}
17
18			$this->displaySnapshots($snapshots);
19
20			$snapshotNumber = $this->ask($question);
			0 ignored issues – show Bug introduced 2018-05-30 10:00 UTC by Report Bug Copy Issue Report It seems like `ask()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21
22			if (! $snapshot = $snapshots->get($snapshotNumber - 1)) {
23			$this->error("There is no snapshot for that number.");
			0 ignored issues – show Bug introduced 2018-05-30 10:00 UTC by Report Bug Copy Issue Report It seems like `error()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24
25			return null;
26			}
27
28			return $snapshot;
29			}
30
31			public function displaySnapshots(Collection $snapshots)
32			{
33			$titles = ['Number', 'Projector', 'Last processed event id', 'Created at', 'Name'];
34
35			$rows = $snapshots->map(function (Snapshot $snapshot, int $index) {
36			return [
37			$index + 1,
38			$snapshot->projectorName(),
39			$snapshot->lastProcessedEventId(),
40			$snapshot->createdAt(),
41			$snapshot->name(),
42			];
43			});
44
45			$this->table($titles, $rows);
			0 ignored issues – show Bug introduced 2018-06-01 16:16 UTC by Report Bug Copy Issue Report It seems like `table()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
46			}
47			}

spatie / laravel-event-projector

Push — master ( 91b636...82125a )

ChooseSnapshot::chooseSnapshot() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like