CreateSnapshotCommand::handle() - Code Metrics - Inspection of "commit" - spatie/laravel-event-projector - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3cd148...6fd5a8 )

by Freek

created 2018-05-27 06:33 UTC

CreateSnapshotCommand::handle() A

↳ Parent: CreateSnapshotCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
rs	9.4285
cc	2
eloc	7
nc	2
nop	0

<?php

namespace Spatie\EventProjector\Console\Snapshots;

use Illuminate\Console\Command;
use Spatie\EventProjector\EventProjectionist;
use Spatie\EventProjector\Snapshots\SnapshotFactory;
use Spatie\EventProjector\Snapshots\Snapshotter;

class CreateSnapshotCommand extends Command
{
    protected $signature = 'event-projector:create-snapshot {projectorName} {--name}';

    protected $description = 'Create new snapshots';

    /** @var \Spatie\EventProjector\EventProjectionist */
    protected $eventProjectionist;

    /** @var \Spatie\EventProjector\Snapshots\SnapshotFactory */
    protected $snapshotFactory;

    public function __construct(EventProjectionist $eventProjectionist, SnapshotFactory $snapshotFactory)
    {
        parent::__construct();

        $this->eventProjectionist = $eventProjectionist;

        $this->snapshotFactory = $snapshotFactory;
    }

    public function handle()
    {
        $projectorName = $this->argument('projectorName');

        $projector = $this->eventProjectionist->getProjector($projectorName);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        if (! $projector) {
            $this->warn("No projector named `{$projectorName}` found!");

            return;
        }

        $this->snapshotFactory->createForProjector($projector, $this->option('name'));

    }
}



1			<?php
2
3			namespace Spatie\EventProjector\Console\Snapshots;
4
5			use Illuminate\Console\Command;
6			use Spatie\EventProjector\EventProjectionist;
7			use Spatie\EventProjector\Snapshots\SnapshotFactory;
8			use Spatie\EventProjector\Snapshots\Snapshotter;
9
10			class CreateSnapshotCommand extends Command
11			{
12			protected $signature = 'event-projector:create-snapshot {projectorName} {--name}';
13
14			protected $description = 'Create new snapshots';
15
16			/** @var \Spatie\EventProjector\EventProjectionist */
17			protected $eventProjectionist;
18
19			/** @var \Spatie\EventProjector\Snapshots\SnapshotFactory */
20			protected $snapshotFactory;
21
22			public function __construct(EventProjectionist $eventProjectionist, SnapshotFactory $snapshotFactory)
23			{
24			parent::__construct();
25
26			$this->eventProjectionist = $eventProjectionist;
27
28			$this->snapshotFactory = $snapshotFactory;
29			}
30
31			public function handle()
32			{
33			$projectorName = $this->argument('projectorName');
34
35			$projector = $this->eventProjectionist->getProjector($projectorName);
			0 ignored issues – show Bug introduced 2018-05-27 06:35 UTC by Report Bug Copy Issue Report It seems like `$projectorName` defined by `$this->argument('projectorName')` on line `33` can also be of type `array`; however, `Spatie\EventProjector\Ev...tionist::getProjector()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
36
37			if (! $projector) {
38			$this->warn("No projector named `{$projectorName}` found!");
39
40			return;
41			}
42
43			$this->snapshotFactory->createForProjector($projector, $this->option('name'));
			0 ignored issues – show Bug introduced 2018-05-27 06:35 UTC by Report Bug Copy Issue Report It seems like `$this->option('name')` targeting `Illuminate\Console\Command::option()` can also be of type `array`; however, `Spatie\EventProjector\Sn...y::createForProjector()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
44			}
45			}
46
47

spatie / laravel-event-projector

Push — master ( 3cd148...6fd5a8 )

CreateSnapshotCommand::handle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like