Spatie\EventProjector\Snapshots\SnapshotFactory

Complexity

Total Complexity

8

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
B	createForProjector()	0	33	5
A	createForFile()	0	4	1
A	snapshotIsValid()	0	4	1

<?php

namespace Spatie\EventProjector\Snapshots;

use Exception;
use Illuminate\Contracts\Filesystem\Filesystem;
use Spatie\EventProjector\EventProjectionist;
use Spatie\EventProjector\Exceptions\CouldNotCreateSnapshot;

class SnapshotFactory
{
    /** @var \Spatie\EventProjector\EventProjectionist */
    protected $eventProjectionist;

    /** @var \Spatie\EventProjector\Snapshots\Filesystem */
    protected $disk;

    public function __construct(EventProjectionist $eventProjectionist, Filesystem $disk)
    {
        $this->eventProjectionist = $eventProjectionist;

        $this->disk = $disk;

It seems like $disk of type object<Illuminate\Contracts\Filesystem\Filesystem> is incompatible with the declared type object<Spatie\EventProjector\Snapshots\Filesystem> of property $disk.

    }

    public function createForProjector(Snapshottable $projector, string $name = ''): Snapshot
    {
        $lastEventId = $projector->getLastProcessedEventId();

        $fileName = "Snapshot---{$projector->getName()}---{$lastEventId}---{$name}.txt";

        $snapshot = new Snapshot(
            $this->eventProjectionist,
            $this->disk,
            $fileName
        );

        try {
            $projector->writeToSnapshot($snapshot);
        } catch (Exception $exception) {
            try {
                $snapshot->delete();
            } catch (Exception $exception) {

Consider adding a comment why this CATCH block is empty.

            }

            throw CouldNotCreateSnapshot::projectorThrewExceptionDuringWritingToSnapshot($projector, $exception);
        }

        if (!$this->disk->exists($fileName)) {
            throw CouldNotCreateSnapshot::projectorDidNotWriteAnythingToSnapshot($projector);
        }

        if (!static::snapshotIsValid($lastEventId)) {
            $snapshot->delete();
        }

        return $snapshot;
    }

    public function createForFile(Filesystem $disk, string $fileName): Snapshot
    {
        return new Snapshot($this->eventProjectionist, $disk, $fileName);
    }

    protected static function snapshotIsValid(int $lastEventId): bool

The parameter $lastEventId is not used and could be removed.

    {
        return true;
    }
}